Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42098 )
Change subject: mb/google/wdee: Disable WLAN for Wdee
......................................................................
Patch Set 3:
> Patch Set 3:
>
> > Patch Set 3:
> >
> > As I know, Waddledoo is just the one to use integrated WLAN and Waddledee is for discrete PCIe M.2 WLAN/BT module? Add Evan Green to confirm
>
> No, both Waddledoo and Waddledee use CNVi now. But both of them can support discrete WLAN/BT. Doo can support Intel's Discrete WiFi, whereas Dee can support Realtek's Discrete WiFi. So I wouldn't want to disable the concerned Root Port in the devicetree.
My Dee unit has Realtek in it. IIRC this change would break me.
01:00.0 Network controller: Realtek Semiconductor Co., Ltd. Device c822
--
To view, visit https://review.coreboot.org/c/coreboot/+/42098
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ac1c9a83fbbf03066c09774324313f62d58bc38
Gerrit-Change-Number: 42098
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Uday M Bhat
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marco Chen <marcochen(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 14 Jul 2020 19:07:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment