coreboot-gerrit July 2020

coreboot-gerrit@coreboot.org

1 participants
3166 discussions

Change in coreboot[master]: soc/amd/picasso/acpi: Delete unused and invalid OperationRegions
by Raul Rangel (Code Review) 15 Jul '20

15 Jul '20

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43427 ) Change subject: soc/amd/picasso/acpi: Delete unused and invalid OperationRegions ...................................................................... soc/amd/picasso/acpi: Delete unused and invalid OperationRegions 0xc50, 0xc52, 0xc6f don't exist on Picasso. The PCI config space registers define SATA and OHCI which are at the wrong bus locations. I just remove the whole section since it's not used. We never access the PCIe Error region, or the PM2 region either. BUG=b:153001807, b:154756391 TEST=Build Trembyle Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I98aee09770f1df9f553c94580c1ee00c06a9cec1 --- M src/soc/amd/picasso/acpi/pci_int.asl M src/soc/amd/picasso/acpi/pcie.asl 2 files changed, 0 insertions(+), 168 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/43427/1 diff --git a/src/soc/amd/picasso/acpi/pci_int.asl b/src/soc/amd/picasso/acpi/pci_int.asl index bd72b22..1f7951d 100644 --- a/src/soc/amd/picasso/acpi/pci_int.asl +++ b/src/soc/amd/picasso/acpi/pci_int.asl @@ -1,108 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ - /* PCIe Configuration Space for CONFIG_MMCONF_BUS_NUMBER busses */ - OperationRegion(PCFG, SystemMemory, PCBA, PCLN) /* Each bus consumes 1MB */ - Field(PCFG, ByteAcc, NoLock, Preserve) { - /* Byte offsets are computed using the following technique: - * ((bus number + 1) * ((device number * 8) * 4096)) + register offset - * The 8 comes from 8 functions per device, and 4096 bytes per function config space - */ - Offset(0x00088024), /* Byte offset to SATA register 24h - Bus 0, Device 17, Function 0 */ - STB5, 32, - Offset(0x00098042), /* Byte offset to OHCI0 register 42h - Bus 0, Device 19, Function 0 */ - PT0D, 1, - PT1D, 1, - PT2D, 1, - PT3D, 1, - PT4D, 1, - PT5D, 1, - PT6D, 1, - PT7D, 1, - PT8D, 1, - PT9D, 1, - Offset(0x000a0004), /* Byte offset to SMBUS register 4h - Bus 0, Device 20, Function 0 */ - SBIE, 1, - SBME, 1, - Offset(0x000a0008), /* Byte offset to SMBUS register 8h - Bus 0, Device 20, Function 0 */ - SBRI, 8, - Offset(0x000a0014), /* Byte offset to SMBUS register 14h - Bus 0, Device 20, Function 0 */ - SBB1, 32, - Offset(0x000a0078), /* Byte offset to SMBUS register 78h - Bus 0, Device 20, Function 0 */ - ,14, - P92E, 1, /* Port92 decode enable */ - } - - OperationRegion(SB5, SystemMemory, STB5, 0x1000) - Field(SB5, AnyAcc, NoLock, Preserve){ - /* Port 0 */ - Offset(0x120), /* Port 0 Task file status */ - P0ER, 1, - , 2, - P0DQ, 1, - , 3, - P0BY, 1, - Offset(0x128), /* Port 0 Serial ATA status */ - P0DD, 4, - , 4, - P0IS, 4, - Offset(0x12c), /* Port 0 Serial ATA control */ - P0DI, 4, - Offset(0x130), /* Port 0 Serial ATA error */ - , 16, - P0PR, 1, - - /* Port 1 */ - offset(0x1a0), /* Port 1 Task file status */ - P1ER, 1, - , 2, - P1DQ, 1, - , 3, - P1BY, 1, - Offset(0x1a8), /* Port 1 Serial ATA status */ - P1DD, 4, - , 4, - P1IS, 4, - Offset(0x1ac), /* Port 1 Serial ATA control */ - P1DI, 4, - Offset(0x1b0), /* Port 1 Serial ATA error */ - , 16, - P1PR, 1, - - /* Port 2 */ - Offset(0x220), /* Port 2 Task file status */ - P2ER, 1, - , 2, - P2DQ, 1, - , 3, - P2BY, 1, - Offset(0x228), /* Port 2 Serial ATA status */ - P2DD, 4, - , 4, - P2IS, 4, - Offset(0x22c), /* Port 2 Serial ATA control */ - P2DI, 4, - Offset(0x230), /* Port 2 Serial ATA error */ - , 16, - P2PR, 1, - - /* Port 3 */ - Offset(0x2a0), /* Port 3 Task file status */ - P3ER, 1, - , 2, - P3DQ, 1, - , 3, - P3BY, 1, - Offset(0x2a8), /* Port 3 Serial ATA status */ - P3DD, 4, - , 4, - P3IS, 4, - Offset(0x2aC), /* Port 3 Serial ATA control */ - P3DI, 4, - Offset(0x2b0), /* Port 3 Serial ATA error */ - , 16, - P3PR, 1, - } - Method(\_PIC, 0x01, NotSerialized) { If (Arg0) diff --git a/src/soc/amd/picasso/acpi/pcie.asl b/src/soc/amd/picasso/acpi/pcie.asl index c11e63d..83da985 100644 --- a/src/soc/amd/picasso/acpi/pcie.asl +++ b/src/soc/amd/picasso/acpi/pcie.asl @@ -64,68 +64,3 @@ IUA3, 0x00000008, /* Index 0xF9: UART3 */ } - /* PCI Error control register */ - OperationRegion(PERC, SystemIO, 0x00000c14, 0x00000001) - Field(PERC, ByteAcc, NoLock, Preserve) { - SENS, 0x00000001, - PENS, 0x00000001, - SENE, 0x00000001, - PENE, 0x00000001, - } - - /* Client Management index/data registers */ - OperationRegion(CMT, SystemIO, 0x00000c50, 0x00000002) - Field(CMT, ByteAcc, NoLock, Preserve) { - CMTI, 8, - /* Client Management Data register */ - G64E, 1, - G64O, 1, - G32O, 2, - , 2, - GPSL, 2, - } - - /* GPM Port register */ - OperationRegion(GPT, SystemIO, 0x00000c52, 0x00000001) - Field(GPT, ByteAcc, NoLock, Preserve) { - GPB0,1, - GPB1,1, - GPB2,1, - GPB3,1, - GPB4,1, - GPB5,1, - GPB6,1, - GPB7,1, - } - - /* Flash ROM program enable register */ - OperationRegion(FRE, SystemIO, 0x00000c6F, 0x00000001) - Field(FRE, ByteAcc, NoLock, Preserve) { - , 0x00000006, - FLRE, 0x00000001, - } - - /* PM2 index/data registers */ - OperationRegion(PM2R, SystemIO, 0x00000Cd0, 0x00000002) - Field(PM2R, ByteAcc, NoLock, Preserve) { - PM2I, 0x00000008, - PM2D, 0x00000008, - } - - /* Power Management I/O registers, TODO:PMIO is quite different in SB800. */ - OperationRegion(PIOR, SystemIO, 0x00000Cd6, 0x00000002) - Field(PIOR, ByteAcc, NoLock, Preserve) { - PIOI, 0x00000008, - PIOD, 0x00000008, - } - - IndexField (PIOI, PIOD, ByteAcc, NoLock, Preserve) { - Offset(0x60), /* AcpiPm1EvgBlk */ - P1EB, 16, - } - OperationRegion (P1E0, SystemIO, P1EB, 0x04) - Field (P1E0, ByteAcc, Nolock, Preserve) { - Offset(0x02), - , 14, - PEWD, 1, - } -- To view, visit https://review.coreboot.org/c/coreboot/+/43427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I98aee09770f1df9f553c94580c1ee00c06a9cec1 Gerrit-Change-Number: 43427 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

5 5

Change in coreboot[master]: soc/amd/picasso/acpi: Remove old AOAC register definitions
by Raul Rangel (Code Review) 15 Jul '20

15 Jul '20

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43426 ) Change subject: soc/amd/picasso/acpi: Remove old AOAC register definitions ...................................................................... soc/amd/picasso/acpi: Remove old AOAC register definitions We no longer need this code. It's been added differently in CB:42473. BUG=b:153001807, b:154756391 TEST=Build Trembyle Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I6fe1e465f137ba6afbf9f0dbce501b5fc845e210 --- M src/soc/amd/picasso/acpi/sb_pci0_fch.asl 1 file changed, 0 insertions(+), 361 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/43426/1 diff --git a/src/soc/amd/picasso/acpi/sb_pci0_fch.asl b/src/soc/amd/picasso/acpi/sb_pci0_fch.asl index db81c06..a8dd319 100644 --- a/src/soc/amd/picasso/acpi/sb_pci0_fch.asl +++ b/src/soc/amd/picasso/acpi/sb_pci0_fch.asl @@ -144,364 +144,3 @@ } Return(OSVR) } - -OperationRegion(SMIC, SystemMemory, 0xfed80000, 0x80000) -Field( SMIC, ByteAcc, NoLock, Preserve) { - /* MISC registers */ - offset (0x03ee), - U3PS, 2, /* Usb3PowerSel */ - - offset (0x0e28), - ,29 , - SARP, 1, /* Sata Ref Clock Powerdown */ - U2RP, 1, /* Usb2 Ref Clock Powerdown */ - U3RP, 1, /* Usb3 Ref Clock Powerdown */ - - /* AOAC Registers */ - offset (0x1e4a), /* I2C0 D3 Control */ - I0TD, 2, - , 1, - I0PD, 1, - offset (0x1e4b), /* I2C0 D3 State */ - I0DS, 3, - - offset (0x1e4c), /* I2C1 D3 Control */ - I1TD, 2, - , 1, - I1PD, 1, - offset (0x1e4d), /* I2C1 D3 State */ - I1DS, 3, - - offset (0x1e4e), /* I2C2 D3 Control */ - I2TD, 2, - , 1, - I2PD, 1, - offset (0x1e4f), /* I2C2 D3 State */ - I2DS, 3, - - offset (0x1e50), /* I2C3 D3 Control */ - I3TD, 2, - , 1, - I3PD, 1, - offset (0x1e51), /* I2C3 D3 State */ - I3DS, 3, - - offset (0x1e56), /* UART0 D3 Control */ - U0TD, 2, - , 1, - U0PD, 1, - offset (0x1e57), /* UART0 D3 State */ - U0DS, 3, - - offset (0x1e58), /* UART1 D3 Control */ - U1TD, 2, - , 1, - U1PD, 1, - offset (0x1e59), /* UART1 D3 State */ - U1DS, 3, - - offset (0x1e60), /* UART2 D3 Control */ - U2TD, 2, - , 1, - U2PD, 1, - offset (0x1e61), /* UART2 D3 State */ - U2DS, 3, - - offset (0x1e71), /* SD D3 State */ - SDDS, 3, - - offset (0x1e74), /* UART3 D3 Control */ - U3TD, 2, - , 1, - U3PD, 1, - offset (0x1e75), /* UART3 D3 State */ - U3DS, 3, - - offset (0x1e80), /* Shadow Register Request */ - , 15, - RQ15, 1, - , 2, - RQ18, 1, - , 4, - RQ23, 1, - RQ24, 1, - , 5, - RQTY, 1, - offset (0x1e84), /* Shadow Register Status */ - , 15, - SASR, 1, /* SATA 15 Shadow Reg Request Status Register */ - , 2, - U2SR, 1, /* USB2 18 Shadow Reg Request Status Register */ - , 4, - U3SR, 1, /* USB3 23 Shadow Reg Request Status Register */ - SDSR, 1, /* SD 24 Shadow Reg Request Status Register */ - - offset (0x1ea0), /* PwrGood Control */ - PG1A, 1, - PG2_, 1, - ,1, - U3PG, 1, /* Usb3 Power Good BIT3 */ - - offset (0x1ea3), /* PwrGood Control b[31:24] */ - PGA3, 8 , -} - -OperationRegion(FCFG, SystemMemory, PCBA, 0x01000000) -Field(FCFG, DwordAcc, NoLock, Preserve) -{ - /* XHCI */ - Offset(0x00080010), /* Base address */ - XHBA, 32, - Offset(0x0008002c), /* Subsystem ID / Vendor ID */ - XH2C, 32, - - Offset(0x00080048), /* Indirect PCI Index Register */ - IDEX, 32, - DATA, 32, - Offset(0x00080054), /* PME Control / Status */ - U_PS, 2, - - /* EHCI */ - Offset(0x00090004), /* Control */ - , 1, - EHME, 1, - Offset(0x00090010), /* Base address */ - EHBA, 32, - Offset(0x0009002c), /* Subsystem ID / Vendor ID */ - EH2C, 32, - Offset(0x00090054), /* EHCI Spare 1 */ - EH54, 8, - Offset(0x00090064), /* Misc Control 2 */ - EH64, 8, - - Offset(0x000900c4), /* PME Control / Status */ - E_PS, 2, - - /* LPC Bridge */ - Offset(0x000a30cb), /* ClientRomProtect[31:24] */ - , 7, - AUSS, 1, /* AutoSizeStart */ -} - -/* - * Arg0:device: - * 5=I2C0, 6=I2C1, 7=I2C2, 8=I2C3, 11=UART0, 12=UART1, - * 18=EHCI, 23=xHCI, 24=SD - * Arg1:D-state - */ -Mutex (FDAS, 0) /* FCH Device AOAC Semophore */ -Method(FDDC, 2, Serialized) -{ - Acquire(FDAS, 0xffff) - - if(LEqual(Arg1, 0)) { - Switch(ToInteger(Arg0)) { - Case(Package() {5, 15, 24}) { - Store(One, PG1A) - } - Case(Package() {6, 7, 8, 11, 12, 18}) { - Store(One, PG2_) - } - } - /* put device into D0 */ - Switch(ToInteger(Arg0)) - { - Case(5) { - Store(0x00, I0TD) - Store(One, I0PD) - Store(I0DS, Local0) - while(LNotEqual(Local0,0x7)) { - Store(I0DS, Local0) - } - } - Case(6) { - Store(0x00, I1TD) - Store(One, I1PD) - Store(I1DS, Local0) - while(LNotEqual(Local0,0x7)) { - Store(I1DS, Local0) - } - } - Case(7) { - Store(0x00, I2TD) - Store(One, I2PD) - Store(I2DS, Local0) - while(LNotEqual(Local0,0x7)) { - Store(I2DS, Local0) - } - } - Case(8) {Store(0x00, I3TD) - Store(One, I3PD) - Store(I3DS, Local0) - while(LNotEqual(Local0,0x7)) { - Store(I3DS, Local0) - } - } - Case(11) { - Store(0x00, U0TD) - Store(One, U0PD) - Store(U0DS, Local0) - while(LNotEqual(Local0,0x7)) { - Store(U0DS, Local0) - } - } - Case(12) { - Store(0x00, U1TD) - Store(One, U1PD) - Store(U1DS, Local0) - while(LNotEqual(Local0,0x7)) { - Store(U1DS, Local0) - } - } - Case(16) { - Store(0x00, U2TD) - Store(One, U2PD) - Store(U2DS, Local0) - while(LNotEqual(Local0,0x7)) { - Store(U2DS, Local0) - } - } - Case(26) { - Store(0x00, U3TD) - Store(One, U3PD) - Store(U3DS, Local0) - while(LNotEqual(Local0,0x7)) { - Store(U3DS, Local0) - } - } - } - } else { - /* put device into D3cold */ - Switch(ToInteger(Arg0)) - { - Case(5) { - Store(Zero, I0PD) - Store(I0DS, Local0) - while(LNotEqual(Local0,0x0)) { - Store(I0DS, Local0) - } - Store(0x03, I0TD) - } - Case(6) { - Store(Zero, I1PD) - Store(I1DS, Local0) - while(LNotEqual(Local0,0x0)) { - Store(I1DS, Local0) - } - Store(0x03, I1TD) - } - Case(7) { - Store(Zero, I2PD) - Store(I2DS, Local0) - while(LNotEqual(Local0,0x0)) { - Store(I2DS, Local0) - } - Store(0x03, I2TD)} - Case(8) { - Store(Zero, I3PD) - Store(I3DS, Local0) - while(LNotEqual(Local0,0x0)) { - Store(I3DS, Local0) - } - Store(0x03, I3TD) - } - Case(11) { - Store(Zero, U0PD) - Store(U0DS, Local0) - while(LNotEqual(Local0,0x0)) { - Store(U0DS, Local0) - } - Store(0x03, U0TD) - } - Case(12) { - Store(Zero, U1PD) - Store(U1DS, Local0) - while(LNotEqual(Local0,0x0)) { - Store(U1DS, Local0) - } - Store(0x03, U1TD) - } - Case(16) { - Store(Zero, U2PD) - Store(U2DS, Local0) - while(LNotEqual(Local0,0x0)) { - Store(U2DS, Local0) - } - Store(0x03, U2TD) - } - Case(26) { - Store(Zero, U3PD) - Store(U3DS, Local0) - while(LNotEqual(Local0,0x0)) { - Store(U3DS, Local0) - } - Store(0x03, U3TD) - } - } - if(LEqual(I1TD, 3)) { - if(LEqual(I2TD, 3)) { - if(LEqual(I3TD, 3)) { - if(LEqual(U0TD, 3)) { - if(LEqual(U1TD, 3)) { - Store(Zero, PG2_) - } - } - } - } - } - } - Release(FDAS) -} - -Method(FPTS,0, Serialized) /* FCH _PTS */ -{ -} - -Method(FWAK,0, Serialized) /* FCH _WAK */ -{ - if(LEqual(\UT0E, zero)) { - if(LNotEqual(U0TD, 0x03)) { - FDDC(11, 3) - } - } - if(LEqual(\UT1E, zero)) { - if(LNotEqual(U1TD, 0x03)) { - FDDC(12, 3) - } - } - if(LEqual(\IC2E, zero)) { - if(LNotEqual(I2TD, 0x03)) { - FDDC(7, 3) - } - } - if(LEqual(\IC3E, zero)) { - if(LNotEqual(I3TD, 0x03)) { - FDDC(8, 3) - } - } -} - -/* - * Helper for setting a bit in AOACxA0 PwrGood Control - * Arg0: bit to set or clear - * Arg1: 0 = clear bit[Arg0], non-zero = set bit[Arg0] - */ -Method(PWGC,2, Serialized) -{ - And (PGA3, 0xdf, Local0) /* do SwUsb3SlpShutdown below */ - if(Arg1) { - Or(Arg0, Local0, Local0) - } else { - Not(Arg0, Local1) - And(Local1, Local0, Local0) - } - Store(Local0, PGA3) - if(LEqual(Arg0, 0x20)) { /* if SwUsb3SlpShutdown */ - Store(PGA3, Local0) - And(Arg0, Local0, Local0) - while(LNot(Local0)) { /* wait SwUsb3SlpShutdown to complete */ - Store(PGA3, Local0) - And(Arg0, Local0, Local0) - } - } -} -- To view, visit https://review.coreboot.org/c/coreboot/+/43426 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6fe1e465f137ba6afbf9f0dbce501b5fc845e210 Gerrit-Change-Number: 43426 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

6 5

Change in coreboot[master]: soc/amd/picasso/acpi: Remove invalid and unnecessary devices
by Raul Rangel (Code Review) 15 Jul '20

15 Jul '20

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43425 ) Change subject: soc/amd/picasso/acpi: Remove invalid and unnecessary devices ...................................................................... soc/amd/picasso/acpi: Remove invalid and unnecessary devices These devices are not referenced by anything else. BUG=b:153001807, b:154756391 TEST=None Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I6ea3c326247dce095b5ac1706dbc37f8b215a21e --- M src/soc/amd/picasso/acpi/northbridge.asl M src/soc/amd/picasso/acpi/sb_pci0_fch.asl 2 files changed, 0 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/43425/1 diff --git a/src/soc/amd/picasso/acpi/northbridge.asl b/src/soc/amd/picasso/acpi/northbridge.asl index f2a709f..a81d3b2 100644 --- a/src/soc/amd/picasso/acpi/northbridge.asl +++ b/src/soc/amd/picasso/acpi/northbridge.asl @@ -49,7 +49,3 @@ { Return(PR0) } - -Device(AMRT) { - Name(_ADR, 0x00000000) -} /* end AMRT */ diff --git a/src/soc/amd/picasso/acpi/sb_pci0_fch.asl b/src/soc/amd/picasso/acpi/sb_pci0_fch.asl index 88d941f..db81c06 100644 --- a/src/soc/amd/picasso/acpi/sb_pci0_fch.asl +++ b/src/soc/amd/picasso/acpi/sb_pci0_fch.asl @@ -20,15 +20,6 @@ } } -/* Describe the Southbridge devices */ - -/* 0:14.0 - SMBUS */ -Device(SBUS) { - Name(_ADR, 0x00140000) -} /* end SBUS */ - -/* 0:14.2 - I2S Audio */ - /* 0:14.3 - LPC */ #include <soc/amd/common/acpi/lpc.asl> -- To view, visit https://review.coreboot.org/c/coreboot/+/43425 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6ea3c326247dce095b5ac1706dbc37f8b215a21e Gerrit-Change-Number: 43425 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

5 4

Change in coreboot[master]: mb/google/zork/.../sleep.asl: Remove unnecessary variable
by Raul Rangel (Code Review) 15 Jul '20

15 Jul '20

Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43423 ) Change subject: mb/google/zork/.../sleep.asl: Remove unnecessary variable ...................................................................... mb/google/zork/.../sleep.asl: Remove unnecessary variable There is no reason to create a named variable. We can just return the package. BUG=b:153001807, b:154756391 TEST=None Signed-off-by: Raul E Rangel <rrangel(a)chromium.org> Change-Id: I4f8f0362adf5ea5f026d0ba5ac6ac917fa160142 --- M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/43423/1 diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl index c8fb05f..a5f2490 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl @@ -1,8 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ -/* Wake status package */ -Name(WKST,Package(){Zero, Zero}) - /* * \_PTS - Prepare to Sleep method * @@ -25,10 +22,7 @@ /* DBGO(Arg0) */ /* DBGO("\n") */ - /* Clear wake status structure. */ Store(0, PEWD) - Store(0, Index(WKST,0)) - Store(0, Index(WKST,1)) Store(7, UPWS) } /* End Method(\_PTS) */ @@ -69,5 +63,5 @@ /* DBGO(Arg0) */ /* DBGO(" to S0\n") */ - Return(WKST) + Return(Package(){Zero, Zero}) } /* End Method(\_WAK) */ -- To view, visit https://review.coreboot.org/c/coreboot/+/43423 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f8f0362adf5ea5f026d0ba5ac6ac917fa160142 Gerrit-Change-Number: 43423 Gerrit-PatchSet: 1 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: newchange

5 7

Change in coreboot[master]: PCI IDs: Add PCI ID for JSL DPTF/DTT PCI device
by Tim Wawrzynczak (Code Review) 15 Jul '20

15 Jul '20

Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43421 ) Change subject: PCI IDs: Add PCI ID for JSL DPTF/DTT PCI device ...................................................................... PCI IDs: Add PCI ID for JSL DPTF/DTT PCI device This PCI ID is required in order for JSL devices to perform SSDT generation for DPTF. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I42209d15bc4f1654814465ce1412576f7349dddc --- M src/include/device/pci_ids.h M src/soc/intel/common/block/dtt/dtt.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/43421/1 diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 2a527d7..62220d8 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3720,6 +3720,7 @@ /* Intel Dynamic Tuning Technology Device */ #define PCI_DEVICE_ID_INTEL_TGL_DTT 0x9A03 +#define PCI_DEVICE_ID_INTEL_JSL_DTT 0x4E03 #define PCI_VENDOR_ID_COMPUTONE 0x8e0e #define PCI_DEVICE_ID_COMPUTONE_IP2EX 0x0291 diff --git a/src/soc/intel/common/block/dtt/dtt.c b/src/soc/intel/common/block/dtt/dtt.c index 14987ea..f396993 100644 --- a/src/soc/intel/common/block/dtt/dtt.c +++ b/src/soc/intel/common/block/dtt/dtt.c @@ -6,6 +6,7 @@ static const unsigned short pci_device_ids[] = { PCI_DEVICE_ID_INTEL_TGL_DTT, + PCI_DEVICE_ID_INTEL_JSL_DTT, }; static struct device_operations dptf_dev_ops = { -- To view, visit https://review.coreboot.org/c/coreboot/+/43421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42209d15bc4f1654814465ce1412576f7349dddc Gerrit-Change-Number: 43421 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newchange

4 4

Change in coreboot[master]: util/intelmetool: Fix error message
by Evgeny Zinoviev (Code Review) 15 Jul '20

15 Jul '20

Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43357 ) Change subject: util/intelmetool: Fix error message ...................................................................... util/intelmetool: Fix error message Add a missing space to the message. Change-Id: I7d4042ebb587af8558294fb4961100b43910fd4a Signed-off-by: Evgeny Zinoviev <me(a)ch1p.io> --- M util/intelmetool/intelmetool.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/43357/1 diff --git a/util/intelmetool/intelmetool.c b/util/intelmetool/intelmetool.c index 426fa97..482fd5b 100644 --- a/util/intelmetool/intelmetool.c +++ b/util/intelmetool/intelmetool.c @@ -293,7 +293,7 @@ printf("\n"); if (stat & 0xf000) - printf("ME: has a broken implementation on your board with" + printf("ME: has a broken implementation on your board with " "this firmware\n"); if (intel_mei_setup(dev)) -- To view, visit https://review.coreboot.org/c/coreboot/+/43357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d4042ebb587af8558294fb4961100b43910fd4a Gerrit-Change-Number: 43357 Gerrit-PatchSet: 1 Gerrit-Owner: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-MessageType: newchange

4 3

Change in coreboot[master]: mainboard: Drop deprecated and empty ACPI \_BFS methods
by Angel Pons (Code Review) 15 Jul '20

15 Jul '20

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43443 ) Change subject: mainboard: Drop deprecated and empty ACPI \_BFS methods ...................................................................... mainboard: Drop deprecated and empty ACPI \_BFS methods The ACPI specification, version 6.3 says: Compatibility issue: The _BFS (Back From Sleep) and _GTS (Going To Sleep) methods were deprecated in ACPI 5.0A. So, remove them. They have been copy-pasted around quite a bit. Change-Id: I9ef21f231dd6051d410ac3a0fe554908409c2fa7 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/amd/gardenia/acpi/sleep.asl M src/mainboard/amd/inagua/acpi/sleep.asl M src/mainboard/amd/mandolin/acpi/sleep.asl M src/mainboard/amd/olivehill/acpi/sleep.asl M src/mainboard/amd/padmelon/acpi/sleep.asl M src/mainboard/amd/parmer/acpi/sleep.asl M src/mainboard/amd/persimmon/acpi/sleep.asl M src/mainboard/amd/south_station/acpi/sleep.asl M src/mainboard/amd/thatcher/acpi/sleep.asl M src/mainboard/amd/union_station/acpi/sleep.asl M src/mainboard/asrock/e350m1/acpi/sleep.asl M src/mainboard/asrock/imb-a180/acpi/sleep.asl M src/mainboard/asus/am1i-a/acpi/sleep.asl M src/mainboard/asus/f2a85-m/acpi/sleep.asl M src/mainboard/bap/ode_e20XX/acpi/sleep.asl M src/mainboard/biostar/a68n_5200/acpi/sleep.asl M src/mainboard/biostar/am1ml/acpi/sleep.asl M src/mainboard/elmex/pcm205400/acpi/sleep.asl M src/mainboard/gizmosphere/gizmo/acpi/sleep.asl M src/mainboard/gizmosphere/gizmo2/acpi/sleep.asl M src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl M src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl M src/mainboard/hp/abm/acpi/sleep.asl M src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl M src/mainboard/jetway/nf81-t56n-lf/acpi/sleep.asl M src/mainboard/lenovo/g505s/acpi/sleep.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/lippert/toucan-af/dsdt.asl M src/mainboard/msi/ms7721/acpi/sleep.asl M src/mainboard/pcengines/apu1/acpi/sleep.asl M src/mainboard/pcengines/apu2/acpi/sleep.asl 31 files changed, 0 insertions(+), 489 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/43443/1 diff --git a/src/mainboard/amd/gardenia/acpi/sleep.asl b/src/mainboard/amd/gardenia/acpi/sleep.asl index 0b65ab1..89c6fa1 100644 --- a/src/mainboard/amd/gardenia/acpi/sleep.asl +++ b/src/mainboard/amd/gardenia/acpi/sleep.asl @@ -33,22 +33,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/amd/inagua/acpi/sleep.asl b/src/mainboard/amd/inagua/acpi/sleep.asl index 6fd128d..76b5f9e 100644 --- a/src/mainboard/amd/inagua/acpi/sleep.asl +++ b/src/mainboard/amd/inagua/acpi/sleep.asl @@ -46,22 +46,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/amd/mandolin/acpi/sleep.asl b/src/mainboard/amd/mandolin/acpi/sleep.asl index 0b65ab1..89c6fa1 100644 --- a/src/mainboard/amd/mandolin/acpi/sleep.asl +++ b/src/mainboard/amd/mandolin/acpi/sleep.asl @@ -33,22 +33,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/amd/olivehill/acpi/sleep.asl b/src/mainboard/amd/olivehill/acpi/sleep.asl index 2721bd8..47dd146 100644 --- a/src/mainboard/amd/olivehill/acpi/sleep.asl +++ b/src/mainboard/amd/olivehill/acpi/sleep.asl @@ -37,22 +37,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/amd/padmelon/acpi/sleep.asl b/src/mainboard/amd/padmelon/acpi/sleep.asl index 0b65ab1..89c6fa1 100644 --- a/src/mainboard/amd/padmelon/acpi/sleep.asl +++ b/src/mainboard/amd/padmelon/acpi/sleep.asl @@ -33,22 +33,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/amd/parmer/acpi/sleep.asl b/src/mainboard/amd/parmer/acpi/sleep.asl index 5b78d60..dde9c37 100644 --- a/src/mainboard/amd/parmer/acpi/sleep.asl +++ b/src/mainboard/amd/parmer/acpi/sleep.asl @@ -43,22 +43,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/amd/persimmon/acpi/sleep.asl b/src/mainboard/amd/persimmon/acpi/sleep.asl index 6fd128d..76b5f9e 100644 --- a/src/mainboard/amd/persimmon/acpi/sleep.asl +++ b/src/mainboard/amd/persimmon/acpi/sleep.asl @@ -46,22 +46,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/amd/south_station/acpi/sleep.asl b/src/mainboard/amd/south_station/acpi/sleep.asl index 6fd128d..76b5f9e 100644 --- a/src/mainboard/amd/south_station/acpi/sleep.asl +++ b/src/mainboard/amd/south_station/acpi/sleep.asl @@ -46,22 +46,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/amd/thatcher/acpi/sleep.asl b/src/mainboard/amd/thatcher/acpi/sleep.asl index b75cc4f..af87ce6 100644 --- a/src/mainboard/amd/thatcher/acpi/sleep.asl +++ b/src/mainboard/amd/thatcher/acpi/sleep.asl @@ -43,22 +43,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/amd/union_station/acpi/sleep.asl b/src/mainboard/amd/union_station/acpi/sleep.asl index 6fd128d..76b5f9e 100644 --- a/src/mainboard/amd/union_station/acpi/sleep.asl +++ b/src/mainboard/amd/union_station/acpi/sleep.asl @@ -46,22 +46,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/asrock/e350m1/acpi/sleep.asl b/src/mainboard/asrock/e350m1/acpi/sleep.asl index 6fd128d..76b5f9e 100644 --- a/src/mainboard/asrock/e350m1/acpi/sleep.asl +++ b/src/mainboard/asrock/e350m1/acpi/sleep.asl @@ -46,22 +46,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/asrock/imb-a180/acpi/sleep.asl b/src/mainboard/asrock/imb-a180/acpi/sleep.asl index 2721bd8..47dd146 100644 --- a/src/mainboard/asrock/imb-a180/acpi/sleep.asl +++ b/src/mainboard/asrock/imb-a180/acpi/sleep.asl @@ -37,22 +37,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/asus/am1i-a/acpi/sleep.asl b/src/mainboard/asus/am1i-a/acpi/sleep.asl index 2721bd8..47dd146 100644 --- a/src/mainboard/asus/am1i-a/acpi/sleep.asl +++ b/src/mainboard/asus/am1i-a/acpi/sleep.asl @@ -37,22 +37,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/asus/f2a85-m/acpi/sleep.asl b/src/mainboard/asus/f2a85-m/acpi/sleep.asl index d060576..e08accd 100644 --- a/src/mainboard/asus/f2a85-m/acpi/sleep.asl +++ b/src/mainboard/asus/f2a85-m/acpi/sleep.asl @@ -43,22 +43,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/bap/ode_e20XX/acpi/sleep.asl b/src/mainboard/bap/ode_e20XX/acpi/sleep.asl index 2721bd8..47dd146 100644 --- a/src/mainboard/bap/ode_e20XX/acpi/sleep.asl +++ b/src/mainboard/bap/ode_e20XX/acpi/sleep.asl @@ -37,22 +37,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/biostar/a68n_5200/acpi/sleep.asl b/src/mainboard/biostar/a68n_5200/acpi/sleep.asl index 2721bd8..47dd146 100644 --- a/src/mainboard/biostar/a68n_5200/acpi/sleep.asl +++ b/src/mainboard/biostar/a68n_5200/acpi/sleep.asl @@ -37,22 +37,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/biostar/am1ml/acpi/sleep.asl b/src/mainboard/biostar/am1ml/acpi/sleep.asl index 2721bd8..47dd146 100644 --- a/src/mainboard/biostar/am1ml/acpi/sleep.asl +++ b/src/mainboard/biostar/am1ml/acpi/sleep.asl @@ -37,22 +37,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/elmex/pcm205400/acpi/sleep.asl b/src/mainboard/elmex/pcm205400/acpi/sleep.asl index 6fd128d..76b5f9e 100644 --- a/src/mainboard/elmex/pcm205400/acpi/sleep.asl +++ b/src/mainboard/elmex/pcm205400/acpi/sleep.asl @@ -46,22 +46,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/gizmosphere/gizmo/acpi/sleep.asl b/src/mainboard/gizmosphere/gizmo/acpi/sleep.asl index 6fd128d..76b5f9e 100644 --- a/src/mainboard/gizmosphere/gizmo/acpi/sleep.asl +++ b/src/mainboard/gizmosphere/gizmo/acpi/sleep.asl @@ -46,22 +46,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/gizmosphere/gizmo2/acpi/sleep.asl b/src/mainboard/gizmosphere/gizmo2/acpi/sleep.asl index 2721bd8..47dd146 100644 --- a/src/mainboard/gizmosphere/gizmo2/acpi/sleep.asl +++ b/src/mainboard/gizmosphere/gizmo2/acpi/sleep.asl @@ -37,22 +37,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl index efd1dc4..d151e1d 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl +++ b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/sleep.asl @@ -36,23 +36,6 @@ } /* - * \_BFS OEM Back From Sleep method - * - * Entry: - * Arg0=The value of the sleeping state S1=1, S2=2 - * - * Exit: - * -none- - */ -Method (\_BFS, 1) -{ - /* DBGO ("\\_BFS\n") */ - /* DBGO ("From S") */ - /* DBGO (Arg0) */ - /* DBGO (" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl index c8fb05f..90cc0d8 100644 --- a/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl +++ b/src/mainboard/google/zork/variants/baseboard/include/baseboard/acpi/sleep.asl @@ -33,22 +33,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/hp/abm/acpi/sleep.asl b/src/mainboard/hp/abm/acpi/sleep.asl index 2721bd8..47dd146 100644 --- a/src/mainboard/hp/abm/acpi/sleep.asl +++ b/src/mainboard/hp/abm/acpi/sleep.asl @@ -37,22 +37,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl index 5b78d60..dde9c37 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/sleep.asl @@ -43,22 +43,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/jetway/nf81-t56n-lf/acpi/sleep.asl b/src/mainboard/jetway/nf81-t56n-lf/acpi/sleep.asl index 6fd128d..76b5f9e 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/acpi/sleep.asl +++ b/src/mainboard/jetway/nf81-t56n-lf/acpi/sleep.asl @@ -46,22 +46,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/lenovo/g505s/acpi/sleep.asl b/src/mainboard/lenovo/g505s/acpi/sleep.asl index 5b78d60..dde9c37 100644 --- a/src/mainboard/lenovo/g505s/acpi/sleep.asl +++ b/src/mainboard/lenovo/g505s/acpi/sleep.asl @@ -43,22 +43,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl index 710a707..2b7c11a 100644 --- a/src/mainboard/lippert/frontrunner-af/dsdt.asl +++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl @@ -761,18 +761,6 @@ } /* End Method(\_PTS) */ /* - * \_BFS OEM Back From Sleep method - * - * Entry: - * Arg0=The value of the sleeping state S1=1, S2=2 - * - * Exit: - * -none- - */ - Method(\_BFS, 1) { - } - - /* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/lippert/toucan-af/dsdt.asl b/src/mainboard/lippert/toucan-af/dsdt.asl index 17837c4..5b54b8c 100644 --- a/src/mainboard/lippert/toucan-af/dsdt.asl +++ b/src/mainboard/lippert/toucan-af/dsdt.asl @@ -761,18 +761,6 @@ } /* End Method(\_PTS) */ /* - * \_BFS OEM Back From Sleep method - * - * Entry: - * Arg0=The value of the sleeping state S1=1, S2=2 - * - * Exit: - * -none- - */ - Method(\_BFS, 1) { - } - - /* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/msi/ms7721/acpi/sleep.asl b/src/mainboard/msi/ms7721/acpi/sleep.asl index d060576..e08accd 100644 --- a/src/mainboard/msi/ms7721/acpi/sleep.asl +++ b/src/mainboard/msi/ms7721/acpi/sleep.asl @@ -43,22 +43,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/pcengines/apu1/acpi/sleep.asl b/src/mainboard/pcengines/apu1/acpi/sleep.asl index 6fd128d..76b5f9e 100644 --- a/src/mainboard/pcengines/apu1/acpi/sleep.asl +++ b/src/mainboard/pcengines/apu1/acpi/sleep.asl @@ -46,22 +46,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: diff --git a/src/mainboard/pcengines/apu2/acpi/sleep.asl b/src/mainboard/pcengines/apu2/acpi/sleep.asl index dbe9bd1..39fe610 100644 --- a/src/mainboard/pcengines/apu2/acpi/sleep.asl +++ b/src/mainboard/pcengines/apu2/acpi/sleep.asl @@ -37,22 +37,6 @@ } /* End Method(\_PTS) */ /* -* \_BFS OEM Back From Sleep method -* -* Entry: -* Arg0=The value of the sleeping state S1=1, S2=2 -* -* Exit: -* -none- -*/ -Method(\_BFS, 1) { - /* DBGO("\\_BFS\n") */ - /* DBGO("From S") */ - /* DBGO(Arg0) */ - /* DBGO(" to S0\n") */ -} - -/* * \_WAK System Wake method * * Entry: -- To view, visit https://review.coreboot.org/c/coreboot/+/43443 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9ef21f231dd6051d410ac3a0fe554908409c2fa7 Gerrit-Change-Number: 43443 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

5 7

Change in coreboot[master]: amd/picasso: rework DXIO and DDI UPD handling
by Felix Held (Code Review) 15 Jul '20

15 Jul '20

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43434 ) Change subject: amd/picasso: rework DXIO and DDI UPD handling ...................................................................... amd/picasso: rework DXIO and DDI UPD handling Turning the DXIO and DDI descriptor fields in the FSP_S_CONFIG struct into arrays allows to properly iterate over the fields. BUG=b:158695393 TEST=Mandolin still boots. Change-Id: I85debe4d52399e933768b89b665ff10c9f7779f8 Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/soc/amd/picasso/fsp_params.c M src/vendorcode/amd/fsp/picasso/FspsUpd.h 2 files changed, 7 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/43434/1 diff --git a/src/soc/amd/picasso/fsp_params.c b/src/soc/amd/picasso/fsp_params.c index 10bca00..80d43fb 100644 --- a/src/soc/amd/picasso/fsp_params.c +++ b/src/soc/amd/picasso/fsp_params.c @@ -59,13 +59,9 @@ const fsp_pcie_descriptor *descs, size_t num) { size_t i; - fsp_pcie_descriptor *fsp_pcie; - - /* FIXME: this violates C rules. */ - fsp_pcie = (fsp_pcie_descriptor *)(scfg->dxio_descriptor0); for (i = 0; i < num; i++) { - fsp_pcie[i] = descs[i]; + memcpy(scfg->dxio_descriptor[i], &descs[i], sizeof(scfg->dxio_descriptor[0])); } } @@ -73,13 +69,9 @@ const fsp_ddi_descriptor *descs, size_t num) { size_t i; - fsp_ddi_descriptor *fsp_ddi; - - /* FIXME: this violates C rules. */ - fsp_ddi = (fsp_ddi_descriptor *)&(scfg->ddi_descriptor0); for (i = 0; i < num; i++) { - fsp_ddi[i] = descs[i]; + memcpy(&scfg->ddi_descriptor[i], &descs[i], sizeof(scfg->ddi_descriptor[0])); } } static void fsp_fill_pcie_ddi_descriptors(FSP_S_CONFIG *scfg) diff --git a/src/vendorcode/amd/fsp/picasso/FspsUpd.h b/src/vendorcode/amd/fsp/picasso/FspsUpd.h index 5a40831..11e77bd 100644 --- a/src/vendorcode/amd/fsp/picasso/FspsUpd.h +++ b/src/vendorcode/amd/fsp/picasso/FspsUpd.h @@ -9,19 +9,14 @@ #include <FspUpd.h> +#define FSPS_UPD_DXIO_DESCRIPTOR_COUNT 6 +#define FSPS_UPD_DDI_DESCRIPTOR_COUNT 4 + typedef struct __packed { /** Offset 0x0020**/ uint32_t emmc0_mode; /** Offset 0x0024**/ uint8_t unused0[12]; - /** Offset 0x0030**/ uint8_t dxio_descriptor0[16]; - /** Offset 0x0040**/ uint8_t dxio_descriptor1[16]; - /** Offset 0x0050**/ uint8_t dxio_descriptor2[16]; - /** Offset 0x0060**/ uint8_t dxio_descriptor3[16]; - /** Offset 0x0070**/ uint8_t dxio_descriptor4[16]; - /** Offset 0x0080**/ uint8_t dxio_descriptor5[16]; - /** Offset 0x0090**/ uint32_t ddi_descriptor0; - /** Offset 0x0094**/ uint32_t ddi_descriptor1; - /** Offset 0x0098**/ uint32_t ddi_descriptor2; - /** Offset 0x009C**/ uint32_t ddi_descriptor3; + /** Offset 0x0030**/ uint8_t dxio_descriptor[FSPS_UPD_DXIO_DESCRIPTOR_COUNT][16]; + /** Offset 0x0090**/ uint32_t ddi_descriptor[FSPS_UPD_DDI_DESCRIPTOR_COUNT]; /** Offset 0x00A0**/ uint32_t unused1; /** Offset 0x00A4**/ uint32_t unused2; /** Offset 0x00A8**/ uint32_t unused3; -- To view, visit https://review.coreboot.org/c/coreboot/+/43434 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85debe4d52399e933768b89b665ff10c9f7779f8 Gerrit-Change-Number: 43434 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

4 5

Change in coreboot[master]: vc/amd/fsp/picasso: replace #pragma pack(1) with __packed attribute
by Felix Held (Code Review) 15 Jul '20

15 Jul '20

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43433 ) Change subject: vc/amd/fsp/picasso: replace #pragma pack(1) with __packed attribute ...................................................................... vc/amd/fsp/picasso: replace #pragma pack(1) with __packed attribute Forgetting to add the #pragma pack() at the end of the header file can lead to hard to debug breakage, so get rid of the #pragma pack usage and add a __packed to the structs that need to be packed which has less possibly unwanted side effects. TEST=Timeless build results in identical binary. Change-Id: Icc53168f4fbc3a63a859f686b18e7023d225f8d2 Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/vendorcode/amd/fsp/picasso/FspmUpd.h M src/vendorcode/amd/fsp/picasso/FspsUpd.h 2 files changed, 4 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/43433/1 diff --git a/src/vendorcode/amd/fsp/picasso/FspmUpd.h b/src/vendorcode/amd/fsp/picasso/FspmUpd.h index 276b2fc..3be69c3 100644 --- a/src/vendorcode/amd/fsp/picasso/FspmUpd.h +++ b/src/vendorcode/amd/fsp/picasso/FspmUpd.h @@ -9,12 +9,9 @@ #include <FspUpd.h> -#pragma pack(1) - - /** Fsp M Configuration **/ -typedef struct { +typedef struct __packed { /** Offset 0x0040**/ uint32_t pci_express_base_addr; /** Offset 0x0044**/ uint32_t serial_port_base; /** Offset 0x0048**/ uint32_t serial_port_use_mmio; @@ -71,12 +68,10 @@ /** Fsp M UPD Configuration **/ -typedef struct { +typedef struct __packed { /** Offset 0x0000**/ FSP_UPD_HEADER FspUpdHeader; /** Offset 0x0020**/ FSPM_ARCH_UPD FspmArchUpd; /** Offset 0x0040**/ FSP_M_CONFIG FspmConfig; } FSPM_UPD; -#pragma pack() - #endif diff --git a/src/vendorcode/amd/fsp/picasso/FspsUpd.h b/src/vendorcode/amd/fsp/picasso/FspsUpd.h index 2dcc617..5a40831 100644 --- a/src/vendorcode/amd/fsp/picasso/FspsUpd.h +++ b/src/vendorcode/amd/fsp/picasso/FspsUpd.h @@ -9,10 +9,7 @@ #include <FspUpd.h> -#pragma pack(1) - - -typedef struct { +typedef struct __packed { /** Offset 0x0020**/ uint32_t emmc0_mode; /** Offset 0x0024**/ uint8_t unused0[12]; /** Offset 0x0030**/ uint8_t dxio_descriptor0[16]; @@ -51,11 +48,9 @@ /** Fsp S UPD Configuration **/ -typedef struct { +typedef struct __packed { /** Offset 0x0000**/ FSP_UPD_HEADER FspUpdHeader; /** Offset 0x0020**/ FSP_S_CONFIG FspsConfig; } FSPS_UPD; -#pragma pack() - #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/43433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc53168f4fbc3a63a859f686b18e7023d225f8d2 Gerrit-Change-Number: 43433 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

4 9

Change in coreboot[master]: mb/lippert/frontrunner-af: Drop commented-out Kconfig symbol
by Angel Pons (Code Review) 15 Jul '20

15 Jul '20

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43287 ) Change subject: mb/lippert/frontrunner-af: Drop commented-out Kconfig symbol ...................................................................... mb/lippert/frontrunner-af: Drop commented-out Kconfig symbol Drop it before it grows moss. Change-Id: I0b4f5487cca3c864ba531cc6c78a20c2682fc43d Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/lippert/frontrunner-af/Kconfig 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/43287/1 diff --git a/src/mainboard/lippert/frontrunner-af/Kconfig b/src/mainboard/lippert/frontrunner-af/Kconfig index 6096a91..55157ed 100644 --- a/src/mainboard/lippert/frontrunner-af/Kconfig +++ b/src/mainboard/lippert/frontrunner-af/Kconfig @@ -59,11 +59,6 @@ bool default n -#config VGA_BIOS_FILE -# string "VGA BIOS path and filename" -# depends on VGA_BIOS -# default "rom/video/OntarioGenericVbios.bin" - config VGA_BIOS_ID string default "1002,9802" -- To view, visit https://review.coreboot.org/c/coreboot/+/43287 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b4f5487cca3c864ba531cc6c78a20c2682fc43d Gerrit-Change-Number: 43287 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

3 2

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2020