coreboot-gerrit July 2020

coreboot-gerrit@coreboot.org

1 participants
3166 discussions

Change in coreboot[master]: drivers/intel/mipi_camera: Add guard to protect camera resources
by Paul Menzel (Code Review) 16 Jul '20

16 Jul '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43003 ) Change subject: drivers/intel/mipi_camera: Add guard to protect camera resources ...................................................................... Patch Set 9: (1 comment) https://review.coreboot.org/c/coreboot/+/43003/9//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/43003/9//COMMIT_MSG@15 PS9, Line 15: For a over 20 line diffstat, please shortly describe the implementation. -- To view, visit https://review.coreboot.org/c/coreboot/+/43003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1468459d5bbb2fb07bef4e0590c96dd4dbab0d9c Gerrit-Change-Number: 43003 Gerrit-PatchSet: 9 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Thu, 16 Jul 2020 07:15:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/kukui: Add new configs 'willow'
by Sheng-Liang Pan (Code Review) 16 Jul '20

16 Jul '20

Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43318 ) Change subject: mb/google/kukui: Add new configs 'willow' ...................................................................... mb/google/kukui: Add new configs 'willow' New boards introduced to Kukui family. BUG=b:159194582 TEST=None Signed-off-by: Pan Sheng-Liang <sheng-liang.pan(a)quanta.corp-partner.google.com> Change-Id: Icc6bcbd006008a05303693e481a54636f0645887 --- M src/mainboard/google/kukui/Kconfig M src/mainboard/google/kukui/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/43318/1 diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 4c8ebbf..de78e91 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -29,7 +29,7 @@ select MAINBOARD_FORCE_NATIVE_VGA_INIT select HAVE_LINEAR_FRAMEBUFFER select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_JACUZZI - select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA + select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_DAMU || BOARD_GOOGLE_KAPPA || BOARD_GOOGLE_WILLOW select MT8183_DRAM_EMCP if BOARD_GOOGLE_KRANE config MAINBOARD_DIR @@ -47,6 +47,7 @@ default "Juniper" if BOARD_GOOGLE_JUNIPER default "Kappa" if BOARD_GOOGLE_KAPPA default "Damu" if BOARD_GOOGLE_DAMU + default "Willow" if BOARD_GOOGLE_WILLOW config DRIVER_TPM_SPI_BUS hex diff --git a/src/mainboard/google/kukui/Kconfig.name b/src/mainboard/google/kukui/Kconfig.name index 4b12034..dcf8c70 100644 --- a/src/mainboard/google/kukui/Kconfig.name +++ b/src/mainboard/google/kukui/Kconfig.name @@ -35,3 +35,7 @@ config BOARD_GOOGLE_DAMU bool "-> Damu" select BOARD_GOOGLE_KUKUI_COMMON + +config BOARD_GOOGLE_WILLOW + bool "-> Willow" + select BOARD_GOOGLE_KUKUI_COMMON -- To view, visit https://review.coreboot.org/c/coreboot/+/43318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc6bcbd006008a05303693e481a54636f0645887 Gerrit-Change-Number: 43318 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

4 11

Change in coreboot[master]: drivers/intel/mipi_camera: Add guard to protect camera resources
by Sugnan Prabhu S (Code Review) 15 Jul '20

15 Jul '20

Hello Varshit B Pandya, build bot (Jenkins), Matt Delco, Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/43003 to look at the new patch set (#9). Change subject: drivers/intel/mipi_camera: Add guard to protect camera resources ...................................................................... drivers/intel/mipi_camera: Add guard to protect camera resources This change updates the mipi_camera driver to handle shared power resource between multiple cameras. This is achieved by adding a guard variable and methods to manipulate the guard variable before calling the actual method which enables or disables the resource. This protects the shared resources from being enabled or disabled multiple times while the resources are being used by multiple cameras. Change-Id: I1468459d5bbb2fb07bef4e0590c96dd4dbab0d9c Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> --- M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/mipi_camera/chip.h 2 files changed, 348 insertions(+), 40 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/43003/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/43003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1468459d5bbb2fb07bef4e0590c96dd4dbab0d9c Gerrit-Change-Number: 43003 Gerrit-PatchSet: 9 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: google/trogdor: Remove GPIO_AP_SUSPEND_L
by Julius Werner (Code Review) 15 Jul '20

15 Jul '20

Hello Doug Anderson, Philip Chen, Wai-Hong Tam, mturney mturney, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/43471 to review the following change. Change subject: google/trogdor: Remove GPIO_AP_SUSPEND_L ...................................................................... google/trogdor: Remove GPIO_AP_SUSPEND_L This pin has been removed from recent revisions (or at least moved to a pin that's not controlled like a normal GPIO). It has also never been used on older ones (I think?). The same GPIO is now used as a SKU ID pin, so make sure we're not incorrectly configuring it as an output (although sku_id() overrides that later anyway, but it's still incorrect). BUG=b:160754995 Signed-off-by: Julius Werner <jwerner(a)chromium.org> Change-Id: I6e0d56e230d0bef172d7b78cc48263e9b6f059de --- M src/mainboard/google/trogdor/board.h M src/mainboard/google/trogdor/chromeos.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/43471/1 diff --git a/src/mainboard/google/trogdor/board.h b/src/mainboard/google/trogdor/board.h index 63d03db..cab4403 100644 --- a/src/mainboard/google/trogdor/board.h +++ b/src/mainboard/google/trogdor/board.h @@ -9,7 +9,6 @@ #define GPIO_EC_IN_RW GPIO(118) #define GPIO_AP_EC_INT GPIO(94) -#define GPIO_AP_SUSPEND GPIO(20) #define GPIO_WP_STATE GPIO(42) #define GPIO_H1_AP_INT (CONFIG(TROGDOR_REV0) ? GPIO(21) : GPIO(42)) #define GPIO_SD_CD_L GPIO(69) diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c index 9360928..9c45dfe 100644 --- a/src/mainboard/google/trogdor/chromeos.c +++ b/src/mainboard/google/trogdor/chromeos.c @@ -14,7 +14,6 @@ { gpio_input_pullup(GPIO_EC_IN_RW); gpio_input_pullup(GPIO_AP_EC_INT); - gpio_output(GPIO_AP_SUSPEND, 1); gpio_input(GPIO_WP_STATE); gpio_input_pullup(GPIO_SD_CD_L); gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP); -- To view, visit https://review.coreboot.org/c/coreboot/+/43471 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e0d56e230d0bef172d7b78cc48263e9b6f059de Gerrit-Change-Number: 43471 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Doug Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Philip Chen <philipchen(a)chromium.org> Gerrit-Reviewer: Wai-Hong Tam <waihong(a)chromium.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-MessageType: newchange

5 5

Change in coreboot[master]: mb/google/zork: Remove USB from trembyle overridetree
by Rob Barnes (Code Review) 15 Jul '20

15 Jul '20

Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43437 ) Change subject: mb/google/zork: Remove USB from trembyle overridetree ...................................................................... mb/google/zork: Remove USB from trembyle overridetree This information is redundant since it's already specified in baseboard/devicetree_trembyle.cb BUG=b:157580724 TEST=Boot, BT functional Change-Id: I3c3c1c2410166b99599d7343fae3ee756f4da321 Signed-off-by: Rob Barnes <robbarnes(a)google.com> --- M src/mainboard/google/zork/variants/trembyle/overridetree.cb 1 file changed, 1 insertion(+), 71 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/43437/1 diff --git a/src/mainboard/google/zork/variants/trembyle/overridetree.cb b/src/mainboard/google/zork/variants/trembyle/overridetree.cb index 22aced2..081471b 100644 --- a/src/mainboard/google/zork/variants/trembyle/overridetree.cb +++ b/src/mainboard/google/zork/variants/trembyle/overridetree.cb @@ -43,77 +43,7 @@ device pci 1.6 off end # GPP Bridge 5 device pci 1.7 on end # GPP Bridge 6 - NVME device pci 8.1 on # Internal GPP Bridge 0 to Bus A - device pci 0.3 on - chip drivers/usb/acpi - register "desc" = ""Root Hub"" - register "type" = "UPC_TYPE_HUB" - device usb 0.0 on - chip drivers/usb/acpi - register "desc" = ""Left Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(1, 1)" - device usb 2.0 on end - end - chip drivers/usb/acpi - register "desc" = ""Left Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(1, 2)" - device usb 2.1 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(2, 1)" - device usb 2.2 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(2, 2)" - device usb 2.3 on end - end - chip drivers/usb/acpi - register "desc" = ""User-Facing Camera"" - register "type" = "UPC_TYPE_INTERNAL" - device usb 2.4 on end - end - chip drivers/usb/acpi - register "desc" = ""Bluetooth"" - register "type" = "UPC_TYPE_INTERNAL" - device usb 2.5 on end - end - chip drivers/usb/acpi - register "desc" = ""Left Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(1, 1)" - device usb 3.0 on end - end - chip drivers/usb/acpi - register "desc" = ""Left Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(1, 2)" - device usb 3.1 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-A Port"" - register "type" = "UPC_TYPE_USB3_A" - register "group" = "ACPI_PLD_GROUP(2, 1)" - device usb 3.2 on end - end - chip drivers/usb/acpi - register "desc" = ""Right Type-C Port"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "group" = "ACPI_PLD_GROUP(2, 2)" - device usb 3.3 on end - end - chip drivers/usb/acpi - register "desc" = ""AR Camera"" - register "type" = "UPC_TYPE_INTERNAL" - device usb 3.4 on end - end - end - end - end # USB 3.1 + device pci 0.3 on end # USB 3.1 device pci 0.4 on end # USB 3.1 end device pci 14.6 off end # Non-Functional SDHCI -- To view, visit https://review.coreboot.org/c/coreboot/+/43437 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c3c1c2410166b99599d7343fae3ee756f4da321 Gerrit-Change-Number: 43437 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: newchange

4 14

Change in coreboot[master]: soc/intel/common/basecode: Implement CSE update flow
by Furquan Shaikh (Code Review) 15 Jul '20

15 Jul '20

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35403 ) Change subject: soc/intel/common/basecode: Implement CSE update flow ...................................................................... Patch Set 91: (1 comment) https://review.coreboot.org/c/coreboot/+/35403/91/src/soc/intel/common/bloc… File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/35403/91/src/soc/intel/common/bloc… PS91, Line 443: cse_setup_rw_region(cse_bp_info, &cse_rw_region, : region_device_offset(&cse_region_rdev)); : : printk(BIOS_DEBUG, "cse_lite: CSE RW partition: offset = 0x%x, size = 0x%x\n", : (uint32_t)cse_rw_region.offset, (uint32_t)cse_rw_region.size); : : if (boot_device_rw_subregion(&cse_rw_region, target_rdev) < 0) : return false; > I notice some issue If I use rdev_chain() API. […] Sounds good. Can you please email me the issue you are seeing? Or raise a bug with logs? -- To view, visit https://review.coreboot.org/c/coreboot/+/35403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12f6bba3324069d65edabaccd234006b0840e700 Gerrit-Change-Number: 35403 Gerrit-PatchSet: 91 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Thu, 16 Jul 2020 00:01:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cbgfx: Add blend functions to calculate transparency
by Shelley Chen (Code Review) 15 Jul '20

15 Jul '20

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43358 ) Change subject: cbgfx: Add blend functions to calculate transparency ...................................................................... cbgfx: Add blend functions to calculate transparency BUG=b:144969091,b:160839199 BRANCH=puff TEST=dut-control power_state:rec press ctrl-d Ensure background is dimmed when dialog pops up Change-Id: I95468f27836d34ab80392727d726a69c09dc168e Signed-off-by: Shelley Chen <shchen(a)google.com> --- M 3rdparty/blobs M payloads/libpayload/drivers/video/graphics.c M payloads/libpayload/include/cbgfx.h 3 files changed, 84 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/43358/1 diff --git a/3rdparty/blobs b/3rdparty/blobs index bbe5d99..7ad2d22 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit bbe5d99780d2d085e92d9bae2c0f7b6787419d72 +Subproject commit 7ad2d22452225a14c19b17570cb77920d8fc81a5 diff --git a/payloads/libpayload/drivers/video/graphics.c b/payloads/libpayload/drivers/video/graphics.c index bb8467b..3ed7390 100644 --- a/payloads/libpayload/drivers/video/graphics.c +++ b/payloads/libpayload/drivers/video/graphics.c @@ -61,6 +61,36 @@ .y = 0, }; +static struct blend_value bvalue = { + .alpha = 0, + .rgb.red = 0, + .rgb.green = 0, + .rgb.blue = 0, +}; + +int set_blend(const struct rgb_color *rgb, uint8_t alpha) +{ + if (rgb == NULL) + return CBGFX_ERROR_INVALID_PARAMETER; + + bvalue.rgb.red = rgb->red; + bvalue.rgb.green = rgb->green; + bvalue.rgb.blue = rgb->blue; + bvalue.alpha = alpha; + + return CBGFX_SUCCESS; +} + +int clear_blend(void) +{ + bvalue.rgb.red = 0; + bvalue.rgb.green = 0; + bvalue.rgb.blue = 0; + bvalue.alpha = 0; + + return CBGFX_SUCCESS; +} + static void add_vectors(struct vector *out, const struct vector *v1, const struct vector *v2) { @@ -139,11 +169,29 @@ uint8_t invert) { uint32_t color = 0; - color |= (rgb->red >> (8 - fbinfo->red_mask_size)) + struct rgb_color new_rgb; + + new_rgb.red = rgb->red; + new_rgb.green = rgb->green; + new_rgb.blue = rgb->blue; + if (bvalue.alpha > 0 && + (new_rgb.red != bvalue.rgb.red || + new_rgb.green != bvalue.rgb.green || + new_rgb.blue != bvalue.rgb.blue)) { + + new_rgb.red = (new_rgb.red * (UINT8_MAX - bvalue.alpha) + + bvalue.rgb.red * bvalue.alpha) >> 8; + new_rgb.green = (new_rgb.green * (UINT8_MAX - bvalue.alpha) + + bvalue.rgb.green * bvalue.alpha) >> 8; + new_rgb.blue = (new_rgb.blue * (UINT8_MAX - bvalue.alpha) + + bvalue.rgb.blue * bvalue.alpha) >> 8; + } + + color |= (new_rgb.red >> (8 - fbinfo->red_mask_size)) << fbinfo->red_mask_pos; - color |= (rgb->green >> (8 - fbinfo->green_mask_size)) + color |= (new_rgb.green >> (8 - fbinfo->green_mask_size)) << fbinfo->green_mask_pos; - color |= (rgb->blue >> (8 - fbinfo->blue_mask_size)) + color |= (new_rgb.blue >> (8 - fbinfo->blue_mask_size)) << fbinfo->blue_mask_pos; if (invert) color ^= 0xffffffff; diff --git a/payloads/libpayload/include/cbgfx.h b/payloads/libpayload/include/cbgfx.h index 869f272..313c308 100644 --- a/payloads/libpayload/include/cbgfx.h +++ b/payloads/libpayload/include/cbgfx.h @@ -89,6 +89,11 @@ uint8_t blue; }; +struct blend_value { + uint8_t alpha; + struct rgb_color rgb; +}; + /* * Resolution of scale parameters used to describe height, width, coordinate, * etc. relative to the canvas. For example, if it's 100, scales range from 0 to @@ -210,3 +215,30 @@ * in the original size are returned. */ int get_bitmap_dimension(const void *bitmap, size_t sz, struct scale *dim_rel); + +/** + * Set alpha values to setup transparency calculations + * + * @param[in] rgb Color for transparency + * @param[in] alpha Opacity of color, from 0-255 where + * 0 = completely transparent (no blending) + * 255 = completely opaque + * + * @return CBGFX_* error codes + */ +int set_blend(const struct rgb_color *rgb, uint8_t alpha); + +/** + * Clear alpha and rgb values, thus disabling dimming. + * + * @return CBGFX_* error codes + */ +int clear_blend(void); + +/** + * Constant for 60% opacity + * For reference: + * 255 = 100% opacity + * 0 = 0% opacity + */ +#define OPACITY_60 153 -- To view, visit https://review.coreboot.org/c/coreboot/+/43358 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I95468f27836d34ab80392727d726a69c09dc168e Gerrit-Change-Number: 43358 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: newchange

6 22

Change in coreboot[master]: util/mb/google: add template files for dalboz and trembyle
by Paul Fagerburg (Code Review) 15 Jul '20

15 Jul '20

Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43419 ) Change subject: util/mb/google: add template files for dalboz and trembyle ...................................................................... util/mb/google: add template files for dalboz and trembyle Now that Zork is using upstream coreboot, we need the template files in the main branch. BUG=b:157570490 TEST=n/a Signed-off-by: Paul Fagerburg <pfagerburg(a)chromium.org> Change-Id: I6cab4ab0b414473e0a759dce81df9872a40d3f26 --- A util/mainboard/google/dalboz/template/Makefile.inc A util/mainboard/google/dalboz/template/include/variant/acpi/audio.asl A util/mainboard/google/dalboz/template/include/variant/acpi/mainboard.asl A util/mainboard/google/dalboz/template/include/variant/acpi/sleep.asl A util/mainboard/google/dalboz/template/include/variant/acpi/thermal.asl A util/mainboard/google/dalboz/template/include/variant/ec.h A util/mainboard/google/dalboz/template/include/variant/gpio.h A util/mainboard/google/dalboz/template/include/variant/thermal.h A util/mainboard/google/dalboz/template/overridetree.cb A util/mainboard/google/trembyle/template/Makefile.inc A util/mainboard/google/trembyle/template/include/variant/acpi/audio.asl A util/mainboard/google/trembyle/template/include/variant/acpi/mainboard.asl A util/mainboard/google/trembyle/template/include/variant/acpi/sleep.asl A util/mainboard/google/trembyle/template/include/variant/acpi/thermal.asl A util/mainboard/google/trembyle/template/include/variant/ec.h A util/mainboard/google/trembyle/template/include/variant/gpio.h A util/mainboard/google/trembyle/template/include/variant/thermal.h A util/mainboard/google/trembyle/template/overridetree.cb 18 files changed, 334 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/43419/1 diff --git a/util/mainboard/google/dalboz/template/Makefile.inc b/util/mainboard/google/dalboz/template/Makefile.inc new file mode 100644 index 0000000..2490ea5 --- /dev/null +++ b/util/mainboard/google/dalboz/template/Makefile.inc @@ -0,0 +1,14 @@ +# +# This file is part of the coreboot project. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# + +subdirs-y += ../baseboard/spd diff --git a/util/mainboard/google/dalboz/template/include/variant/acpi/audio.asl b/util/mainboard/google/dalboz/template/include/variant/acpi/audio.asl new file mode 100644 index 0000000..71a4920 --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/acpi/audio.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/audio.asl> diff --git a/util/mainboard/google/dalboz/template/include/variant/acpi/mainboard.asl b/util/mainboard/google/dalboz/template/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..63eb280 --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/acpi/mainboard.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/mainboard.asl> diff --git a/util/mainboard/google/dalboz/template/include/variant/acpi/sleep.asl b/util/mainboard/google/dalboz/template/include/variant/acpi/sleep.asl new file mode 100644 index 0000000..a401b3a --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/acpi/sleep.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/sleep.asl> diff --git a/util/mainboard/google/dalboz/template/include/variant/acpi/thermal.asl b/util/mainboard/google/dalboz/template/include/variant/acpi/thermal.asl new file mode 100644 index 0000000..a7e511c --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/acpi/thermal.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/thermal.asl> diff --git a/util/mainboard/google/dalboz/template/include/variant/ec.h b/util/mainboard/google/dalboz/template/include/variant/ec.h new file mode 100644 index 0000000..fbd60dc --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/ec.h @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/ec.h> diff --git a/util/mainboard/google/dalboz/template/include/variant/gpio.h b/util/mainboard/google/dalboz/template/include/variant/gpio.h new file mode 100644 index 0000000..726d255 --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/gpio.h @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/gpio.h> diff --git a/util/mainboard/google/dalboz/template/include/variant/thermal.h b/util/mainboard/google/dalboz/template/include/variant/thermal.h new file mode 100644 index 0000000..addce73 --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/thermal.h @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/thermal.h> diff --git a/util/mainboard/google/dalboz/template/overridetree.cb b/util/mainboard/google/dalboz/template/overridetree.cb new file mode 100644 index 0000000..fb01a39 --- /dev/null +++ b/util/mainboard/google/dalboz/template/overridetree.cb @@ -0,0 +1,45 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +chip soc/amd/picasso + + # Start : OPN Performance Configuration + # See devhub #56670 Chapter 5 for documentation + # For the below fields, 0 indicates use SOC default + + # System config index + register "system_config" = "1" + + # Set STAPM confiuration. All of these fields must be set >0 to take affect + register "slow_ppt_limit" = "6000" #mw + register "fast_ppt_limit" = "9000" #mw + register "slow_ppt_time_constant" = "5" #second + register "stapm_time_constant" = "2500" #second + register "sustained_power_limit" = "4800" #mw + + # End : OPN Performance Configuration + + # I2C2 for touchscreen and trackpad + + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + }" + + # I2C3 for H1 + + register "i2c[3]" = "{ + .speed = I2C_SPEED_FAST, + .early_init = true, + }" + + # See AMD 55570-B1 Table 13: PCI Device ID Assignments. + device domain 0 on + subsystemid 0x1022 0x1510 inherit + device pci 8.1 on # Internal GPP Bridge 0 to Bus A + device pci 0.3 on end # USB 3.1 + end + end # domain + + device mmio 0xfedc4000 on # APU_I2C2_BASE + end # device + +end # chip soc/amd/picasso diff --git a/util/mainboard/google/trembyle/template/Makefile.inc b/util/mainboard/google/trembyle/template/Makefile.inc new file mode 100644 index 0000000..2490ea5 --- /dev/null +++ b/util/mainboard/google/trembyle/template/Makefile.inc @@ -0,0 +1,14 @@ +# +# This file is part of the coreboot project. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# + +subdirs-y += ../baseboard/spd diff --git a/util/mainboard/google/trembyle/template/include/variant/acpi/audio.asl b/util/mainboard/google/trembyle/template/include/variant/acpi/audio.asl new file mode 100644 index 0000000..71a4920 --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/acpi/audio.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/audio.asl> diff --git a/util/mainboard/google/trembyle/template/include/variant/acpi/mainboard.asl b/util/mainboard/google/trembyle/template/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..63eb280 --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/acpi/mainboard.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/mainboard.asl> diff --git a/util/mainboard/google/trembyle/template/include/variant/acpi/sleep.asl b/util/mainboard/google/trembyle/template/include/variant/acpi/sleep.asl new file mode 100644 index 0000000..a401b3a --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/acpi/sleep.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/sleep.asl> diff --git a/util/mainboard/google/trembyle/template/include/variant/acpi/thermal.asl b/util/mainboard/google/trembyle/template/include/variant/acpi/thermal.asl new file mode 100644 index 0000000..a7e511c --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/acpi/thermal.asl @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/acpi/thermal.asl> diff --git a/util/mainboard/google/trembyle/template/include/variant/ec.h b/util/mainboard/google/trembyle/template/include/variant/ec.h new file mode 100644 index 0000000..fbd60dc --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/ec.h @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/ec.h> diff --git a/util/mainboard/google/trembyle/template/include/variant/gpio.h b/util/mainboard/google/trembyle/template/include/variant/gpio.h new file mode 100644 index 0000000..726d255 --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/gpio.h @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/gpio.h> diff --git a/util/mainboard/google/trembyle/template/include/variant/thermal.h b/util/mainboard/google/trembyle/template/include/variant/thermal.h new file mode 100644 index 0000000..addce73 --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/thermal.h @@ -0,0 +1,14 @@ +/* + * This file is part of the coreboot project. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; version 2 of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <baseboard/thermal.h> diff --git a/util/mainboard/google/trembyle/template/overridetree.cb b/util/mainboard/google/trembyle/template/overridetree.cb new file mode 100644 index 0000000..67b3ada --- /dev/null +++ b/util/mainboard/google/trembyle/template/overridetree.cb @@ -0,0 +1,65 @@ +# +# This file is part of the coreboot project. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +chip soc/amd/picasso + + # Start : OPN Performance Configuration + # See devhub #55593 Chapter 3.2 for documentation + # For the below fields, 0 indicates use SOC default + + # System config index + register "system_config" = "2" + + # Set STAPM confiuration. All of these fields must be set >0 to take affect + register "slow_ppt_limit" = "25000" #mw + register "fast_ppt_limit" = "30000" #mw + register "slow_ppt_time_constant" = "5" #second + register "stapm_time_constant" = "200" #second + register "sustained_power_limit" = "15000" #mw + + register "telemetry_vddcr_vdd_slope" = "71222" #mA + register "telemetry_vddcr_vdd_offset" = "0" + register "telemetry_vddcr_soc_slope" = "28977" #mA + register "telemetry_vddcr_soc_offset" = "0" + + # End : OPN Performance Configuration + + # Enable I2C2 for trackpad, touchscreen, pen at 400kHz + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 21, /* 0 to 2.31 (3.3 * .7) */ + .fall_time_ns = 76, /* 2.31 to 0 */ + }" + + # Enable I2C3 for H1 400kHz + register "i2c[3]" = "{ + .speed = I2C_SPEED_FAST, + .rise_time_ns = 125, /* 0 to 1.26v (1.8 * .7) */ + .fall_time_ns = 37, /* 1.26v to 0 */ + .early_init = true, + }" + + # See AMD 55570-B1 Table 13: PCI Device ID Assignments. + device domain 0 on + subsystemid 0x1022 0x1510 inherit + device pci 1.6 off end # GPP Bridge 5 + device pci 1.7 on end # GPP Bridge 6 - NVME + device pci 8.1 on # Internal GPP Bridge 0 to Bus A + device pci 0.3 on end # USB 3.1 + device pci 0.4 on end # USB 3.1 + end + device pci 14.6 off end # Non-Functional SDHCI + end # domain + + device mmio 0xfedc4000 on end + +end # chip soc/amd/picasso -- To view, visit https://review.coreboot.org/c/coreboot/+/43419 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6cab4ab0b414473e0a759dce81df9872a40d3f26 Gerrit-Change-Number: 43419 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-MessageType: newchange

3 12

Change in coreboot[master]: Makefile.inc: Remove variable `spc` for future Make
by Paul Menzel (Code Review) 15 Jul '20

15 Jul '20

Paul Menzel has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/27308 ) Change subject: Makefile.inc: Remove variable `spc` for future Make ...................................................................... Abandoned Fixed in another commit. -- To view, visit https://review.coreboot.org/c/coreboot/+/27308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00d25bc4bf194d1200e1f7e063b0256a44a67b6f Gerrit-Change-Number: 27308 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/intel/common/basecode: Implement CSE update flow
by Sridhar Siricilla (Code Review) 15 Jul '20

15 Jul '20

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35403 ) Change subject: soc/intel/common/basecode: Implement CSE update flow ...................................................................... Patch Set 91: (2 comments) https://review.coreboot.org/c/coreboot/+/35403/91//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/35403/91//COMMIT_MSG@17 PS91, Line 17: Send global reset command to reset the system. > Have you checked the total boot time in this case? No. It's better we capture update time for all products(Puff/JSL/TGL) at one place, so I have raised crosbug b:161363773 for the same. https://review.coreboot.org/c/coreboot/+/35403/91/src/soc/intel/common/bloc… File src/soc/intel/common/block/cse/cse_lite.c: https://review.coreboot.org/c/coreboot/+/35403/91/src/soc/intel/common/bloc… PS91, Line 443: cse_setup_rw_region(cse_bp_info, &cse_rw_region, : region_device_offset(&cse_region_rdev)); : : printk(BIOS_DEBUG, "cse_lite: CSE RW partition: offset = 0x%x, size = 0x%x\n", : (uint32_t)cse_rw_region.offset, (uint32_t)cse_rw_region.size); : : if (boot_device_rw_subregion(&cse_rw_region, target_rdev) < 0) : return false; > This is not really required. You can simply do: […] I notice some issue If I use rdev_chain() API. I will push follow-up patch with the suggested change after my investigation. For now, let's current patch be merged as it is. -- To view, visit https://review.coreboot.org/c/coreboot/+/35403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I12f6bba3324069d65edabaccd234006b0840e700 Gerrit-Change-Number: 35403 Gerrit-PatchSet: 91 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com> Gerrit-Reviewer: Andrey Petrov <anpetrov(a)fb.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Wed, 15 Jul 2020 19:44:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2020