Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42098 )
Change subject: mb/google/wdee: Disable WLAN for Wdee
......................................................................
Patch Set 3:
> Patch Set 3:
>
> As I know, Waddledoo is just the one to use integrated WLAN and Waddledee is for discrete PCIe M.2 WLAN/BT module? Add Evan Green to confirm
No, both Waddledoo and Waddledee use CNVi now. But both of them can support discrete WLAN/BT. Doo can support Intel's Discrete WiFi, whereas Dee can support Realtek's Discrete WiFi. So I wouldn't want to disable the concerned Root Port in the devicetree.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42098
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ac1c9a83fbbf03066c09774324313f62d58bc38
Gerrit-Change-Number: 42098
Gerrit-PatchSet: 3
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Uday M Bhat
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Marco Chen <marcochen(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Tue, 14 Jul 2020 17:06:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Sugnan Prabhu S has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43324 )
Change subject: util/lint: checkpatch.pl update max_line_length
......................................................................
util/lint: checkpatch.pl update max_line_length
This change updates the max_line_length in checkpatch.pl as per the
updated coding style for breaking the long lines.
Change-Id: Id6be7756ccfe63016bd6a495cdbbb187effdedfb
Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
---
M util/lint/checkpatch.pl
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/43324/1
diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl
index 1affdb7..c6cbe69 100755
--- a/util/lint/checkpatch.pl
+++ b/util/lint/checkpatch.pl
@@ -51,7 +51,7 @@
my @exclude = (); #coreboot
my $help = 0;
my $configuration_file = ".checkpatch.conf";
-my $max_line_length = 80;
+my $max_line_length = 96;
my $ignore_perl_version = 0;
my $minimum_perl_version = 5.10.0;
my $min_conf_desc_length = 4;
--
To view, visit https://review.coreboot.org/c/coreboot/+/43324
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6be7756ccfe63016bd6a495cdbbb187effdedfb
Gerrit-Change-Number: 43324
Gerrit-PatchSet: 1
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-MessageType: newchange