Change in coreboot[master]: util/lint: checkpatch.pl update max_line_length

[Sugnan Prabhu S (Code Review)]

Sugnan Prabhu S has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43324 )

Change subject: util/lint: checkpatch.pl update max_line_length
......................................................................

util/lint: checkpatch.pl update max_line_length

This change updates the max_line_length in checkpatch.pl as per the
updated coding style for breaking the long lines.

Change-Id: Id6be7756ccfe63016bd6a495cdbbb187effdedfb
Signed-off-by: Sugnan Prabhu S 
---
M util/lint/checkpatch.pl
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/43324/1

diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl
index 1affdb7..c6cbe69 100755
--- a/util/lint/checkpatch.pl
+++ b/util/lint/checkpatch.pl
@@ -51,7 +51,7 @@
 my @exclude = (); #coreboot
 my $help = 0;
 my $configuration_file = ".checkpatch.conf";
-my $max_line_length = 80;
+my $max_line_length = 96;
 my $ignore_perl_version = 0;
 my $minimum_perl_version = 5.10.0;
 my $min_conf_desc_length = 4;

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43324 )

Change subject: util/lint: checkpatch.pl update max_line_length
......................................................................

Patch Set 1: Code-Review-1

This is already passed as an argument in lint-007-checkpatch, it doesn't need to be here again. The goal is to change the checkpatch.pl file itself as little as possible so that it's easier to merge updates from upstream back in.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43324 )

Change subject: util/lint: checkpatch.pl update max_line_length
......................................................................

Patch Set 1: Code-Review-1
> Patch Set 1: Code-Review-1
>
> This is already passed as an argument in lint-007-checkpatch, it doesn't need to be here again. The goal is to change the checkpatch.pl file itself as little as possible so that it's easier to merge updates from upstream back in.

It's the third patch that tries to do the same: CB:34386 and CB:38677

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43324 )

Change subject: util/lint: checkpatch.pl update max_line_length
......................................................................

Patch Set 1:
> It's the third patch that tries to do the same: CB:34386 and CB:38677

Yeah, I wonder where people keep getting this idea? I guess they're trying to run checkpatch locally and don't know that they should be running lint-007-checkpatch or something? Maybe we should introduce a 'make checkpatch' or something to make it easier?

[Sugnan Prabhu S (Code Review)]

Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43324 )

Change subject: util/lint: checkpatch.pl update max_line_length
......................................................................

Patch Set 1:
> Patch Set 1:
> > It's the third patch that tries to do the same: CB:34386 and CB:38677
>
> Yeah, I wonder where people keep getting this idea? I guess they're trying to run checkpatch locally and don't know that they should be running lint-007-checkpatch or something? Maybe we should introduce a 'make checkpatch' or something to make it easier?

Yeah I was always running checkpatch.pl locally before submitting any patch.
The idea of running checkpatch.pl came from the following documentation.
https://doc.coreboot.org/tutorial/part2.html?#step-4-submit-a-commit

[Sugnan Prabhu S (Code Review)]

Sugnan Prabhu S has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43324 )

Change subject: util/lint: checkpatch.pl update max_line_length
......................................................................

Abandoned

Duplicate of CB:34386 and CB:38677

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43324 )

Change subject: util/lint: checkpatch.pl update max_line_length
......................................................................

Patch Set 1:

CB:43450 removes the mention of manual checkpatch.pl invocation.