coreboot-gerrit July 2020

coreboot-gerrit@coreboot.org

1 participants
3166 discussions

Change in coreboot[master]: trogdor: SoC makefile BLOB support
by Ravi kumar (Code Review) 14 Jul '20

14 Jul '20

Ravi kumar has uploaded a new patch set (#84) to the change originally created by mturney mturney. ( https://review.coreboot.org/c/coreboot/+/35508 ) Change subject: trogdor: SoC makefile BLOB support ...................................................................... trogdor: SoC makefile BLOB support Change-Id: I85a20ef31ec91c6f22221d16fd4c3097c5cb97d1 Signed-off-by: Ashwin Kumar <ashk(a)codeaurora.org> --- M src/soc/qualcomm/sc7180/Makefile.inc 1 file changed, 86 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/35508/84 -- To view, visit https://review.coreboot.org/c/coreboot/+/35508 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85a20ef31ec91c6f22221d16fd4c3097c5cb97d1 Gerrit-Change-Number: 35508 Gerrit-PatchSet: 84 Gerrit-Owner: mturney mturney <mturney(a)codeaurora.org> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: ashk(a)codeaurora.org Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/wdee: Disable WLAN for Wdee
by Marco Chen (Code Review) 14 Jul '20

14 Jul '20

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42098 ) Change subject: mb/google/wdee: Disable WLAN for Wdee ...................................................................... Patch Set 3: As I know, Waddledoo is just the one to use integrated WLAN and Waddledee is for discrete PCIe M.2 WLAN/BT module? Add Evan Green to confirm -- To view, visit https://review.coreboot.org/c/coreboot/+/42098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ac1c9a83fbbf03066c09774324313f62d58bc38 Gerrit-Change-Number: 42098 Gerrit-PatchSet: 3 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Uday M Bhat Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marco Chen <marcochen(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 14 Jul 2020 14:06:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: Enable SIS touchscreen for Waddledee
by Marco Chen (Code Review) 14 Jul '20

14 Jul '20

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43304 ) Change subject: mb/google/dedede: Enable SIS touchscreen for Waddledee ...................................................................... Patch Set 4: (2 comments) https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/deded… File src/mainboard/google/dedede/variants/waddledee/overridetree.cb: https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/deded… PS4, Line 77: 100 > Karthik pulled the value here from the discussion on Waddledoo, I'm betting. […] * Regarding this 100ms, please refer to page 13 of [1]. * But as the discussion in b/152936541#comment25 and #26, I would recommend to set reset_delay_ms = 0 and stop_delay_ms = 100 so we can follow the spec for * raise reset# and stop# (report switch) to high at the near same time. * make sure trsi and Trsw all meets the 100ms requirement. [1] https://drive.google.com/corp/drive/folders/1s0gPwoI8x7V9w0XjMOIV-DvnCfNO0i… https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/deded… PS4, Line 82: 7 > Here's where the 7 came from: […] From the same page 13 of the spec above as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/43304 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42fdc5e8243d2c70c953b2f516c10f84a041c035 Gerrit-Change-Number: 43304 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Justin TerAvest <teravest(a)chromium.org> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 14 Jul 2020 14:01:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Justin TerAvest <teravest(a)chromium.org> Comment-In-Reply-To: Evan Green <evgreen(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/wdee: Disable WLAN for Wdee
by Maulik V Vaghela (Code Review) 14 Jul '20

14 Jul '20

Hello Uday M Bhat, Meera Ravindranath, Krishna P Bhat D, Ronak Kanabar, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/42098 to look at the new patch set (#3). Change subject: mb/google/wdee: Disable WLAN for Wdee ...................................................................... mb/google/wdee: Disable WLAN for Wdee Waddledee uses integrated WLAN and not on discrete PCI WLAN. Thus disabling PCI WLAN to save power BUG=None BRANCH=None TEST=Platform enters into s0ix after this change. Change-Id: I0ac1c9a83fbbf03066c09774324313f62d58bc38 Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/mainboard/google/dedede/variants/waddledee/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/42098/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/42098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ac1c9a83fbbf03066c09774324313f62d58bc38 Gerrit-Change-Number: 42098 Gerrit-PatchSet: 3 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Uday M Bhat Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/mipi_camera: Add guard to protect camera resources
by Sugnan Prabhu S (Code Review) 14 Jul '20

14 Jul '20

Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43003 ) Change subject: drivers/intel/mipi_camera: Add guard to protect camera resources ...................................................................... Patch Set 8: (15 comments) https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… File src/drivers/intel/mipi_camera/camera.c: https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 490: struct > const struct Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 551: method_name = get_op_method_namestring(res_config, res_index); > Hm, since we don't need method_name to have a very long lifetime, what about, instead of returning a […] I have moved acpigen_emit_namestring to get_op_method_namestring and renamed the function to add_guarded_method_namestring. This method is called from only one place. There is not much code in call_guarded_method unlike before when we made this change. Is it ok to move back code from the method add_guarded_method_namestring to call_guarded_method. https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 562: acpigen_emit_namestring("MCON"); > I'm wondering if this should include a CondRefOf op to check for MCON's existence first? what do you […] Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 566: acpigen_emit_namestring("MCOF"); > I'm wondering if this should include a CondRefOf op to check for MCOF's existence first? what do you […] Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 561: if (action == ENABLE) { : acpigen_emit_namestring("MCON"); : acpigen_write_integer(clk_config->clknum); : acpigen_write_integer(clk_config->freq); : } else if (action == DISABLE) { : acpigen_emit_namestring("MCOF"); : acpigen_write_integer(clk_config->clknum); : } else { : acpigen_write_debug_string("Unsupported clock action"); : printk(BIOS_ERR, "Unsupported clock action: %x\n" : "OS camera driver will likely not work", action); : } > switch-case conveys the intent more clearly, since `action`'s value is the only condition Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 579: : if (action == ENABLE) { : acpigen_soc_set_tx_gpio(gpio_config->gpio_num); : } else if (action == DISABLE) { : acpigen_soc_clear_tx_gpio(gpio_config->gpio_num); : } else { : acpigen_write_debug_string("Unsupported GPIO action"); : printk(BIOS_ERR, "Unsupported GPIO action: %x\n" : "OS camera driver will likely not work\n", action); : } > switch-case conveys the intent more clearly, since `action`'s value is the only condition Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 619: 5 > We're using this `5` an awful lot, maybe we should add a constant into acpigen.h? Something like […] Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 627: char method_name[5], varname[5]; > nit: declare on separate lines Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 631: acpigen_write_method_serialized(method_name, 0); > nit: blank line after snprintfs Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 642: struct > const struct res_config is being modified by resource_set_action_type called in this function, so res_config cannot be const https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 644: char method_name[5], varname[5]; > nit: declare on separate lines Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 648: acpigen_write_method_serialized(method_name, 0); > nit: blank line after snprintfs Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 659: struct > const struct Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 660: struct > const struct Done https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… File src/drivers/intel/mipi_camera/chip.h: https://review.coreboot.org/c/coreboot/+/43003/7/src/drivers/intel/mipi_cam… PS7, Line 80: ENABLE = 1, > nit: for enums like this, with an 'UNKNOWN' option, it's often convenient to have that defined as th […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/43003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1468459d5bbb2fb07bef4e0590c96dd4dbab0d9c Gerrit-Change-Number: 43003 Gerrit-PatchSet: 8 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Comment-Date: Tue, 14 Jul 2020 11:48:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/mipi_camera: Add guard to protect camera resources
by Sugnan Prabhu S (Code Review) 14 Jul '20

14 Jul '20

Hello Varshit B Pandya, build bot (Jenkins), Matt Delco, Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/43003 to look at the new patch set (#8). Change subject: drivers/intel/mipi_camera: Add guard to protect camera resources ...................................................................... drivers/intel/mipi_camera: Add guard to protect camera resources This change updates the mipi_camera driver to handle shared power resource between multiple cameras. This is achieved by adding a guard variable and methods to manipulate the guard variable before calling the actual method which enables or disables the resource. This protects the shared resources from being enabled or disabled multiple times while the resources are being used by multiple cameras. Change-Id: I1468459d5bbb2fb07bef4e0590c96dd4dbab0d9c Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> --- M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/mipi_camera/chip.h 2 files changed, 348 insertions(+), 40 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/43003/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/43003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1468459d5bbb2fb07bef4e0590c96dd4dbab0d9c Gerrit-Change-Number: 43003 Gerrit-PatchSet: 8 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Matt Delco <delco(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: cpu/x86/smm: Enable SMM support for Xeon-SP
by Angel Pons (Code Review) 14 Jul '20

14 Jul '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41829 ) Change subject: cpu/x86/smm: Enable SMM support for Xeon-SP ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/41829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78bd74c11ca42fb430f63711b5ec87d4bfe6ca2a Gerrit-Change-Number: 41829 Gerrit-PatchSet: 8 Gerrit-Owner: Rocky Phagura Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Eugene Myers <cedarhouse(a)comcast.net> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki.2011(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ron Minnich <rminnich(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 14 Jul 2020 10:38:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: Enable SMM support for Xeon-SP
by Angel Pons (Code Review) 14 Jul '20

14 Jul '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41829 ) Change subject: cpu/x86/smm: Enable SMM support for Xeon-SP ...................................................................... Patch Set 8: (2 comments) https://review.coreboot.org/c/coreboot/+/41829/8//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/41829/8//COMMIT_MSG@9 PS8, Line 9: a drop this `a` https://review.coreboot.org/c/coreboot/+/41829/8//COMMIT_MSG@9 PS8, Line 9: Xeon-SP a Skylake Scalable Processor can have 36 CPU threads(18 cores). Current Please wrap these at 72 characters (at least I see on the UI that the lines are a tad bit too long and get wrapped, which looks bad) -- To view, visit https://review.coreboot.org/c/coreboot/+/41829 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78bd74c11ca42fb430f63711b5ec87d4bfe6ca2a Gerrit-Change-Number: 41829 Gerrit-PatchSet: 8 Gerrit-Owner: Rocky Phagura Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Eugene Myers <cedarhouse(a)comcast.net> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Naresh Solanki <naresh.solanki.2011(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Ron Minnich <rminnich(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 14 Jul 2020 10:38:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/jasperlake_rvp: Camera remove DSDT and enable SSDT
by Sugnan Prabhu S (Code Review) 14 Jul '20

14 Jul '20

Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41758 ) Change subject: mb/intel/jasperlake_rvp: Camera remove DSDT and enable SSDT ...................................................................... Patch Set 24: (2 comments) > Patch Set 24: > > (1 comment) > > Are you still working on this or is it ready? Changes are being tested internally. https://review.coreboot.org/c/coreboot/+/41758/24//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/41758/24//COMMIT_MSG@7 PS24, Line 7: mb/intel/jasperlake_rvp: Camera remove DSDT and enable SSDT > Maybe: […] I will update this as part of next CL https://review.coreboot.org/c/coreboot/+/41758/24/src/mainboard/intel/jaspe… File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb: https://review.coreboot.org/c/coreboot/+/41758/24/src/mainboard/intel/jaspe… PS24, Line 160: 0x50000 > I think this may be something we could automate in the future: this is just acpigen_write_ADR_pci_de […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/41758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib439572bc1d15ef02c86c7bfa88af6b16eb06f97 Gerrit-Change-Number: 41758 Gerrit-PatchSet: 24 Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Daniel Kang <daniel.h.kang(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kiran2 Kumar <kiran2.kumar(a)intel.corp-partner.google.com> Gerrit-CC: Matt Delco <delco(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Tue, 14 Jul 2020 10:38:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)users.sourceforge.net> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/wdee: Disable WLAN for Wdee
by Paul Menzel (Code Review) 14 Jul '20

14 Jul '20

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42098 ) Change subject: mb/google/wdee: Disable WLAN for Wdee ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/42098/2//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/42098/2//COMMIT_MSG@8 PS2, Line 8: Please add a reasoning. -- To view, visit https://review.coreboot.org/c/coreboot/+/42098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0ac1c9a83fbbf03066c09774324313f62d58bc38 Gerrit-Change-Number: 42098 Gerrit-PatchSet: 2 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Uday M Bhat Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Comment-Date: Tue, 14 Jul 2020 09:47:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2020