Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43407 )
Change subject: payloads/depthcharge: Makefile: resolve fail of concurrent build
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/43407
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbd9155e01fcc4571a61f1bba5b2b4a446036da0
Gerrit-Change-Number: 43407
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 13 Jul 2020 13:20:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42496 )
Change subject: lib: Add ASan support to ramstage on x86 arch
......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42496/19/src/include/asan.h
File src/include/asan.h:
https://review.coreboot.org/c/coreboot/+/42496/19/src/include/asan.h@4
PS19, Line 4:
> Either: […]
I would prefer types.h here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42496
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica06bd2be78fcfc79fa888721ed920d4e8248f3b
Gerrit-Change-Number: 42496
Gerrit-PatchSet: 19
Gerrit-Owner: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 12:27:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42496 )
Change subject: lib: Add ASan support to ramstage on x86 arch
......................................................................
Patch Set 19:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42496/19/src/include/asan.h
File src/include/asan.h:
https://review.coreboot.org/c/coreboot/+/42496/19/src/include/asan.h@4
PS19, Line 4:
> As you are using size_t and uint32_t types here, please add the needed includes here in order to not […]
Either:
#include <stdint.h>
#include <stddef.h>
Or:
#include <types.h>
https://review.coreboot.org/c/coreboot/+/42496/19/src/include/asan.h@50
PS19, Line 50: void
void? I'd expect a name to be of char type (void pointers and char pointers are equivalent, I think)
--
To view, visit https://review.coreboot.org/c/coreboot/+/42496
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica06bd2be78fcfc79fa888721ed920d4e8248f3b
Gerrit-Change-Number: 42496
Gerrit-PatchSet: 19
Gerrit-Owner: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 11:34:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-MessageType: comment
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42496 )
Change subject: lib: Add ASan support to ramstage on x86 arch
......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42496/19/src/include/asan.h
File src/include/asan.h:
https://review.coreboot.org/c/coreboot/+/42496/19/src/include/asan.h@4
PS19, Line 4:
As you are using size_t and uint32_t types here, please add the needed includes here in order to not rely on a nested include in the proper order somewhere else.
--
To view, visit https://review.coreboot.org/c/coreboot/+/42496
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica06bd2be78fcfc79fa888721ed920d4e8248f3b
Gerrit-Change-Number: 42496
Gerrit-PatchSet: 19
Gerrit-Owner: Harshit Sharma <harshitsharmajs(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Mon, 13 Jul 2020 11:30:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment