Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41829 )
Change subject: cpu/x86/smm: Enable SMM support for Xeon-SP ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41829/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41829/8//COMMIT_MSG@9 PS8, Line 9: a drop this `a`
https://review.coreboot.org/c/coreboot/+/41829/8//COMMIT_MSG@9 PS8, Line 9: Xeon-SP a Skylake Scalable Processor can have 36 CPU threads(18 cores). Current Please wrap these at 72 characters (at least I see on the UI that the lines are a tad bit too long and get wrapped, which looks bad)