Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43304 )
Change subject: mb/google/dedede: Enable SIS touchscreen for Waddledee ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede... PS4, Line 77: 100
Karthik pulled the value here from the discussion on Waddledoo, I'm betting. […]
* Regarding this 100ms, please refer to page 13 of [1]. * But as the discussion in b/152936541#comment25 and #26, I would recommend to set reset_delay_ms = 0 and stop_delay_ms = 100 so we can follow the spec for * raise reset# and stop# (report switch) to high at the near same time. * make sure trsi and Trsw all meets the 100ms requirement.
[1] https://drive.google.com/corp/drive/folders/1s0gPwoI8x7V9w0XjMOIV-DvnCfNO0iF...
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede... PS4, Line 82: 7
Here's where the 7 came from: […]
From the same page 13 of the spec above as well.