Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43304 )
Change subject: mb/google/dedede: Enable SIS touchscreen for Waddledee
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/waddledee/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede...
PS4, Line 77: 100
- Regarding this 100ms, please refer to page 13 of [1]. […]
Done
https://review.coreboot.org/c/coreboot/+/43304/4/src/mainboard/google/dedede...
PS4, Line 82: 7
From the same page 13 of the spec above as well.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43304
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42fdc5e8243d2c70c953b2f516c10f84a041c035
Gerrit-Change-Number: 43304
Gerrit-PatchSet: 5
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jul 2020 18:32:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Justin TerAvest
teravest@chromium.org
Comment-In-Reply-To: Evan Green
evgreen@chromium.org
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Gerrit-MessageType: comment