Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43438 )
Change subject: mb/hatch: Fix Puff baseboard missing mainboard symbols ......................................................................
mb/hatch: Fix Puff baseboard missing mainboard symbols
Fix a missing CONFIG_ prefix in Makefile.
BUG=b:161154280 BRANCH=puff TEST=builds
Change-Id: I177fcd830a8a03a8db1910bfbfd784a60dc08e11 Spotted-by: Ryan Lin. Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/variants/baseboard/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/43438/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/Makefile.inc b/src/mainboard/google/hatch/variants/baseboard/Makefile.inc index c92d1bb..69f9322 100644 --- a/src/mainboard/google/hatch/variants/baseboard/Makefile.inc +++ b/src/mainboard/google/hatch/variants/baseboard/Makefile.inc @@ -6,7 +6,7 @@ romstage-y += memory.c
ramstage-y += gpio.c -ramstage-$(BOARD_GOOGLE_BASEBOARD_PUFF) += mainboard.c +ramstage-$(CONFIG_BOARD_GOOGLE_BASEBOARD_PUFF) += mainboard.c
verstage-y += gpio.c
Edward O'Callaghan has removed Martin Roth from this change. ( https://review.coreboot.org/c/coreboot/+/43438 )
Change subject: mb/hatch: Fix Puff baseboard missing mainboard symbols ......................................................................
Removed reviewer Martin Roth.
Edward O'Callaghan has removed Patrick Georgi from this change. ( https://review.coreboot.org/c/coreboot/+/43438 )
Change subject: mb/hatch: Fix Puff baseboard missing mainboard symbols ......................................................................
Removed reviewer Patrick Georgi.
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43438 )
Change subject: mb/hatch: Fix Puff baseboard missing mainboard symbols ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43438 )
Change subject: mb/hatch: Fix Puff baseboard missing mainboard symbols ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43438/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43438/1//COMMIT_MSG@16 PS1, Line 16: Spotted-by: Ryan Lin. Nit: Remove the dot at the end?
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43438 )
Change subject: mb/hatch: Fix Puff baseboard missing mainboard symbols ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43438/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43438/1//COMMIT_MSG@16 PS1, Line 16: Spotted-by: Ryan Lin.
Nit: Remove the dot at the end?
Ack
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43438 )
Change subject: mb/hatch: Fix Puff baseboard missing mainboard symbols ......................................................................
mb/hatch: Fix Puff baseboard missing mainboard symbols
Fix a missing CONFIG_ prefix in Makefile.
BUG=b:161154280 BRANCH=puff TEST=builds
Change-Id: I177fcd830a8a03a8db1910bfbfd784a60dc08e11 Spotted-by: Ryan Lin. Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43438 Reviewed-by: Sam McNally sammc@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/baseboard/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/Makefile.inc b/src/mainboard/google/hatch/variants/baseboard/Makefile.inc index c92d1bb..69f9322 100644 --- a/src/mainboard/google/hatch/variants/baseboard/Makefile.inc +++ b/src/mainboard/google/hatch/variants/baseboard/Makefile.inc @@ -6,7 +6,7 @@ romstage-y += memory.c
ramstage-y += gpio.c -ramstage-$(BOARD_GOOGLE_BASEBOARD_PUFF) += mainboard.c +ramstage-$(CONFIG_BOARD_GOOGLE_BASEBOARD_PUFF) += mainboard.c
verstage-y += gpio.c
-
Edward O'Callaghan (Code Review) -
Paul Menzel (Code Review)
-
Sam McNally (Code Review)