coreboot-gerrit June 2020

coreboot-gerrit@coreboot.org

1 participants
2826 discussions

Change in coreboot[master]: mb/intel/tglrvp: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41316 ) Change subject: mb/intel/tglrvp: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/intel/tglrvp: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: If0b7cd4386d4655d781a80f968a5db8b2d1dc2b2 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/intel/tglrvp/bootblock.c M src/mainboard/intel/tglrvp/mainboard.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/41316/1 diff --git a/src/mainboard/intel/tglrvp/bootblock.c b/src/mainboard/intel/tglrvp/bootblock.c index a8f7e41..7b0984c 100644 --- a/src/mainboard/intel/tglrvp/bootblock.c +++ b/src/mainboard/intel/tglrvp/bootblock.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> void bootblock_mainboard_init(void) { diff --git a/src/mainboard/intel/tglrvp/mainboard.c b/src/mainboard/intel/tglrvp/mainboard.c index 0ebc415..fc03d14 100644 --- a/src/mainboard/intel/tglrvp/mainboard.c +++ b/src/mainboard/intel/tglrvp/mainboard.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <device/device.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <smbios.h> #include <stdio.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/41316 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0b7cd4386d4655d781a80f968a5db8b2d1dc2b2 Gerrit-Change-Number: 41316 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/intel/strago: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41315 ) Change subject: mb/intel/strago: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/intel/strago: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I41fe98b52fb426124b22a05b1cae6c3b0748a174 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/intel/strago/com_init.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/strago/mainboard.c M src/mainboard/intel/strago/smihandler.c 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/41315/1 diff --git a/src/mainboard/intel/strago/com_init.c b/src/mainboard/intel/strago/com_init.c index 0f4cdfa..83082a2 100644 --- a/src/mainboard/intel/strago/com_init.c +++ b/src/mainboard/intel/strago/com_init.c @@ -3,7 +3,7 @@ #include <bootblock_common.h> #include <device/mmio.h> #include <device/pci_ops.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/lpc.h> #include <soc/pci_devs.h> diff --git a/src/mainboard/intel/strago/gpio.c b/src/mainboard/intel/strago/gpio.c index fb82091..7c4e493 100644 --- a/src/mainboard/intel/strago/gpio.c +++ b/src/mainboard/intel/strago/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include "irqroute.h" -#include <soc/gpio.h> +#include <gpio.h> #include <boardid.h> #include "onboard.h" #include "gpio.h" diff --git a/src/mainboard/intel/strago/mainboard.c b/src/mainboard/intel/strago/mainboard.c index 287623e..0ee6892 100644 --- a/src/mainboard/intel/strago/mainboard.c +++ b/src/mainboard/intel/strago/mainboard.c @@ -2,7 +2,7 @@ #include <bootstate.h> #include <device/device.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include "ec.h" diff --git a/src/mainboard/intel/strago/smihandler.c b/src/mainboard/intel/strago/smihandler.c index e770057..bf9ec4c 100644 --- a/src/mainboard/intel/strago/smihandler.c +++ b/src/mainboard/intel/strago/smihandler.c @@ -11,7 +11,7 @@ #include <soc/nvs.h> #include <soc/pm.h> -#include <soc/gpio.h> +#include <gpio.h> #include "onboard.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/41315 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I41fe98b52fb426124b22a05b1cae6c3b0748a174 Gerrit-Change-Number: 41315 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/intel/saddlebrook: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41314 ) Change subject: mb/intel/saddlebrook: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/intel/saddlebrook: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I51efb6ffb37eaefe186be5764efa6032d0c70dbf Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/intel/saddlebrook/bootblock.c M src/mainboard/intel/saddlebrook/romstage.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/41314/1 diff --git a/src/mainboard/intel/saddlebrook/bootblock.c b/src/mainboard/intel/saddlebrook/bootblock.c index 6abc4c5..1ccf4c1 100644 --- a/src/mainboard/intel/saddlebrook/bootblock.c +++ b/src/mainboard/intel/saddlebrook/bootblock.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> #include "gpio.h" #include <superio/nuvoton/common/nuvoton.h> diff --git a/src/mainboard/intel/saddlebrook/romstage.c b/src/mainboard/intel/saddlebrook/romstage.c index f96add7..a91bb67 100644 --- a/src/mainboard/intel/saddlebrook/romstage.c +++ b/src/mainboard/intel/saddlebrook/romstage.c @@ -2,7 +2,7 @@ #include <console/console.h> #include <fsp/api.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/pm.h> #include <soc/romstage.h> #include "spd/spd.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/41314 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I51efb6ffb37eaefe186be5764efa6032d0c70dbf Gerrit-Change-Number: 41314 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/intel/kunimitsu: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41313 ) Change subject: mb/intel/kunimitsu: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/intel/kunimitsu: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: Ibe1f1d52f885f34523897e54543286d548f03d71 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/intel/kunimitsu/bootblock_mainboard.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/kunimitsu/romstage.c 3 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/41313/1 diff --git a/src/mainboard/intel/kunimitsu/bootblock_mainboard.c b/src/mainboard/intel/kunimitsu/bootblock_mainboard.c index ae4e26c..abbbd54 100644 --- a/src/mainboard/intel/kunimitsu/bootblock_mainboard.c +++ b/src/mainboard/intel/kunimitsu/bootblock_mainboard.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> #include "gpio.h" static void early_config_gpio(void) diff --git a/src/mainboard/intel/kunimitsu/chromeos.c b/src/mainboard/intel/kunimitsu/chromeos.c index 3b8725f..37dc026 100644 --- a/src/mainboard/intel/kunimitsu/chromeos.c +++ b/src/mainboard/intel/kunimitsu/chromeos.c @@ -2,7 +2,6 @@ #include <boot/coreboot_tables.h> #include <gpio.h> -#include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include "gpio.h" diff --git a/src/mainboard/intel/kunimitsu/romstage.c b/src/mainboard/intel/kunimitsu/romstage.c index f6bd5c2..56c8611 100644 --- a/src/mainboard/intel/kunimitsu/romstage.c +++ b/src/mainboard/intel/kunimitsu/romstage.c @@ -4,7 +4,6 @@ #include <gpio.h> #include "gpio.h" #include <soc/romstage.h> -#include <soc/gpio.h> #include "spd/spd.h" void mainboard_memory_init_params(FSPM_UPD *mupd) -- To view, visit https://review.coreboot.org/c/coreboot/+/41313 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibe1f1d52f885f34523897e54543286d548f03d71 Gerrit-Change-Number: 41313 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/intel/kblrvp: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41312 ) Change subject: mb/intel/kblrvp: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/intel/kblrvp: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I2f60e9bc3c8c176480e80d8e1920341b320b51af Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/intel/kblrvp/bootblock.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/romstage.c 3 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/41312/1 diff --git a/src/mainboard/intel/kblrvp/bootblock.c b/src/mainboard/intel/kblrvp/bootblock.c index 19c5e9e..2fbf694 100644 --- a/src/mainboard/intel/kblrvp/bootblock.c +++ b/src/mainboard/intel/kblrvp/bootblock.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h> static void early_config_gpio(void) diff --git a/src/mainboard/intel/kblrvp/chromeos.c b/src/mainboard/intel/kblrvp/chromeos.c index 270c84d..013a828 100644 --- a/src/mainboard/intel/kblrvp/chromeos.c +++ b/src/mainboard/intel/kblrvp/chromeos.c @@ -3,7 +3,6 @@ #include <boot/coreboot_tables.h> #include <device/device.h> #include <gpio.h> -#include <soc/gpio.h> #include <ec/google/chromeec/ec.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/intel/kblrvp/romstage.c b/src/mainboard/intel/kblrvp/romstage.c index 281a24f..395d880 100644 --- a/src/mainboard/intel/kblrvp/romstage.c +++ b/src/mainboard/intel/kblrvp/romstage.c @@ -6,7 +6,6 @@ #include <gpio.h> #include "gpio.h" #include <soc/romstage.h> -#include <soc/gpio.h> #include "spd/spd.h" #include <spd_bin.h> #include "board_id.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/41312 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2f60e9bc3c8c176480e80d8e1920341b320b51af Gerrit-Change-Number: 41312 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/intel/jasperlake_rvp: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41311 ) Change subject: mb/intel/jasperlake_rvp: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/intel/jasperlake_rvp: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I248d354e5d6dbc8ecf5fcc66dd7faf7d5f4c94b7 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/intel/jasperlake_rvp/bootblock.c M src/mainboard/intel/jasperlake_rvp/mainboard.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/41311/1 diff --git a/src/mainboard/intel/jasperlake_rvp/bootblock.c b/src/mainboard/intel/jasperlake_rvp/bootblock.c index a8f7e41..7b0984c 100644 --- a/src/mainboard/intel/jasperlake_rvp/bootblock.c +++ b/src/mainboard/intel/jasperlake_rvp/bootblock.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> void bootblock_mainboard_init(void) { diff --git a/src/mainboard/intel/jasperlake_rvp/mainboard.c b/src/mainboard/intel/jasperlake_rvp/mainboard.c index 3b9dff9..b0f6068 100644 --- a/src/mainboard/intel/jasperlake_rvp/mainboard.c +++ b/src/mainboard/intel/jasperlake_rvp/mainboard.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <device/device.h> -#include <soc/gpio.h> +#include <gpio.h> #include <smbios.h> #include <vendorcode/google/chromeos/chromeos.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/41311 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I248d354e5d6dbc8ecf5fcc66dd7faf7d5f4c94b7 Gerrit-Change-Number: 41311 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/intel/icelake_rvp: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41310 ) Change subject: mb/intel/icelake_rvp: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/intel/icelake_rvp: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: Ib4512a020d99d706461fb9bfc9c9d531c5bbd90b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/intel/icelake_rvp/bootblock.c M src/mainboard/intel/icelake_rvp/mainboard.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/41310/1 diff --git a/src/mainboard/intel/icelake_rvp/bootblock.c b/src/mainboard/intel/icelake_rvp/bootblock.c index a8f7e41..7b0984c 100644 --- a/src/mainboard/intel/icelake_rvp/bootblock.c +++ b/src/mainboard/intel/icelake_rvp/bootblock.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> void bootblock_mainboard_init(void) { diff --git a/src/mainboard/intel/icelake_rvp/mainboard.c b/src/mainboard/intel/icelake_rvp/mainboard.c index c8e9e41..7aae1cf 100644 --- a/src/mainboard/intel/icelake_rvp/mainboard.c +++ b/src/mainboard/intel/icelake_rvp/mainboard.c @@ -4,7 +4,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <device/device.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> static void mainboard_init(void *chip_info) -- To view, visit https://review.coreboot.org/c/coreboot/+/41310 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib4512a020d99d706461fb9bfc9c9d531c5bbd90b Gerrit-Change-Number: 41310 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/intel/glkrvp: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41309 ) Change subject: mb/intel/glkrvp: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/intel/glkrvp: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: Ifcc2ac1cc06a63997ec4742b9d2217c47beb5e30 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/intel/glkrvp/bootblock.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/mainboard.c M src/mainboard/intel/glkrvp/smihandler.c 4 files changed, 3 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/41309/1 diff --git a/src/mainboard/intel/glkrvp/bootblock.c b/src/mainboard/intel/glkrvp/bootblock.c index 3e9f51a..4c6eb68 100644 --- a/src/mainboard/intel/glkrvp/bootblock.c +++ b/src/mainboard/intel/glkrvp/bootblock.c @@ -4,7 +4,7 @@ #include <bootblock_common.h> #include <ec/ec.h> #include <intelblocks/lpc_lib.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/ec.h> void bootblock_mainboard_init(void) diff --git a/src/mainboard/intel/glkrvp/chromeos.c b/src/mainboard/intel/glkrvp/chromeos.c index 5944406..50b912a 100644 --- a/src/mainboard/intel/glkrvp/chromeos.c +++ b/src/mainboard/intel/glkrvp/chromeos.c @@ -5,7 +5,6 @@ #include <ec/google/chromeec/ec.h> #include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> -#include <soc/gpio.h> #include <variant/gpio.h> void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/intel/glkrvp/mainboard.c b/src/mainboard/intel/glkrvp/mainboard.c index cfbaf0d..33b692d 100644 --- a/src/mainboard/intel/glkrvp/mainboard.c +++ b/src/mainboard/intel/glkrvp/mainboard.c @@ -7,7 +7,7 @@ #include <device/device.h> #include <ec/ec.h> #include <nhlt.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/nhlt.h> #include <vendorcode/google/chromeos/chromeos.h> #include <variant/ec.h> diff --git a/src/mainboard/intel/glkrvp/smihandler.c b/src/mainboard/intel/glkrvp/smihandler.c index 782d392..74b5f1a 100644 --- a/src/mainboard/intel/glkrvp/smihandler.c +++ b/src/mainboard/intel/glkrvp/smihandler.c @@ -6,7 +6,7 @@ #include <ec/google/chromeec/smm.h> #include <intelblocks/smihandler.h> #include <soc/pm.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/ec.h> #include <variant/gpio.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/41309 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifcc2ac1cc06a63997ec4742b9d2217c47beb5e30 Gerrit-Change-Number: 41309 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/intel/coffeelake_rvp: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41308 ) Change subject: mb/intel/coffeelake_rvp: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/intel/coffeelake_rvp: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I19c167470963fe29ff35d4f36ee1c277108fd1df Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/intel/coffeelake_rvp/bootblock.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/mainboard.c 3 files changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/41308/1 diff --git a/src/mainboard/intel/coffeelake_rvp/bootblock.c b/src/mainboard/intel/coffeelake_rvp/bootblock.c index c39a8ff..00c94cc 100644 --- a/src/mainboard/intel/coffeelake_rvp/bootblock.c +++ b/src/mainboard/intel/coffeelake_rvp/bootblock.c @@ -2,7 +2,7 @@ #include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> void bootblock_mainboard_init(void) { diff --git a/src/mainboard/intel/coffeelake_rvp/chromeos.c b/src/mainboard/intel/coffeelake_rvp/chromeos.c index 5fb7922..77f2c12 100644 --- a/src/mainboard/intel/coffeelake_rvp/chromeos.c +++ b/src/mainboard/intel/coffeelake_rvp/chromeos.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boot/coreboot_tables.h> #include <gpio.h> -#include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/intel/coffeelake_rvp/mainboard.c b/src/mainboard/intel/coffeelake_rvp/mainboard.c index aa073bc..bfb5e0c 100644 --- a/src/mainboard/intel/coffeelake_rvp/mainboard.c +++ b/src/mainboard/intel/coffeelake_rvp/mainboard.c @@ -4,7 +4,7 @@ #include <baseboard/variants.h> #include <device/device.h> #include <nhlt.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/nhlt.h> #include <vendorcode/google/chromeos/chromeos.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/41308 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19c167470963fe29ff35d4f36ee1c277108fd1df Gerrit-Change-Number: 41308 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/intel/cannonlake_rvp: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41307 ) Change subject: mb/intel/cannonlake_rvp: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/intel/cannonlake_rvp: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: Ie3239a2eccab1e88c91029f31a67c71c2a091bfc Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/intel/cannonlake_rvp/bootblock.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/cannonlake_rvp/mainboard.c 3 files changed, 2 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/41307/1 diff --git a/src/mainboard/intel/cannonlake_rvp/bootblock.c b/src/mainboard/intel/cannonlake_rvp/bootblock.c index 22d63b9..6e1e984 100644 --- a/src/mainboard/intel/cannonlake_rvp/bootblock.c +++ b/src/mainboard/intel/cannonlake_rvp/bootblock.c @@ -2,7 +2,7 @@ #include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h> void bootblock_mainboard_init(void) diff --git a/src/mainboard/intel/cannonlake_rvp/chromeos.c b/src/mainboard/intel/cannonlake_rvp/chromeos.c index 98205bc..f5a8179 100644 --- a/src/mainboard/intel/cannonlake_rvp/chromeos.c +++ b/src/mainboard/intel/cannonlake_rvp/chromeos.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boot/coreboot_tables.h> #include <gpio.h> -#include <soc/gpio.h> #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/intel/cannonlake_rvp/mainboard.c b/src/mainboard/intel/cannonlake_rvp/mainboard.c index 950e24d..1f3c7b5 100644 --- a/src/mainboard/intel/cannonlake_rvp/mainboard.c +++ b/src/mainboard/intel/cannonlake_rvp/mainboard.c @@ -4,7 +4,7 @@ #include <baseboard/variants.h> #include <device/device.h> #include <nhlt.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/nhlt.h> #include <vendorcode/google/chromeos/chromeos.h> #include <variant/gpio.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/41307 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3239a2eccab1e88c91029f31a67c71c2a091bfc Gerrit-Change-Number: 41307 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2020