HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41313 )
Change subject: mb/intel/kunimitsu: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/intel/kunimitsu: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: Ibe1f1d52f885f34523897e54543286d548f03d71 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/kunimitsu/bootblock_mainboard.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/kunimitsu/romstage.c 3 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/41313/1
diff --git a/src/mainboard/intel/kunimitsu/bootblock_mainboard.c b/src/mainboard/intel/kunimitsu/bootblock_mainboard.c index ae4e26c..abbbd54 100644 --- a/src/mainboard/intel/kunimitsu/bootblock_mainboard.c +++ b/src/mainboard/intel/kunimitsu/bootblock_mainboard.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> #include "gpio.h"
static void early_config_gpio(void) diff --git a/src/mainboard/intel/kunimitsu/chromeos.c b/src/mainboard/intel/kunimitsu/chromeos.c index 3b8725f..37dc026 100644 --- a/src/mainboard/intel/kunimitsu/chromeos.c +++ b/src/mainboard/intel/kunimitsu/chromeos.c @@ -2,7 +2,6 @@
#include <boot/coreboot_tables.h> #include <gpio.h> -#include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include "gpio.h"
diff --git a/src/mainboard/intel/kunimitsu/romstage.c b/src/mainboard/intel/kunimitsu/romstage.c index f6bd5c2..56c8611 100644 --- a/src/mainboard/intel/kunimitsu/romstage.c +++ b/src/mainboard/intel/kunimitsu/romstage.c @@ -4,7 +4,6 @@ #include <gpio.h> #include "gpio.h" #include <soc/romstage.h> -#include <soc/gpio.h> #include "spd/spd.h"
void mainboard_memory_init_params(FSPM_UPD *mupd)
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41313 )
Change subject: mb/intel/kunimitsu: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324