coreboot-gerrit June 2020

coreboot-gerrit@coreboot.org

1 participants
2826 discussions

Change in coreboot[master]: drivers/ipmi: drop redundant option `wait_for_bmc`
by Michael Niewöhner (Code Review) 05 Jun '20

05 Jun '20

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42020 ) Change subject: drivers/ipmi: drop redundant option `wait_for_bmc` ...................................................................... Patch Set 2: Code-Review-1 (1 comment) this needs great rework..... https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_… File src/drivers/ipmi/ipmi_kcs_ops.c: https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_… PS2, Line 87: Get IPMI version for ACPI and SMBIOS that comment is a lie \o/ we don't get *anything* here -- To view, visit https://review.coreboot.org/c/coreboot/+/42020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id26f85e82a13f53a3731ab88035f2ae4bbffac00 Gerrit-Change-Number: 42020 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Kollasch <jakllsch(a)kollasch.net> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Comment-Date: Fri, 05 Jun 2020 12:18:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common/block/acpi: Fix error in shift operation for GPCL
by Furquan Shaikh (Code Review) 05 Jun '20

05 Jun '20

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41519 ) Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ...................................................................... soc/intel/common/block/acpi: Fix error in shift operation for GPCL CB:41454 updated northbridge.asl to ASL2.0 syntax. During this, GPCL was incorrectly updated to use << (ShiftLeft) instead of >> (ShiftRight). This change fixes the error in GPCL by updating it to use >> (ShiftRight). Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Signed-off-by: Furquan Shaikh <furquan(a)google.com> --- M src/soc/intel/common/block/acpi/acpi/northbridge.asl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/41519/1 diff --git a/src/soc/intel/common/block/acpi/acpi/northbridge.asl b/src/soc/intel/common/block/acpi/acpi/northbridge.asl index 53b2188..2d33ce3 100644 --- a/src/soc/intel/common/block/acpi/acpi/northbridge.asl +++ b/src/soc/intel/common/block/acpi/acpi/northbridge.asl @@ -236,7 +236,7 @@ /* Get DMI BAR */ Method (GDMB, 0, Serialized) { - Local0 = \_SB.PCI0.MCHC.DIBR << 12 + Local0 = \_SB.PCI0.MCHC.DIBR >> 12 Return (Local0) } -- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: newchange

5 11

Change in coreboot[master]: drivers/ipmi: drop redundant option `wait_for_bmc`
by Nico Huber (Code Review) 05 Jun '20

05 Jun '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42020 ) Change subject: drivers/ipmi: drop redundant option `wait_for_bmc` ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_… File src/drivers/ipmi/ipmi_kcs_ops.c: https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_… PS2, Line 107: retry_count < conf->bmc_boot_timeout Comparing u8 < u16 is a potential endless loop. -- To view, visit https://review.coreboot.org/c/coreboot/+/42020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id26f85e82a13f53a3731ab88035f2ae4bbffac00 Gerrit-Change-Number: 42020 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Kollasch <jakllsch(a)kollasch.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Comment-Date: Fri, 05 Jun 2020 11:27:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/ipmi: drop redundant option `wait_for_bmc`
by Nico Huber (Code Review) 05 Jun '20

05 Jun '20

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42020 ) Change subject: drivers/ipmi: drop redundant option `wait_for_bmc` ...................................................................... Patch Set 2: Code-Review-1 This accidentally(?) enables the timeout for tiogapass. -- To view, visit https://review.coreboot.org/c/coreboot/+/42020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id26f85e82a13f53a3731ab88035f2ae4bbffac00 Gerrit-Change-Number: 42020 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Kollasch <jakllsch(a)kollasch.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Comment-Date: Fri, 05 Jun 2020 11:21:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/ipmi: drop redundant option `wait_for_bmc`
by Angel Pons (Code Review) 05 Jun '20

05 Jun '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42020 ) Change subject: drivers/ipmi: drop redundant option `wait_for_bmc` ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_… File src/drivers/ipmi/ipmi_kcs_ops.c: https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_… PS2, Line 88: if (conf && conf->bmc_boot_timeout) { > This codepath will always be taken now. […] Such a thing exists: ocp/tiogapass -- To view, visit https://review.coreboot.org/c/coreboot/+/42020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id26f85e82a13f53a3731ab88035f2ae4bbffac00 Gerrit-Change-Number: 42020 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Kollasch <jakllsch(a)kollasch.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Comment-Date: Fri, 05 Jun 2020 11:19:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/ipmi: drop redundant option `wait_for_bmc`
by Angel Pons (Code Review) 05 Jun '20

05 Jun '20

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42020 ) Change subject: drivers/ipmi: drop redundant option `wait_for_bmc` ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_… File src/drivers/ipmi/ipmi_kcs_ops.c: https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_… PS2, Line 88: if (conf && conf->bmc_boot_timeout) { This codepath will always be taken now. This means the timeout will be at most *twice* as long as the value on bmc_boot_timeout -- To view, visit https://review.coreboot.org/c/coreboot/+/42020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id26f85e82a13f53a3731ab88035f2ae4bbffac00 Gerrit-Change-Number: 42020 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jonathan Kollasch <jakllsch(a)kollasch.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Comment-Date: Fri, 05 Jun 2020 11:18:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/opencellular/elgon: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41322 ) Change subject: mb/opencellular/elgon: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/opencellular/elgon: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: Id9b12189d3deca3ddb21eff56fcc77483c024cf9 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/mainboard/opencellular/elgon/mainboard.c 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/41322/1 diff --git a/src/mainboard/opencellular/elgon/bootblock.c b/src/mainboard/opencellular/elgon/bootblock.c index 5eaece2..ec00d52 100644 --- a/src/mainboard/opencellular/elgon/bootblock.c +++ b/src/mainboard/opencellular/elgon/bootblock.c @@ -4,7 +4,7 @@ #include <soc/soc.h> #include <soc/spi.h> #include <soc/uart.h> -#include <soc/gpio.h> +#include <gpio.h> #include <spi_flash.h> #include <console/console.h> #include <fmap.h> diff --git a/src/mainboard/opencellular/elgon/death.c b/src/mainboard/opencellular/elgon/death.c index 514456c..2c7525b 100644 --- a/src/mainboard/opencellular/elgon/death.c +++ b/src/mainboard/opencellular/elgon/death.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <soc/gpio.h> +#include <gpio.h> #include <console/console.h> #include <delay.h> #include "mainboard.h" diff --git a/src/mainboard/opencellular/elgon/mainboard.c b/src/mainboard/opencellular/elgon/mainboard.c index f9dc03c..15cbf35 100644 --- a/src/mainboard/opencellular/elgon/mainboard.c +++ b/src/mainboard/opencellular/elgon/mainboard.c @@ -7,7 +7,7 @@ #include <device/device.h> #include <libbdk-hal/bdk-config.h> #include <libbdk-hal/bdk-twsi.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/uart.h> #include <console/console.h> #include <soc/clock.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/41322 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9b12189d3deca3ddb21eff56fcc77483c024cf9 Gerrit-Change-Number: 41322 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/cavium/cn8100_sff_evb: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41320 ) Change subject: mb/cavium/cn8100_sff_evb: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/cavium/cn8100_sff_evb: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I4828bd63298fa3f25473725dc8b89df8366c2759 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/cavium/cn8100_sff_evb/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/41320/1 diff --git a/src/mainboard/cavium/cn8100_sff_evb/mainboard.c b/src/mainboard/cavium/cn8100_sff_evb/mainboard.c index 3b26722..ffe1a5e 100644 --- a/src/mainboard/cavium/cn8100_sff_evb/mainboard.c +++ b/src/mainboard/cavium/cn8100_sff_evb/mainboard.c @@ -8,7 +8,7 @@ #include <libbdk-hal/bdk-config.h> #include <libbdk-hal/bdk-twsi.h> #include <soc/twsi.h> -#include <soc/gpio.h> +#include <gpio.h> #include <delay.h> #include <soc/uart.h> #include <console/console.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/41320 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4828bd63298fa3f25473725dc8b89df8366c2759 Gerrit-Change-Number: 41320 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/asrock/h110m: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41319 ) Change subject: mb/asrock/h110m: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/asrock/h110m: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: Ie77cfba2409e8443ebbd7b84517f45fb1ed83769 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/asrock/h110m/bootblock.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/41319/1 diff --git a/src/mainboard/asrock/h110m/bootblock.c b/src/mainboard/asrock/h110m/bootblock.c index 079afd0..0a43363 100644 --- a/src/mainboard/asrock/h110m/bootblock.c +++ b/src/mainboard/asrock/h110m/bootblock.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> #include <superio/nuvoton/common/nuvoton.h> #include <superio/nuvoton/nct6791d/nct6791d.h> #include "include/gpio.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/41319 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie77cfba2409e8443ebbd7b84517f45fb1ed83769 Gerrit-Change-Number: 41319 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Change in coreboot[master]: mb/amd/gardenia: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review) 05 Jun '20

05 Jun '20

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41318 ) Change subject: mb/amd/gardenia: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/amd/gardenia: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: Ifb6d3b12f81c2dd68a36fbfc9c25b7bce39bc517 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/amd/gardenia/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/41318/1 diff --git a/src/mainboard/amd/gardenia/gpio.c b/src/mainboard/amd/gardenia/gpio.c index 38e1d44..96d9010 100644 --- a/src/mainboard/amd/gardenia/gpio.c +++ b/src/mainboard/amd/gardenia/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <soc/southbridge.h> -#include <soc/gpio.h> +#include <gpio.h> #include "gpio.h" -- To view, visit https://review.coreboot.org/c/coreboot/+/41318 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifb6d3b12f81c2dd68a36fbfc9c25b7bce39bc517 Gerrit-Change-Number: 41318 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2020