HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41322 )
Change subject: mb/opencellular/elgon: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/opencellular/elgon: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: Id9b12189d3deca3ddb21eff56fcc77483c024cf9 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/mainboard/opencellular/elgon/mainboard.c 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/41322/1
diff --git a/src/mainboard/opencellular/elgon/bootblock.c b/src/mainboard/opencellular/elgon/bootblock.c index 5eaece2..ec00d52 100644 --- a/src/mainboard/opencellular/elgon/bootblock.c +++ b/src/mainboard/opencellular/elgon/bootblock.c @@ -4,7 +4,7 @@ #include <soc/soc.h> #include <soc/spi.h> #include <soc/uart.h> -#include <soc/gpio.h> +#include <gpio.h> #include <spi_flash.h> #include <console/console.h> #include <fmap.h> diff --git a/src/mainboard/opencellular/elgon/death.c b/src/mainboard/opencellular/elgon/death.c index 514456c..2c7525b 100644 --- a/src/mainboard/opencellular/elgon/death.c +++ b/src/mainboard/opencellular/elgon/death.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <soc/gpio.h> +#include <gpio.h> #include <console/console.h> #include <delay.h> #include "mainboard.h" diff --git a/src/mainboard/opencellular/elgon/mainboard.c b/src/mainboard/opencellular/elgon/mainboard.c index f9dc03c..15cbf35 100644 --- a/src/mainboard/opencellular/elgon/mainboard.c +++ b/src/mainboard/opencellular/elgon/mainboard.c @@ -7,7 +7,7 @@ #include <device/device.h> #include <libbdk-hal/bdk-config.h> #include <libbdk-hal/bdk-twsi.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/uart.h> #include <console/console.h> #include <soc/clock.h>
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41322 )
Change subject: mb/opencellular/elgon: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324