Change in coreboot[master]: soc/intel/common/block/acpi: Fix error in shift operation for GPCL

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Furquan Shaikh (Code Review)

18 May 2020 18 May '20

7:38 p.m.

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41519 )

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

soc/intel/common/block/acpi: Fix error in shift operation for GPCL

CB:41454 updated northbridge.asl to ASL2.0 syntax. During this, GPCL was incorrectly updated to use << (ShiftLeft) instead of >> (ShiftRight). This change fixes the error in GPCL by updating it to use >> (ShiftRight).

Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Signed-off-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/common/block/acpi/acpi/northbridge.asl 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/41519/1

diff --git a/src/soc/intel/common/block/acpi/acpi/northbridge.asl b/src/soc/intel/common/block/acpi/acpi/northbridge.asl index 53b2188..2d33ce3 100644 --- a/src/soc/intel/common/block/acpi/acpi/northbridge.asl +++ b/src/soc/intel/common/block/acpi/acpi/northbridge.asl @@ -236,7 +236,7 @@ /* Get DMI BAR */ Method (GDMB, 0, Serialized) { - Local0 = _SB.PCI0.MCHC.DIBR << 12 + Local0 = _SB.PCI0.MCHC.DIBR >> 12 Return (Local0) }

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Duncan Laurie (Code Review)

18 May 18 May

7:39 p.m.

Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41519 )

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Comment-Date: Mon, 18 May 2020 19:39:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

19 May 19 May

2:32 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41519 )

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

Patch Set 1: Code-Review+2

Oops

-- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 19 May 2020 14:32:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

2:32 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41519 )

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

Patch Set 1: Code-Review-1

(1 comment)

https://review.coreboot.org/c/coreboot/+/41519/1/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/41519/1/src/soc/intel/common/block/... PS1, Line 232: << No, it's this one

-- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 1 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 19 May 2020 14:32:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9:12 p.m.

Hello build bot (Jenkins), Duncan Laurie, Angel Pons, Aaron Durbin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41519

to look at the new patch set (#2).

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

soc/intel/common/block/acpi: Fix error in shift operation for GPCL

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/41519/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

9:12 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41519 )

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41519/1/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/41519/1/src/soc/intel/common/block/... PS1, Line 232: <<

...

No, it's this one

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 2 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 19 May 2020 21:12:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9:21 p.m.

Hello build bot (Jenkins), Duncan Laurie, Angel Pons, Aaron Durbin, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41519

to look at the new patch set (#3).

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

soc/intel/common/block/acpi: Fix error in shift operation for GPCL

TEST=Verified using --timeless option to abuild that the resulting coreboot.rom is same as without the ASL2.0 syntax changes for hatch.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/41519/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

9:22 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41519 )

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41519/1/src/soc/intel/common/block/... File src/soc/intel/common/block/acpi/acpi/northbridge.asl:

https://review.coreboot.org/c/coreboot/+/41519/1/src/soc/intel/common/block/... PS1, Line 232: <<

...

Done

Thanks again! Verified using --timeless option that the change effectively results in the same .rom file as without the ASL2.0 syntax.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 19 May 2020 21:22:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

9:38 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41519 )

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 3 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 19 May 2020 21:38:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

20 May 20 May

12:34 a.m.

Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41519 )

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

soc/intel/common/block/acpi: Fix error in shift operation for GPCL

TEST=Verified using --timeless option to abuild that the resulting coreboot.rom is same as without the ASL2.0 syntax changes for hatch.

Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Signed-off-by: Furquan Shaikh furquan@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41519 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/block/acpi/acpi/northbridge.asl 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/common/block/acpi/acpi/northbridge.asl b/src/soc/intel/common/block/acpi/acpi/northbridge.asl index 53b2188..bac0590 100644 --- a/src/soc/intel/common/block/acpi/acpi/northbridge.asl +++ b/src/soc/intel/common/block/acpi/acpi/northbridge.asl @@ -229,7 +229,7 @@ /* Get PCIe Length */ Method (GPCL, 0, Serialized) { - Local0 = 0x10000000 << _SB.PCI0.MCHC.PXSZ + Local0 = 0x10000000 >> _SB.PCI0.MCHC.PXSZ Return (Local0) }

-- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

12:59 a.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41519 )

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3590 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3589 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3588 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3587

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Wed, 20 May 2020 00:59:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

5 Jun 5 Jun

11:56 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41519 )

Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL ......................................................................

Patch Set 4: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/41519 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68 Gerrit-Change-Number: 41519 Gerrit-PatchSet: 4 Gerrit-Owner: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Fri, 05 Jun 2020 11:56:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1443

days inactive

1461

days old

coreboot-gerrit@coreboot.org

11 comments

5 participants

tags (0)

participants (5)

9elements QA (Code Review)
Angel Pons (Code Review)
Duncan Laurie (Code Review)
Furquan Shaikh (Code Review)
Paul Menzel (Code Review)