Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41519 )
Change subject: soc/intel/common/block/acpi: Fix error in shift operation for GPCL
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41519/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/41519/1/src/soc/intel/common/block/...
PS1, Line 232: <<
Done
Thanks again! Verified using --timeless option that the change effectively results in the same .rom file as without the ASL2.0 syntax.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36469cb3b0bcc595acf0e43808d6a574986cad68
Gerrit-Change-Number: 41519
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 19 May 2020 21:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment