Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42020 )
Change subject: drivers/ipmi: drop redundant option `wait_for_bmc` ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_o... File src/drivers/ipmi/ipmi_kcs_ops.c:
https://review.coreboot.org/c/coreboot/+/42020/2/src/drivers/ipmi/ipmi_kcs_o... PS2, Line 107: retry_count < conf->bmc_boot_timeout Comparing u8 < u16 is a potential endless loop.