mail.coreboot.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
May
April
March
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
List overview
Download
coreboot-gerrit
June 2020
----- 2025 -----
May 2025
April 2025
March 2025
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
coreboot-gerrit@coreboot.org
1 participants
2826 discussions
Start a n
N
ew thread
Change in coreboot[master]: mb/mainboard/google/deltaur: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review)
05 Jun '20
05 Jun '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/41286
) Change subject: mb/mainboard/google/deltaur: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/mainboard/google/deltaur: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I186b287ab48002d73823128ad7bf74c1409cef37 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/deltaur/bootblock.c M src/mainboard/google/deltaur/chromeos.c M src/mainboard/google/deltaur/mainboard.c M src/mainboard/google/deltaur/variants/baseboard/gpio.c 4 files changed, 3 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/41286/1 diff --git a/src/mainboard/google/deltaur/bootblock.c b/src/mainboard/google/deltaur/bootblock.c index 5e5c462..fd45a78 100644 --- a/src/mainboard/google/deltaur/bootblock.c +++ b/src/mainboard/google/deltaur/bootblock.c @@ -6,7 +6,7 @@ #include <baseboard/variants.h> #include <bootblock_common.h> #include <ec/google/wilco/bootblock.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h> static void early_config_gpio(void) diff --git a/src/mainboard/google/deltaur/chromeos.c b/src/mainboard/google/deltaur/chromeos.c index 89a48ce..0e96797 100644 --- a/src/mainboard/google/deltaur/chromeos.c +++ b/src/mainboard/google/deltaur/chromeos.c @@ -8,7 +8,6 @@ #include <baseboard/gpio.h> #include <boot/coreboot_tables.h> #include <gpio.h> -#include <soc/gpio.h> #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <security/tpm/tss.h> diff --git a/src/mainboard/google/deltaur/mainboard.c b/src/mainboard/google/deltaur/mainboard.c index 6dd018e..0b4cdd5 100644 --- a/src/mainboard/google/deltaur/mainboard.c +++ b/src/mainboard/google/deltaur/mainboard.c @@ -6,7 +6,7 @@ #include <acpi/acpi.h> #include <baseboard/variants.h> #include <device/device.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/deltaur/variants/baseboard/gpio.c b/src/mainboard/google/deltaur/variants/baseboard/gpio.c index aabfdc12..139c511 100644 --- a/src/mainboard/google/deltaur/variants/baseboard/gpio.c +++ b/src/mainboard/google/deltaur/variants/baseboard/gpio.c @@ -6,7 +6,7 @@ #include <acpi/acpi.h> #include <baseboard/variants.h> #include <baseboard/gpio.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h> static const struct pad_config gpio_table[] = { -- To view, visit
https://review.coreboot.org/c/coreboot/+/41286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I186b287ab48002d73823128ad7bf74c1409cef37 Gerrit-Change-Number: 41286 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
1
0
0
Change in coreboot[master]: mb/google/cyan: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review)
05 Jun '20
05 Jun '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/41284
) Change subject: mb/google/cyan: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/google/cyan: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I396ce75d109dd5493d8f0f4ab1bcce5a08316f18 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/cyan/com_init.c M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/cyan/spd/spd.c M src/mainboard/google/cyan/variants/banon/gpio.c M src/mainboard/google/cyan/variants/celes/gpio.c M src/mainboard/google/cyan/variants/celes/spd_util.c M src/mainboard/google/cyan/variants/cyan/gpio.c M src/mainboard/google/cyan/variants/edgar/gpio.c M src/mainboard/google/cyan/variants/kefka/gpio.c M src/mainboard/google/cyan/variants/reks/gpio.c M src/mainboard/google/cyan/variants/relm/gpio.c M src/mainboard/google/cyan/variants/setzer/gpio.c M src/mainboard/google/cyan/variants/setzer/spd_util.c M src/mainboard/google/cyan/variants/terra/gpio.c M src/mainboard/google/cyan/variants/ultima/gpio.c M src/mainboard/google/cyan/variants/wizpig/gpio.c 17 files changed, 13 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/41284/1 diff --git a/src/mainboard/google/cyan/chromeos.c b/src/mainboard/google/cyan/chromeos.c index b88862c..9c7ec7a 100644 --- a/src/mainboard/google/cyan/chromeos.c +++ b/src/mainboard/google/cyan/chromeos.c @@ -3,7 +3,6 @@ #include <boot/coreboot_tables.h> #include <device/mmio.h> #include <gpio.h> -#include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> /* The WP status pin lives on MF_ISH_GPIO_4 */ diff --git a/src/mainboard/google/cyan/com_init.c b/src/mainboard/google/cyan/com_init.c index b11ae36..ab1ec99 100644 --- a/src/mainboard/google/cyan/com_init.c +++ b/src/mainboard/google/cyan/com_init.c @@ -3,7 +3,7 @@ #include <bootblock_common.h> #include <device/mmio.h> #include <device/pci_ops.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/lpc.h> #include <soc/pci_devs.h> diff --git a/src/mainboard/google/cyan/smihandler.c b/src/mainboard/google/cyan/smihandler.c index 160b14b..a42d3c7 100644 --- a/src/mainboard/google/cyan/smihandler.c +++ b/src/mainboard/google/cyan/smihandler.c @@ -10,7 +10,7 @@ #include <elog.h> #include <soc/nvs.h> #include <soc/pm.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/onboard.h> diff --git a/src/mainboard/google/cyan/spd/spd.c b/src/mainboard/google/cyan/spd/spd.c index 1c08d90..247a2d4 100644 --- a/src/mainboard/google/cyan/spd/spd.c +++ b/src/mainboard/google/cyan/spd/spd.c @@ -8,7 +8,6 @@ #include <memory_info.h> #include <smbios.h> #include <spd.h> -#include <soc/gpio.h> #include <soc/romstage.h> #include <string.h> #include <spd_bin.h> diff --git a/src/mainboard/google/cyan/variants/banon/gpio.c b/src/mainboard/google/cyan/variants/banon/gpio.c index 6bc9e82..de7ed6c 100644 --- a/src/mainboard/google/cyan/variants/banon/gpio.c +++ b/src/mainboard/google/cyan/variants/banon/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/celes/gpio.c b/src/mainboard/google/cyan/variants/celes/gpio.c index 62ee365..f307155 100644 --- a/src/mainboard/google/cyan/variants/celes/gpio.c +++ b/src/mainboard/google/cyan/variants/celes/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/celes/spd_util.c b/src/mainboard/google/cyan/variants/celes/spd_util.c index 2eec267..c918cc7 100644 --- a/src/mainboard/google/cyan/variants/celes/spd_util.c +++ b/src/mainboard/google/cyan/variants/celes/spd_util.c @@ -2,7 +2,6 @@ #include <console/console.h> #include <gpio.h> -#include <soc/gpio.h> #include <mainboard/google/cyan/spd/spd_util.h> /* diff --git a/src/mainboard/google/cyan/variants/cyan/gpio.c b/src/mainboard/google/cyan/variants/cyan/gpio.c index 8eee5cb..645819d 100644 --- a/src/mainboard/google/cyan/variants/cyan/gpio.c +++ b/src/mainboard/google/cyan/variants/cyan/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/edgar/gpio.c b/src/mainboard/google/cyan/variants/edgar/gpio.c index f327e15..86d7f8c 100644 --- a/src/mainboard/google/cyan/variants/edgar/gpio.c +++ b/src/mainboard/google/cyan/variants/edgar/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/kefka/gpio.c b/src/mainboard/google/cyan/variants/kefka/gpio.c index 1f12104..96428b7 100644 --- a/src/mainboard/google/cyan/variants/kefka/gpio.c +++ b/src/mainboard/google/cyan/variants/kefka/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/reks/gpio.c b/src/mainboard/google/cyan/variants/reks/gpio.c index ecc5c54..f65eec1 100644 --- a/src/mainboard/google/cyan/variants/reks/gpio.c +++ b/src/mainboard/google/cyan/variants/reks/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/relm/gpio.c b/src/mainboard/google/cyan/variants/relm/gpio.c index fca36bb..d4c8fc2 100644 --- a/src/mainboard/google/cyan/variants/relm/gpio.c +++ b/src/mainboard/google/cyan/variants/relm/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/setzer/gpio.c b/src/mainboard/google/cyan/variants/setzer/gpio.c index 7938855..dd9f6f4 100644 --- a/src/mainboard/google/cyan/variants/setzer/gpio.c +++ b/src/mainboard/google/cyan/variants/setzer/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/setzer/spd_util.c b/src/mainboard/google/cyan/variants/setzer/spd_util.c index bb20141..f5ec218 100644 --- a/src/mainboard/google/cyan/variants/setzer/spd_util.c +++ b/src/mainboard/google/cyan/variants/setzer/spd_util.c @@ -2,7 +2,6 @@ #include <console/console.h> #include <gpio.h> -#include <soc/gpio.h> #include <mainboard/google/cyan/spd/spd_util.h> /* diff --git a/src/mainboard/google/cyan/variants/terra/gpio.c b/src/mainboard/google/cyan/variants/terra/gpio.c index 4b970b2..95a892b 100644 --- a/src/mainboard/google/cyan/variants/terra/gpio.c +++ b/src/mainboard/google/cyan/variants/terra/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/ultima/gpio.c b/src/mainboard/google/cyan/variants/ultima/gpio.c index 741b73e..e34b2bf 100644 --- a/src/mainboard/google/cyan/variants/ultima/gpio.c +++ b/src/mainboard/google/cyan/variants/ultima/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { diff --git a/src/mainboard/google/cyan/variants/wizpig/gpio.c b/src/mainboard/google/cyan/variants/wizpig/gpio.c index 300f7d6..7eb362b 100644 --- a/src/mainboard/google/cyan/variants/wizpig/gpio.c +++ b/src/mainboard/google/cyan/variants/wizpig/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <mainboard/google/cyan/irqroute.h> -#include <soc/gpio.h> +#include <gpio.h> /* South East Community */ static const struct soc_gpio_map gpse_gpio_map[] = { -- To view, visit
https://review.coreboot.org/c/coreboot/+/41284
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I396ce75d109dd5493d8f0f4ab1bcce5a08316f18 Gerrit-Change-Number: 41284 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
1
0
0
Change in coreboot[master]: Documentation: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review)
05 Jun '20
05 Jun '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/41282
) Change subject: Documentation: Remove direct 'include <soc/gpio.h>' ...................................................................... Documentation: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I6644db8a81fb95b97a5e3e5551ce6254efa61ae4 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M Documentation/mainboard_io_trap_handler_sample.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/41282/1 diff --git a/Documentation/mainboard_io_trap_handler_sample.c b/Documentation/mainboard_io_trap_handler_sample.c index 558e12f..1d1056b 100644 --- a/Documentation/mainboard_io_trap_handler_sample.c +++ b/Documentation/mainboard_io_trap_handler_sample.c @@ -3,11 +3,11 @@ #include <arch/io.h> #include <console/console.h> #include <cpu/x86/smm.h> +#include <gpio.h> #include <soc/pm.h> #include <soc/smm.h> #include <elog.h> #include <ec/google/chromeec/ec.h> -#include <soc/gpio.h> #include <soc/iomap.h> #include <soc/nvs.h> #include <soc/pm.h> -- To view, visit
https://review.coreboot.org/c/coreboot/+/41282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6644db8a81fb95b97a5e3e5551ce6254efa61ae4 Gerrit-Change-Number: 41282 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
1
0
0
Change in coreboot[master]: mb/google/poppy: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review)
05 Jun '20
05 Jun '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/41301
) Change subject: mb/google/poppy: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/google/poppy: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: Icfc610dc67c72f0e71794ad589f266e7a578f94e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/poppy/bootblock.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/poppy/romstage.c M src/mainboard/google/poppy/smihandler.c 4 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/41301/1 diff --git a/src/mainboard/google/poppy/bootblock.c b/src/mainboard/google/poppy/bootblock.c index efab999..e1f253f 100644 --- a/src/mainboard/google/poppy/bootblock.c +++ b/src/mainboard/google/poppy/bootblock.c @@ -2,7 +2,7 @@ #include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/poppy/chromeos.c b/src/mainboard/google/poppy/chromeos.c index a51207e..74db169 100644 --- a/src/mainboard/google/poppy/chromeos.c +++ b/src/mainboard/google/poppy/chromeos.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boot/coreboot_tables.h> #include <gpio.h> -#include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/poppy/romstage.c b/src/mainboard/google/poppy/romstage.c index 0c1fc02..7bcb412 100644 --- a/src/mainboard/google/poppy/romstage.c +++ b/src/mainboard/google/poppy/romstage.c @@ -4,7 +4,7 @@ #include <baseboard/variants.h> #include <cbfs.h> #include <console/console.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/romstage.h> #include <string.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/poppy/smihandler.c b/src/mainboard/google/poppy/smihandler.c index d54de09..84339e6 100644 --- a/src/mainboard/google/poppy/smihandler.c +++ b/src/mainboard/google/poppy/smihandler.c @@ -5,7 +5,6 @@ #include <ec/google/chromeec/smm.h> #include <elog.h> #include <gpio.h> -#include <soc/gpio.h> #include <intelblocks/smihandler.h> #include <baseboard/variants.h> -- To view, visit
https://review.coreboot.org/c/coreboot/+/41301
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icfc610dc67c72f0e71794ad589f266e7a578f94e Gerrit-Change-Number: 41301 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
1
0
0
Change in coreboot[master]: mb/google/octopus: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review)
05 Jun '20
05 Jun '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/41299
) Change subject: mb/google/octopus: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/google/octopus: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I4a24a819ca3e8db888c4388cb7c90a8e7c1337da Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/octopus/bootblock.c M src/mainboard/google/octopus/chromeos.c M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/octopus/smihandler.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/dood/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/foob/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/lick/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c 15 files changed, 4 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/41299/1 diff --git a/src/mainboard/google/octopus/bootblock.c b/src/mainboard/google/octopus/bootblock.c index 0add453..988bf83 100644 --- a/src/mainboard/google/octopus/bootblock.c +++ b/src/mainboard/google/octopus/bootblock.c @@ -4,7 +4,7 @@ #include <bootblock_common.h> #include <ec/ec.h> #include <intelblocks/lpc_lib.h> -#include <soc/gpio.h> +#include <gpio.h> void bootblock_mainboard_init(void) { diff --git a/src/mainboard/google/octopus/chromeos.c b/src/mainboard/google/octopus/chromeos.c index 03d3b4f..d558ae8 100644 --- a/src/mainboard/google/octopus/chromeos.c +++ b/src/mainboard/google/octopus/chromeos.c @@ -3,9 +3,8 @@ #include <baseboard/variants.h> #include <boot/coreboot_tables.h> #include <ec/google/chromeec/ec.h> -#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h> void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/google/octopus/mainboard.c b/src/mainboard/google/octopus/mainboard.c index e6dbd03..951a752 100644 --- a/src/mainboard/google/octopus/mainboard.c +++ b/src/mainboard/google/octopus/mainboard.c @@ -14,7 +14,7 @@ #include <nhlt.h> #include <smbios.h> #include <soc/cpu.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/nhlt.h> #include <soc/pci_devs.h> #include <stdint.h> diff --git a/src/mainboard/google/octopus/smihandler.c b/src/mainboard/google/octopus/smihandler.c index 2c68045..f27af53 100644 --- a/src/mainboard/google/octopus/smihandler.c +++ b/src/mainboard/google/octopus/smihandler.c @@ -8,7 +8,7 @@ #include <elog.h> #include <intelblocks/smihandler.h> #include <soc/pm.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/ec.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/octopus/variants/bloog/gpio.c b/src/mainboard/google/octopus/variants/bloog/gpio.c index d278136..c4a5607 100644 --- a/src/mainboard/google/octopus/variants/bloog/gpio.c +++ b/src/mainboard/google/octopus/variants/bloog/gpio.c @@ -3,7 +3,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <gpio.h> -#include <soc/gpio.h> static const struct pad_config default_override_table[] = { diff --git a/src/mainboard/google/octopus/variants/bobba/gpio.c b/src/mainboard/google/octopus/variants/bobba/gpio.c index fd94377..9c731c1 100644 --- a/src/mainboard/google/octopus/variants/bobba/gpio.c +++ b/src/mainboard/google/octopus/variants/bobba/gpio.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boardid.h> #include <gpio.h> -#include <soc/gpio.h> #include <ec/google/chromeec/ec.h> enum { diff --git a/src/mainboard/google/octopus/variants/casta/gpio.c b/src/mainboard/google/octopus/variants/casta/gpio.c index 9c8e2a6..f6c82bd 100644 --- a/src/mainboard/google/octopus/variants/casta/gpio.c +++ b/src/mainboard/google/octopus/variants/casta/gpio.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boardid.h> #include <gpio.h> -#include <soc/gpio.h> static const struct pad_config default_override_table[] = { PAD_NC(GPIO_50, UP_20K), /* PCH_I2C_PEN_SDA -- unused */ diff --git a/src/mainboard/google/octopus/variants/dood/gpio.c b/src/mainboard/google/octopus/variants/dood/gpio.c index dfb88d8..95fe5d3 100644 --- a/src/mainboard/google/octopus/variants/dood/gpio.c +++ b/src/mainboard/google/octopus/variants/dood/gpio.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boardid.h> #include <gpio.h> -#include <soc/gpio.h> #include <ec/google/chromeec/ec.h> enum { diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c index 4d92630..67839c1 100644 --- a/src/mainboard/google/octopus/variants/fleex/gpio.c +++ b/src/mainboard/google/octopus/variants/fleex/gpio.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boardid.h> #include <gpio.h> -#include <soc/gpio.h> static const struct pad_config default_override_table[] = { diff --git a/src/mainboard/google/octopus/variants/foob/gpio.c b/src/mainboard/google/octopus/variants/foob/gpio.c index 3e059c8..61597ed 100644 --- a/src/mainboard/google/octopus/variants/foob/gpio.c +++ b/src/mainboard/google/octopus/variants/foob/gpio.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boardid.h> #include <gpio.h> -#include <soc/gpio.h> #include <ec/google/chromeec/ec.h> static const struct pad_config default_override_table[] = { diff --git a/src/mainboard/google/octopus/variants/garg/gpio.c b/src/mainboard/google/octopus/variants/garg/gpio.c index dca07f6..97f7414 100644 --- a/src/mainboard/google/octopus/variants/garg/gpio.c +++ b/src/mainboard/google/octopus/variants/garg/gpio.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boardid.h> #include <gpio.h> -#include <soc/gpio.h> #include <variant/sku.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/google/octopus/variants/lick/gpio.c b/src/mainboard/google/octopus/variants/lick/gpio.c index e813fb1..4d7289f 100644 --- a/src/mainboard/google/octopus/variants/lick/gpio.c +++ b/src/mainboard/google/octopus/variants/lick/gpio.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boardid.h> #include <gpio.h> -#include <soc/gpio.h> #include <ec/google/chromeec/ec.h> #define SKU_UNKNOWN 0xFFFFFFFF diff --git a/src/mainboard/google/octopus/variants/meep/gpio.c b/src/mainboard/google/octopus/variants/meep/gpio.c index 31cd64e..6f89aea 100644 --- a/src/mainboard/google/octopus/variants/meep/gpio.c +++ b/src/mainboard/google/octopus/variants/meep/gpio.c @@ -3,7 +3,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <gpio.h> -#include <soc/gpio.h> #include <variant/sku.h> #include <ec/google/chromeec/ec.h> diff --git a/src/mainboard/google/octopus/variants/phaser/gpio.c b/src/mainboard/google/octopus/variants/phaser/gpio.c index 29b64b5..b421b4d 100644 --- a/src/mainboard/google/octopus/variants/phaser/gpio.c +++ b/src/mainboard/google/octopus/variants/phaser/gpio.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boardid.h> #include <gpio.h> -#include <soc/gpio.h> #include <ec/google/chromeec/ec.h> #define SKU_UNKNOWN 0xFFFFFFFF diff --git a/src/mainboard/google/octopus/variants/yorp/gpio.c b/src/mainboard/google/octopus/variants/yorp/gpio.c index e6b8359..9182548 100644 --- a/src/mainboard/google/octopus/variants/yorp/gpio.c +++ b/src/mainboard/google/octopus/variants/yorp/gpio.c @@ -3,7 +3,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <gpio.h> -#include <soc/gpio.h> /* GPIOs needed prior to ramstage. */ static const struct pad_config early_gpio_table[] = { -- To view, visit
https://review.coreboot.org/c/coreboot/+/41299
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a24a819ca3e8db888c4388cb7c90a8e7c1337da Gerrit-Change-Number: 41299 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
1
0
0
Change in coreboot[master]: mb/google/oak: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review)
05 Jun '20
05 Jun '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/41298
) Change subject: mb/google/oak: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/google/oak: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I43895007aaf84c75f2576ca8dc911b1a21c092ec Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/oak/bootblock.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/41298/1 diff --git a/src/mainboard/google/oak/bootblock.c b/src/mainboard/google/oak/bootblock.c index 82409cf..0b6cf90 100644 --- a/src/mainboard/google/oak/bootblock.c +++ b/src/mainboard/google/oak/bootblock.c @@ -2,9 +2,8 @@ #include <boardid.h> #include <bootblock_common.h> -#include <gpio.h> #include <device/mmio.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/i2c.h> #include <soc/mt6391.h> #include <soc/pericfg.h> -- To view, visit
https://review.coreboot.org/c/coreboot/+/41298
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43895007aaf84c75f2576ca8dc911b1a21c092ec Gerrit-Change-Number: 41298 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
1
0
0
Change in coreboot[master]: mb/google/kukui: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review)
05 Jun '20
05 Jun '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/41297
) Change subject: mb/google/kukui: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/google/kukui: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: Ic66befccdc3dce78a272031784465b40e6cb2204 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/kukui/bootblock.c M src/mainboard/google/kukui/mainboard.c 2 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/41297/1 diff --git a/src/mainboard/google/kukui/bootblock.c b/src/mainboard/google/kukui/bootblock.c index d5df223..2a1e7c3 100644 --- a/src/mainboard/google/kukui/bootblock.c +++ b/src/mainboard/google/kukui/bootblock.c @@ -2,7 +2,7 @@ #include <bootblock_common.h> #include <soc/spi.h> -#include <soc/gpio.h> +#include <gpio.h> void bootblock_mainboard_init(void) { diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index e36ec8b..2b40735 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -12,7 +12,6 @@ #include <gpio.h> #include <soc/ddp.h> #include <soc/dsi.h> -#include <soc/gpio.h> #include <soc/mmu_operations.h> #include <soc/mtcmos.h> #include <soc/spm.h> -- To view, visit
https://review.coreboot.org/c/coreboot/+/41297
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic66befccdc3dce78a272031784465b40e6cb2204 Gerrit-Change-Number: 41297 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
1
0
0
Change in coreboot[master]: mb/google/kahlee: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review)
05 Jun '20
05 Jun '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/41296
) Change subject: mb/google/kahlee: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/google/kahlee: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: Iaacb71bf08098085315cf66cff8f206163617e48 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/kahlee/bootblock/bootblock.c M src/mainboard/google/kahlee/romstage.c M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/baseboard/memory.c M src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c 5 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/41296/1 diff --git a/src/mainboard/google/kahlee/bootblock/bootblock.c b/src/mainboard/google/kahlee/bootblock/bootblock.c index 41dd8de..a7b8428 100644 --- a/src/mainboard/google/kahlee/bootblock/bootblock.c +++ b/src/mainboard/google/kahlee/bootblock/bootblock.c @@ -2,7 +2,7 @@ #include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/southbridge.h> #include <amdblocks/lpc.h> #include <variant/ec.h> diff --git a/src/mainboard/google/kahlee/romstage.c b/src/mainboard/google/kahlee/romstage.c index 389834c..8830df4 100644 --- a/src/mainboard/google/kahlee/romstage.c +++ b/src/mainboard/google/kahlee/romstage.c @@ -2,7 +2,7 @@ #include <amdblocks/dimm_spd.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/romstage.h> int mainboard_read_spd(uint8_t spdAddress, char *buf, size_t len) diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c index abdcb0d..928a4af 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c +++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/southbridge.h> #include <boardid.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/kahlee/variants/baseboard/memory.c b/src/mainboard/google/kahlee/variants/baseboard/memory.c index 8664560..d3d81fd 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/memory.c +++ b/src/mainboard/google/kahlee/variants/baseboard/memory.c @@ -2,7 +2,7 @@ #include <baseboard/variants.h> #include <console/console.h> -#include <gpio.h> /* src/include/gpio.h */ +#include <gpio.h> #include <spd_bin.h> #include <variant/gpio.h> #include <amdblocks/dimm_spd.h> diff --git a/src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c b/src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c index 63625c4..3c60cba 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c +++ b/src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <security/tpm/tis.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/gpio.h> int tis_plat_irq_status(void) -- To view, visit
https://review.coreboot.org/c/coreboot/+/41296
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaacb71bf08098085315cf66cff8f206163617e48 Gerrit-Change-Number: 41296 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
1
0
0
Change in coreboot[master]: mb/google/hatch: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review)
05 Jun '20
05 Jun '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/41294
) Change subject: mb/google/hatch: Remove direct 'include <soc/gpio.h>' ...................................................................... mb/google/hatch: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: Ice18f4e584f160378b7aa2ac54ed626ed35617e2 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/mainboard/google/hatch/bootblock.c M src/mainboard/google/hatch/ramstage.c M src/mainboard/google/hatch/variants/dratini/ramstage.c M src/mainboard/google/hatch/variants/hatch/ramstage.c M src/mainboard/google/hatch/variants/helios/ramstage.c M src/mainboard/google/hatch/variants/jinlon/ramstage.c M src/mainboard/google/hatch/variants/kohaku/ramstage.c M src/mainboard/google/hatch/variants/mushu/ramstage.c M src/mainboard/google/hatch/variants/nightfury/ramstage.c 9 files changed, 9 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/41294/1 diff --git a/src/mainboard/google/hatch/bootblock.c b/src/mainboard/google/hatch/bootblock.c index 041ffcf..520129b 100644 --- a/src/mainboard/google/hatch/bootblock.c +++ b/src/mainboard/google/hatch/bootblock.c @@ -2,7 +2,7 @@ #include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h> static void early_config_gpio(void) { diff --git a/src/mainboard/google/hatch/ramstage.c b/src/mainboard/google/hatch/ramstage.c index af88100..6635311 100644 --- a/src/mainboard/google/hatch/ramstage.c +++ b/src/mainboard/google/hatch/ramstage.c @@ -3,7 +3,7 @@ #include <acpi/acpi.h> #include <baseboard/variants.h> #include <ec/ec.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/ramstage.h> #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/hatch/variants/dratini/ramstage.c b/src/mainboard/google/hatch/variants/dratini/ramstage.c index 176527b..828605d 100644 --- a/src/mainboard/google/hatch/variants/dratini/ramstage.c +++ b/src/mainboard/google/hatch/variants/dratini/ramstage.c @@ -1,9 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <delay.h> -#include <gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> void variant_ramstage_init(void) { diff --git a/src/mainboard/google/hatch/variants/hatch/ramstage.c b/src/mainboard/google/hatch/variants/hatch/ramstage.c index 38bca41..472ff5b 100644 --- a/src/mainboard/google/hatch/variants/hatch/ramstage.c +++ b/src/mainboard/google/hatch/variants/hatch/ramstage.c @@ -5,9 +5,8 @@ */ #include <delay.h> -#include <gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> void variant_ramstage_init(void) { diff --git a/src/mainboard/google/hatch/variants/helios/ramstage.c b/src/mainboard/google/hatch/variants/helios/ramstage.c index 176527b..828605d 100644 --- a/src/mainboard/google/hatch/variants/helios/ramstage.c +++ b/src/mainboard/google/hatch/variants/helios/ramstage.c @@ -1,9 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <delay.h> -#include <gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> void variant_ramstage_init(void) { diff --git a/src/mainboard/google/hatch/variants/jinlon/ramstage.c b/src/mainboard/google/hatch/variants/jinlon/ramstage.c index 176527b..828605d 100644 --- a/src/mainboard/google/hatch/variants/jinlon/ramstage.c +++ b/src/mainboard/google/hatch/variants/jinlon/ramstage.c @@ -1,9 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <delay.h> -#include <gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> void variant_ramstage_init(void) { diff --git a/src/mainboard/google/hatch/variants/kohaku/ramstage.c b/src/mainboard/google/hatch/variants/kohaku/ramstage.c index 176527b..828605d 100644 --- a/src/mainboard/google/hatch/variants/kohaku/ramstage.c +++ b/src/mainboard/google/hatch/variants/kohaku/ramstage.c @@ -1,9 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <delay.h> -#include <gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> void variant_ramstage_init(void) { diff --git a/src/mainboard/google/hatch/variants/mushu/ramstage.c b/src/mainboard/google/hatch/variants/mushu/ramstage.c index 38bca41..472ff5b 100644 --- a/src/mainboard/google/hatch/variants/mushu/ramstage.c +++ b/src/mainboard/google/hatch/variants/mushu/ramstage.c @@ -5,9 +5,8 @@ */ #include <delay.h> -#include <gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> void variant_ramstage_init(void) { diff --git a/src/mainboard/google/hatch/variants/nightfury/ramstage.c b/src/mainboard/google/hatch/variants/nightfury/ramstage.c index d5a57af..2977cb3 100644 --- a/src/mainboard/google/hatch/variants/nightfury/ramstage.c +++ b/src/mainboard/google/hatch/variants/nightfury/ramstage.c @@ -1,9 +1,8 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <delay.h> -#include <gpio.h> #include <baseboard/variants.h> -#include <soc/gpio.h> +#include <gpio.h> void variant_ramstage_init(void) { -- To view, visit
https://review.coreboot.org/c/coreboot/+/41294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ice18f4e584f160378b7aa2ac54ed626ed35617e2 Gerrit-Change-Number: 41294 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
1
0
0
Change in coreboot[master]: src/soc/cavium/cn81xx: Remove direct 'include <soc/gpio.h>'
by HAOUAS Elyes (Code Review)
05 Jun '20
05 Jun '20
HAOUAS Elyes has uploaded this change for review. (
https://review.coreboot.org/c/coreboot/+/41333
) Change subject: src/soc/cavium/cn81xx: Remove direct 'include <soc/gpio.h>' ...................................................................... src/soc/cavium/cn81xx: Remove direct 'include <soc/gpio.h>' Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>. Change-Id: I30048836de1a2897dd9b8fc099204d9f0f19439e Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/cavium/cn81xx/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/41333/1 diff --git a/src/soc/cavium/cn81xx/gpio.c b/src/soc/cavium/cn81xx/gpio.c index 4e29a57..3f0a9a1 100644 --- a/src/soc/cavium/cn81xx/gpio.c +++ b/src/soc/cavium/cn81xx/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/console.h> -#include <soc/gpio.h> +#include <gpio.h> #include <device/mmio.h> #include <endian.h> #include <soc/addressmap.h> -- To view, visit
https://review.coreboot.org/c/coreboot/+/41333
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30048836de1a2897dd9b8fc099204d9f0f19439e Gerrit-Change-Number: 41333 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: newchange
1
1
0
0
← Newer
1
...
252
253
254
255
256
257
258
...
283
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
Results per page:
10
25
50
100
200