HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41315 )
Change subject: mb/intel/strago: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/intel/strago: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: I41fe98b52fb426124b22a05b1cae6c3b0748a174 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/strago/com_init.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/strago/mainboard.c M src/mainboard/intel/strago/smihandler.c 4 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/41315/1
diff --git a/src/mainboard/intel/strago/com_init.c b/src/mainboard/intel/strago/com_init.c index 0f4cdfa..83082a2 100644 --- a/src/mainboard/intel/strago/com_init.c +++ b/src/mainboard/intel/strago/com_init.c @@ -3,7 +3,7 @@ #include <bootblock_common.h> #include <device/mmio.h> #include <device/pci_ops.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/lpc.h> #include <soc/pci_devs.h>
diff --git a/src/mainboard/intel/strago/gpio.c b/src/mainboard/intel/strago/gpio.c index fb82091..7c4e493 100644 --- a/src/mainboard/intel/strago/gpio.c +++ b/src/mainboard/intel/strago/gpio.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include "irqroute.h" -#include <soc/gpio.h> +#include <gpio.h> #include <boardid.h> #include "onboard.h" #include "gpio.h" diff --git a/src/mainboard/intel/strago/mainboard.c b/src/mainboard/intel/strago/mainboard.c index 287623e..0ee6892 100644 --- a/src/mainboard/intel/strago/mainboard.c +++ b/src/mainboard/intel/strago/mainboard.c @@ -2,7 +2,7 @@
#include <bootstate.h> #include <device/device.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include "ec.h"
diff --git a/src/mainboard/intel/strago/smihandler.c b/src/mainboard/intel/strago/smihandler.c index e770057..bf9ec4c 100644 --- a/src/mainboard/intel/strago/smihandler.c +++ b/src/mainboard/intel/strago/smihandler.c @@ -11,7 +11,7 @@
#include <soc/nvs.h> #include <soc/pm.h> -#include <soc/gpio.h> +#include <gpio.h>
#include "onboard.h"
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41315 )
Change subject: mb/intel/strago: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324