HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41310 )
Change subject: mb/intel/icelake_rvp: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/intel/icelake_rvp: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: Ib4512a020d99d706461fb9bfc9c9d531c5bbd90b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/icelake_rvp/bootblock.c M src/mainboard/intel/icelake_rvp/mainboard.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/41310/1
diff --git a/src/mainboard/intel/icelake_rvp/bootblock.c b/src/mainboard/intel/icelake_rvp/bootblock.c index a8f7e41..7b0984c 100644 --- a/src/mainboard/intel/icelake_rvp/bootblock.c +++ b/src/mainboard/intel/icelake_rvp/bootblock.c @@ -3,7 +3,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h>
void bootblock_mainboard_init(void) { diff --git a/src/mainboard/intel/icelake_rvp/mainboard.c b/src/mainboard/intel/icelake_rvp/mainboard.c index c8e9e41..7aae1cf 100644 --- a/src/mainboard/intel/icelake_rvp/mainboard.c +++ b/src/mainboard/intel/icelake_rvp/mainboard.c @@ -4,7 +4,7 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <device/device.h> -#include <soc/gpio.h> +#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h>
static void mainboard_init(void *chip_info)
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41310 )
Change subject: mb/intel/icelake_rvp: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324