HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41309 )
Change subject: mb/intel/glkrvp: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/intel/glkrvp: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: Ifcc2ac1cc06a63997ec4742b9d2217c47beb5e30 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/intel/glkrvp/bootblock.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/mainboard.c M src/mainboard/intel/glkrvp/smihandler.c 4 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/41309/1
diff --git a/src/mainboard/intel/glkrvp/bootblock.c b/src/mainboard/intel/glkrvp/bootblock.c index 3e9f51a..4c6eb68 100644 --- a/src/mainboard/intel/glkrvp/bootblock.c +++ b/src/mainboard/intel/glkrvp/bootblock.c @@ -4,7 +4,7 @@ #include <bootblock_common.h> #include <ec/ec.h> #include <intelblocks/lpc_lib.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/ec.h>
void bootblock_mainboard_init(void) diff --git a/src/mainboard/intel/glkrvp/chromeos.c b/src/mainboard/intel/glkrvp/chromeos.c index 5944406..50b912a 100644 --- a/src/mainboard/intel/glkrvp/chromeos.c +++ b/src/mainboard/intel/glkrvp/chromeos.c @@ -5,7 +5,6 @@ #include <ec/google/chromeec/ec.h> #include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> -#include <soc/gpio.h> #include <variant/gpio.h>
void fill_lb_gpios(struct lb_gpios *gpios) diff --git a/src/mainboard/intel/glkrvp/mainboard.c b/src/mainboard/intel/glkrvp/mainboard.c index cfbaf0d..33b692d 100644 --- a/src/mainboard/intel/glkrvp/mainboard.c +++ b/src/mainboard/intel/glkrvp/mainboard.c @@ -7,7 +7,7 @@ #include <device/device.h> #include <ec/ec.h> #include <nhlt.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/nhlt.h> #include <vendorcode/google/chromeos/chromeos.h> #include <variant/ec.h> diff --git a/src/mainboard/intel/glkrvp/smihandler.c b/src/mainboard/intel/glkrvp/smihandler.c index 782d392..74b5f1a 100644 --- a/src/mainboard/intel/glkrvp/smihandler.c +++ b/src/mainboard/intel/glkrvp/smihandler.c @@ -6,7 +6,7 @@ #include <ec/google/chromeec/smm.h> #include <intelblocks/smihandler.h> #include <soc/pm.h> -#include <soc/gpio.h> +#include <gpio.h> #include <variant/ec.h> #include <variant/gpio.h>
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41309 )
Change subject: mb/intel/glkrvp: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324