Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45258 )
Change subject: sb/intel/bd82x6x: Only check device ID in `intel_me_finalize_smm`
......................................................................
sb/intel/bd82x6x: Only check device ID in `intel_me_finalize_smm`
There's no need to compare the vendor ID.
Change-Id: I4368f2615e5ce72430992f1f5581908c90c970f0
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/southbridge/intel/bd82x6x/me.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/45258/1
diff --git a/src/southbridge/intel/bd82x6x/me.c b/src/southbridge/intel/bd82x6x/me.c
index c51cca6..3876b02 100644
--- a/src/southbridge/intel/bd82x6x/me.c
+++ b/src/southbridge/intel/bd82x6x/me.c
@@ -168,16 +168,16 @@
void intel_me_finalize_smm(void)
{
- u32 did = pci_read_config32(PCH_ME_DEV, PCI_VENDOR_ID);
+ u16 did = pci_read_config16(PCH_ME_DEV, PCI_DEVICE_ID);
switch (did) {
- case 0x1c3a8086:
+ case 0x1c3a:
intel_me7_finalize_smm();
break;
- case 0x1e3a8086:
+ case 0x1e3a:
intel_me8_finalize_smm();
break;
default:
- printk(BIOS_ERR, "No finalize handler for ME %08x.\n", did);
+ printk(BIOS_ERR, "No finalize handler for ME %04x.\n", did);
}
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/45258
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4368f2615e5ce72430992f1f5581908c90c970f0
Gerrit-Change-Number: 45258
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48468 )
Change subject: Makefile.inc: Remove the CBNT bootblock flag
......................................................................
Makefile.inc: Remove the CBNT bootblock flag
At the moment this was only used for aligning the bootblock to 64
bytes. At the moment this automatically done with
CONFIG_C_ENV_BOOTBLOCK_SIZE.
Change-Id: I0c879119e525b512eebe3f4c5ff9b2f426c6b6ff
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M Makefile.inc
1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48468/1
diff --git a/Makefile.inc b/Makefile.inc
index 420ce51..d95cb88 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -730,16 +730,6 @@
endif
-ifeq ($(CONFIG_INTEL_CBNT_SUPPORT),y)
-
-CBNTIBB := --cbnt
-
-else
-
-CBNTIBB :=
-
-endif # CONFIG_INTEL_CBNT_SUPPORT
-
ifeq ($(CONFIG_COMPRESS_BOOTBLOCK),y)
$(objcbfs)/bootblock.lz4: $(objcbfs)/bootblock.elf $(objutil)/cbfstool/cbfs-compression-tool
@@ -1081,7 +1071,6 @@
-n bootblock \
-t bootblock \
$(TXTIBB) \
- $(CBNTIBB) \
-b -$(call file-size,$(objcbfs)/bootblock.bin) $(cbfs-autogen-attributes) \
$(TS_OPTIONS)
else # ifeq ($(CONFIG_ARCH_X86),y)
--
To view, visit https://review.coreboot.org/c/coreboot/+/48468
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c879119e525b512eebe3f4c5ff9b2f426c6b6ff
Gerrit-Change-Number: 48468
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: newchange
Frank Chu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47358 )
Change subject: mb/google/volteer: Create drobit variant
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/47358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3dca73dea26c0d267d8e0e725d712f750810b06
Gerrit-Change-Number: 47358
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: abandon
Ken Lu has uploaded a new patch set (#2) to the change originally created by Frank Chu. ( https://review.coreboot.org/c/coreboot/+/48495 )
Change subject: mb/google/volteer: Update drobit device tree
......................................................................
mb/google/volteer: Update drobit device tree
Update drobit device tree override to match schematics.
BUG=b:175351914
BRANCH=none
TEST=emerge-volteer coreboot
Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com>
Change-Id: I48a3024df4270b111b90c4fb56847aad6e65bfa1
---
M src/mainboard/google/volteer/variants/drobit/overridetree.cb
1 file changed, 233 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/48495/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/48495
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48a3024df4270b111b90c4fb56847aad6e65bfa1
Gerrit-Change-Number: 48495
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Ken Lu has uploaded a new patch set (#2) to the change originally created by Frank Chu. ( https://review.coreboot.org/c/coreboot/+/48496 )
Change subject: mb/google/volteer: Update SPD table for drobit
......................................................................
mb/google/volteer: Update SPD table for drobit
drobit memory table as follow:
value Vendor Part number
0x00 MICRON MT53E512M32D2NP-046 WT:E
0x00 HYNIX H9HCNNNBKMMLXR-NEE
0x01 MICRON MT53E1G32D2NP-046 WT:A
0x02 HYNIX H9HCNNNCPMMLXR-NEE
BUG=b:175351914
BRANCH=none
TEST=emerge-volteer coreboot
Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com>
Change-Id: Icd9439f8449856d4ec6798a4e4310dd139bce05f
---
A src/mainboard/google/volteer/variants/drobit/Makefile.inc
A src/mainboard/google/volteer/variants/drobit/memory.c
M src/mainboard/google/volteer/variants/drobit/memory/Makefile.inc
M src/mainboard/google/volteer/variants/drobit/memory/dram_id.generated.txt
A src/mainboard/google/volteer/variants/drobit/memory/mem_list_variant.txt
D src/mainboard/google/volteer/variants/drobit/memory/mem_parts_used.txt
6 files changed, 80 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/48496/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/48496
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd9439f8449856d4ec6798a4e4310dd139bce05f
Gerrit-Change-Number: 48496
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Ken Lu has uploaded a new patch set (#2) to the change originally created by Frank Chu. ( https://review.coreboot.org/c/coreboot/+/48497 )
Change subject: mb/google/volteer: Add GPIO to drobit support
......................................................................
mb/google/volteer: Add GPIO to drobit support
Add support for gpio driver for drobit
BUG=b:175351914
BRANCH=none
TEST=emerge-volteer coreboot
Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com>
Change-Id: I54ba182c6da3db282961b3c72a4d2d11d1001e95
---
M src/mainboard/google/volteer/variants/drobit/Makefile.inc
A src/mainboard/google/volteer/variants/drobit/gpio.c
2 files changed, 188 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/48497/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/48497
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54ba182c6da3db282961b3c72a4d2d11d1001e95
Gerrit-Change-Number: 48497
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset