Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47168
to look at the new patch set (#13).
Change subject: soc/intel/xeon_sp: Lock PAM and SMRAM registers
......................................................................
soc/intel/xeon_sp: Lock PAM and SMRAM registers
The CedarIsland FSP Integration recommends locking down some things.
Change-Id: I72e04b55d69a8da79485e084b39c3bd38504897f
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M src/soc/intel/xeon_sp/cpx/chip.c
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/47168/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/47168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72e04b55d69a8da79485e084b39c3bd38504897f
Gerrit-Change-Number: 47168
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-MessageType: newpatchset
Hello Michał Żygowski, Christian Walter,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/48469
to review the following change.
Change subject: util/cbfstool/fit.c: Add support for adding Boot Guard manifests
......................................................................
util/cbfstool/fit.c: Add support for adding Boot Guard manifests
Change-Id: I8221590cad16cffea3f8b50dd880a77934b78ea8
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
Signed-off-by: Christian Walter <christian.walter(a)9elements.com>
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
---
M util/cbfstool/fit.c
1 file changed, 45 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/48469/1
diff --git a/util/cbfstool/fit.c b/util/cbfstool/fit.c
index 44573ca..63956dd 100644
--- a/util/cbfstool/fit.c
+++ b/util/cbfstool/fit.c
@@ -434,6 +434,43 @@
fit_entry_add_size(&fit->header, sizeof(struct fit_entry));
}
+/*
+ * There can be zero or one FIT_TYPE_BOOT_POLICY entries
+ *
+ * The caller has to provide valid arguments as those aren't verified.
+ */
+static void update_fit_boot_policy_entry(struct fit_table *fit,
+ struct fit_entry *entry,
+ uint64_t boot_policy_addr,
+ uint32_t boot_policy_size)
+{
+ entry->address = boot_policy_addr;
+ entry->type_checksum_valid = FIT_TYPE_BOOT_POLICY;
+ entry->size_reserved = boot_policy_size;
+ entry->version = FIT_TXT_VERSION;
+ entry->checksum = 0;
+ fit_entry_add_size(&fit->header, sizeof(struct fit_entry));
+}
+
+/*
+ * There can be zero or one FIT_TYPE_KEY_MANIFEST entries
+ *
+ * The caller has to provide valid arguments as those aren't verified.
+ */
+static void update_fit_key_manifest_entry(struct fit_table *fit,
+ struct fit_entry *entry,
+ uint64_t key_manifest_addr,
+ uint32_t key_manifest_size)
+{
+ entry->address = key_manifest_addr;
+
+ entry->type_checksum_valid = FIT_TYPE_KEY_MANIFEST;
+ entry->size_reserved = key_manifest_size;
+ entry->version = FIT_TXT_VERSION;
+ entry->checksum = 0;
+ fit_entry_add_size(&fit->header, sizeof(struct fit_entry));
+}
+
/* Special case for ucode CBFS file, as it might contain more than one ucode */
int fit_add_microcode_file(struct fit_table *fit,
struct cbfs_image *image,
@@ -626,10 +663,10 @@
case FIT_TYPE_BIOS_STARTUP:
case FIT_TYPE_BIOS_POLICY:
case FIT_TYPE_TXT_POLICY:
- return 1;
- case FIT_TYPE_TPM_POLICY:
case FIT_TYPE_KEY_MANIFEST:
case FIT_TYPE_BOOT_POLICY:
+ return 1;
+ case FIT_TYPE_TPM_POLICY:
default:
return 0;
}
@@ -684,6 +721,12 @@
case FIT_TYPE_TXT_POLICY:
update_fit_txt_policy_entry(fit, entry, offset);
break;
+ case FIT_TYPE_KEY_MANIFEST:
+ update_fit_key_manifest_entry(fit, entry, offset, len);
+ break;
+ case FIT_TYPE_BOOT_POLICY:
+ update_fit_boot_policy_entry(fit, entry, offset, len);
+ break;
default:
return 1;
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/48469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8221590cad16cffea3f8b50dd880a77934b78ea8
Gerrit-Change-Number: 48469
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: newchange
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45258 )
Change subject: sb/intel/bd82x6x: Only check device ID in `intel_me_finalize_smm`
......................................................................
sb/intel/bd82x6x: Only check device ID in `intel_me_finalize_smm`
There's no need to compare the vendor ID.
Change-Id: I4368f2615e5ce72430992f1f5581908c90c970f0
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/southbridge/intel/bd82x6x/me.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/45258/1
diff --git a/src/southbridge/intel/bd82x6x/me.c b/src/southbridge/intel/bd82x6x/me.c
index c51cca6..3876b02 100644
--- a/src/southbridge/intel/bd82x6x/me.c
+++ b/src/southbridge/intel/bd82x6x/me.c
@@ -168,16 +168,16 @@
void intel_me_finalize_smm(void)
{
- u32 did = pci_read_config32(PCH_ME_DEV, PCI_VENDOR_ID);
+ u16 did = pci_read_config16(PCH_ME_DEV, PCI_DEVICE_ID);
switch (did) {
- case 0x1c3a8086:
+ case 0x1c3a:
intel_me7_finalize_smm();
break;
- case 0x1e3a8086:
+ case 0x1e3a:
intel_me8_finalize_smm();
break;
default:
- printk(BIOS_ERR, "No finalize handler for ME %08x.\n", did);
+ printk(BIOS_ERR, "No finalize handler for ME %04x.\n", did);
}
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/45258
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4368f2615e5ce72430992f1f5581908c90c970f0
Gerrit-Change-Number: 45258
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-MessageType: newchange
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48468 )
Change subject: Makefile.inc: Remove the CBNT bootblock flag
......................................................................
Makefile.inc: Remove the CBNT bootblock flag
At the moment this was only used for aligning the bootblock to 64
bytes. At the moment this automatically done with
CONFIG_C_ENV_BOOTBLOCK_SIZE.
Change-Id: I0c879119e525b512eebe3f4c5ff9b2f426c6b6ff
Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz>
---
M Makefile.inc
1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/48468/1
diff --git a/Makefile.inc b/Makefile.inc
index 420ce51..d95cb88 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -730,16 +730,6 @@
endif
-ifeq ($(CONFIG_INTEL_CBNT_SUPPORT),y)
-
-CBNTIBB := --cbnt
-
-else
-
-CBNTIBB :=
-
-endif # CONFIG_INTEL_CBNT_SUPPORT
-
ifeq ($(CONFIG_COMPRESS_BOOTBLOCK),y)
$(objcbfs)/bootblock.lz4: $(objcbfs)/bootblock.elf $(objutil)/cbfstool/cbfs-compression-tool
@@ -1081,7 +1071,6 @@
-n bootblock \
-t bootblock \
$(TXTIBB) \
- $(CBNTIBB) \
-b -$(call file-size,$(objcbfs)/bootblock.bin) $(cbfs-autogen-attributes) \
$(TS_OPTIONS)
else # ifeq ($(CONFIG_ARCH_X86),y)
--
To view, visit https://review.coreboot.org/c/coreboot/+/48468
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c879119e525b512eebe3f4c5ff9b2f426c6b6ff
Gerrit-Change-Number: 48468
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: newchange
Frank Chu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47358 )
Change subject: mb/google/volteer: Create drobit variant
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/47358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3dca73dea26c0d267d8e0e725d712f750810b06
Gerrit-Change-Number: 47358
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: abandon