Change in coreboot[master]: Kconfig: Show console debug options if loglevel override is set
Marc Jones has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48249 )
Change subject: Kconfig: Show console debug options if loglevel override is set ......................................................................
Kconfig: Show console debug options if loglevel override is set
Show console debug options that would only be available if console SPEW was selected when the override loglevel option is selected.
Change-Id: I2fb22562688d6b0bc9235c9ebe5d427dc2a67767 Signed-off-by: Marc Jones marcjones@sysproconsulting.com --- M src/Kconfig 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/48249/1
diff --git a/src/Kconfig b/src/Kconfig index dc98ca2..b9df3a0 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -905,7 +905,7 @@ # Only visible if debug level is DEBUG (7) or SPEW (8) as it does additional # printk(BIOS_DEBUG, ...) calls. config DEBUG_MALLOC - prompt "Output verbose malloc debug messages" if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8 + prompt "Output verbose malloc debug messages" if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8 || CONSOLE_OVERRIDE_LOGLEVEL bool default n help @@ -917,7 +917,7 @@
# Only visible if DEBUG_SPEW (8) is set. config DEBUG_RESOURCES - bool "Output verbose PCI MEM and IO resource debug messages" if DEFAULT_CONSOLE_LOGLEVEL_8 + bool "Output verbose PCI MEM and IO resource debug messages" if DEFAULT_CONSOLE_LOGLEVEL_8 || CONSOLE_OVERRIDE_LOGLEVEL default n help This option enables additional PCI memory and IO debug messages. @@ -939,7 +939,7 @@ # Only visible if debug level is DEBUG (7) or SPEW (8) as it does additional # printk(BIOS_DEBUG, ...) calls. config REALMODE_DEBUG - prompt "Enable debug messages for option ROM execution" if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8 + prompt "Enable debug messages for option ROM execution" if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8 || CONSOLE_OVERRIDE_LOGLEVEL bool default n depends on PCI_OPTION_ROM_RUN_REALMODE
Hello build bot (Jenkins), Jonathan Zhang, Johnny Lin, Jay Talbott, Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48249
to look at the new patch set (#4).
Change subject: Kconfig: Show console debug options if loglevel override is set ......................................................................
Kconfig: Show console debug options if loglevel override is set
Show console debug options that would only be available if console SPEW was selected when the override loglevel option is selected.
Change-Id: I2fb22562688d6b0bc9235c9ebe5d427dc2a67767 Signed-off-by: Marc Jones marcjones@sysproconsulting.com --- M src/Kconfig 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/48249/4
Jay Talbott has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48249 )
Change subject: Kconfig: Show console debug options if loglevel override is set ......................................................................
Patch Set 4: Code-Review+1
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48249 )
Change subject: Kconfig: Show console debug options if loglevel override is set ......................................................................
Patch Set 5: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48249 )
Change subject: Kconfig: Show console debug options if loglevel override is set ......................................................................
Patch Set 5: Code-Review+2
Marc Jones has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48249 )
Change subject: Kconfig: Show console debug options if loglevel override is set ......................................................................
Kconfig: Show console debug options if loglevel override is set
Show console debug options that would only be available if console SPEW was selected when the override loglevel option is selected.
Change-Id: I2fb22562688d6b0bc9235c9ebe5d427dc2a67767 Signed-off-by: Marc Jones marcjones@sysproconsulting.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48249 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Jonathan Zhang jonzhang@fb.com Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Jay Talbott JayTalbott@sysproconsulting.com --- M src/Kconfig 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Jay Talbott: Looks good to me, but someone else must approve Jonathan Zhang: Looks good to me, approved
diff --git a/src/Kconfig b/src/Kconfig index 77d077f..33065cb 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -905,7 +905,7 @@ # Only visible if debug level is DEBUG (7) or SPEW (8) as it does additional # printk(BIOS_DEBUG, ...) calls. config DEBUG_MALLOC - prompt "Output verbose malloc debug messages" if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8 + prompt "Output verbose malloc debug messages" if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8 || CONSOLE_OVERRIDE_LOGLEVEL bool default n help @@ -917,7 +917,7 @@
# Only visible if DEBUG_SPEW (8) is set. config DEBUG_RESOURCES - bool "Output verbose PCI MEM and IO resource debug messages" if DEFAULT_CONSOLE_LOGLEVEL_8 + bool "Output verbose PCI MEM and IO resource debug messages" if DEFAULT_CONSOLE_LOGLEVEL_8 || CONSOLE_OVERRIDE_LOGLEVEL default n help This option enables additional PCI memory and IO debug messages. @@ -939,7 +939,7 @@ # Only visible if debug level is DEBUG (7) or SPEW (8) as it does additional # printk(BIOS_DEBUG, ...) calls. config REALMODE_DEBUG - prompt "Enable debug messages for option ROM execution" if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8 + prompt "Enable debug messages for option ROM execution" if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8 || CONSOLE_OVERRIDE_LOGLEVEL bool default n depends on PCI_OPTION_ROM_RUN_REALMODE
-
Jay Talbott (Code Review) -
Jonathan Zhang (Code Review)
-
Marc Jones (Code Review)
-
Nico Huber (Code Review)