Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configation for li...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Kevin Chang (Code Review)

20 Nov 2020 20 Nov '20

4:26 a.m.

Kevin Chang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configation for lindar ......................................................................

mb/google/volteer/variant/lindar: Correct IOM port configation for lindar

Correct IOM setting and TCSS AUX setting to fix type C C0 port flip issue.

BUG=b:173093980 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.

Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf --- M src/mainboard/google/volteer/variants/lindar/overridetree.cb 1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/47785/1

diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb index 0c6e8629..49749f4 100644 --- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb +++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb @@ -1,6 +1,9 @@ chip soc/intel/tigerlake register "DdiPort1Hpd" = "0" register "DdiPort2Hpd" = "0" + register "TcssAuxOri" = "1" + register "IomTypeCPortPadCfg[0]" = "0x090E000A" + register "IomTypeCPortPadCfg[1]" = "0x090E000D" # USB Port Config register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0 register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # Type-A / Type-C C1 @@ -109,8 +112,7 @@ chip drivers/intel/pmc_mux/conn register "usb2_port_number" = "9" register "usb3_port_number" = "1" - # SBU is fixed, HSL follows CC - register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" + # SBU & HSL follows CC device generic 0 alias conn0 on end end chip drivers/intel/pmc_mux/conn

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

Kevin Chang (Code Review)

20 Nov 20 Nov

4:46 a.m.

Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configation for lindar ......................................................................

Patch Set 1:

Those patch have dependency, please help review together.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Fri, 20 Nov 2020 03:46:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Caveh Jalali (Code Review)

5:46 a.m.

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configation for lindar ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47785/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47785/1/src/mainboard/google/voltee... PS1, Line 4: register "TcssAuxOri" = "1" please rebase this section on https://review.coreboot.org/c/coreboot/+/47654 it should land very soon.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Fri, 20 Nov 2020 04:46:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chang (Code Review)

10:55 a.m.

Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configation for lindar ......................................................................

Patch Set 1:

Hi Caveh

Because this change have relation chain with below change https://review.coreboot.org/c/coreboot/+/47434/6 we will rebase those change.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Fri, 20 Nov 2020 09:55:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chang (Code Review)

11:37 a.m.

Hello build bot (Jenkins), Caveh Jalali, Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47785

to look at the new patch set (#3).

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configation for lindar ......................................................................

mb/google/volteer/variant/lindar: Correct IOM port configation for lindar

Correct IOM setting and TCSS AUX setting to fix type C C0 port flip issue.

BUG=b:173093980 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.

Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/variants/lindar/overridetree.cb 1 file changed, 4 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/47785/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-MessageType: newpatchset

Paul Menzel (Code Review)

2:12 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configation for lindar ......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/47785/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47785/4//COMMIT_MSG@7 PS4, Line 7: configation configuration

https://review.coreboot.org/c/coreboot/+/47785/4//COMMIT_MSG@7 PS4, Line 7: for lindar It’s already in the prefix.

https://review.coreboot.org/c/coreboot/+/47785/4//COMMIT_MSG@9 PS4, Line 9: port flip issue Can you please elaborate, what the problem is?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Fri, 20 Nov 2020 13:12:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

6:15 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configation for lindar ......................................................................

Patch Set 4:

(3 comments)

https://review.coreboot.org/c/coreboot/+/47785/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47785/4/src/mainboard/google/voltee... PS4, Line 4: 1 IOM_TCSS_PORT_CTRL(0, IOM_TCSS_ORI_NORMAL, IOM_TCSS_MUX_INTERNAL)

https://review.coreboot.org/c/coreboot/+/47785/4/src/mainboard/google/voltee... PS4, Line 5: 0x090E000A IOM_AUX_ORI_BIAS_CTRL(0x0e, 10)

https://review.coreboot.org/c/coreboot/+/47785/4/src/mainboard/google/voltee... PS4, Line 6: 0x090E000D IOM_AUX_ORI_BIAS_CTRL(0x0e, 13)

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 4 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Fri, 20 Nov 2020 17:15:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chang (Code Review)

23 Nov 23 Nov

4:49 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Hello build bot (Jenkins), Caveh Jalali, Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47785

to look at the new patch set (#6).

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

mb/google/volteer/variant/lindar: Correct IOM port configuration

Correct IOM setting and TCSS AUX setting to fix type C C0 port display can't output after flip.

BUG=b:173093980 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/47785/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 6 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Kevin Chang (Code Review)

4:51 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

Patch Set 6:

(3 comments)

Hi Paul

Commit message#7 already updated.

https://review.coreboot.org/c/coreboot/+/47785/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/47785/4//COMMIT_MSG@7 PS4, Line 7: configation

...

configuration

Done

https://review.coreboot.org/c/coreboot/+/47785/4//COMMIT_MSG@7 PS4, Line 7: for lindar

...

It’s already in the prefix.

Done

https://review.coreboot.org/c/coreboot/+/47785/4//COMMIT_MSG@9 PS4, Line 9: port flip issue

...

Can you please elaborate, what the problem is?

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 6 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Mon, 23 Nov 2020 03:51:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Kevin Chang (Code Review)

4:56 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

Patch Set 6:

(3 comments)

Hi Tim

overridetree.cb code change already updated.

https://review.coreboot.org/c/coreboot/+/47785/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47785/4/src/mainboard/google/voltee... PS4, Line 4: 1

...

IOM_TCSS_PORT_CTRL(0, IOM_TCSS_ORI_NORMAL, IOM_TCSS_MUX_INTERNAL)

Done

https://review.coreboot.org/c/coreboot/+/47785/4/src/mainboard/google/voltee... PS4, Line 5: 0x090E000A

...

IOM_AUX_ORI_BIAS_CTRL(0x0e, 10)

Done

https://review.coreboot.org/c/coreboot/+/47785/4/src/mainboard/google/voltee... PS4, Line 6: 0x090E000D

...

IOM_AUX_ORI_BIAS_CTRL(0x0e, 13)

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 6 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Mon, 23 Nov 2020 03:56:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

9:20 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

Patch Set 6:

Hi Kevin, Caveh updated the patch this is based on, see https://review.coreboot.org/c/coreboot/+/47860/1

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 6 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Mon, 23 Nov 2020 20:20:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chang (Code Review)

24 Nov 24 Nov

4:15 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Hello build bot (Jenkins), Caveh Jalali, Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47785

to look at the new patch set (#7).

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

mb/google/volteer/variant/lindar: Correct IOM port configuration

Correct IOM setting and TCSS AUX setting to fix type C C0 port display can't output after flip.

BUG=b:173093980 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/47785/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 7 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Kevin Chang (Code Review)

4:19 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

Patch Set 7:

...

Patch Set 6:

Hi Kevin, Caveh updated the patch this is based on, see https://review.coreboot.org/c/coreboot/+/47860/1

Hi Tim

Updated in "Patchset7", thanks for your remind.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 7 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 24 Nov 2020 03:19:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

8 Dec 8 Dec

11:43 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

Patch Set 9:

Hi Kevin, I apologize, but I understand you're near a factory build and need this in your FW. We're still working on the CL this is based on, so for now it may be better to rebase this on top of master instead, and use this intead:

``` register "IomTypeCPortPadCfg[0]" = "0x090E000A" register "IomTypeCPortPadCfg[1]" = "0x090E000D" ``` in the devicetree.cb. When we figure out the other CL, we'll go back and clean up all of these devicetree files

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 9 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Tue, 08 Dec 2020 22:43:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kevin Chang (Code Review)

9 Dec 9 Dec

3:47 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Hello build bot (Jenkins), Caveh Jalali, Zhuohao Lee,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47785

to look at the new patch set (#11).

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

mb/google/volteer/variant/lindar: Correct IOM port configuration

Correct IOM setting and TCSS AUX setting to fix type C C0 port display can't output after flip.

BUG=b:173093980 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/47785/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 11 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: newpatchset

Kevin Chang (Code Review)

3:49 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Kevin Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

Patch Set 11:

...

Patch Set 9:

Hi Kevin, I apologize, but I understand you're near a factory build and need this in your FW. We're still working on the CL this is based on, so for now it may be better to rebase this on top of master instead, and use this intead:
        register "IomTypeCPortPadCfg[0]" = "0x090E000A"
        register "IomTypeCPortPadCfg[1]" = "0x090E000D"
in the devicetree.cb. When we figure out the other CL, we'll go back and clean up all of these devicetree files

Hi Tim

Updated in "Patchset 11"

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 11 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Comment-Date: Wed, 09 Dec 2020 02:49:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

10:54 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

Patch Set 11: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/47785/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47785/1/src/mainboard/google/voltee... PS1, Line 4: register "TcssAuxOri" = "1"

...

please rebase this section on […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 11 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Wed, 09 Dec 2020 21:54:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Caveh Jalali caveh@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

10:54 p.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

Patch Set 11:

Thanks Kevin!

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 11 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-Comment-Date: Wed, 09 Dec 2020 21:54:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

11 Dec 11 Dec

2:10 a.m.

New subject: Change in coreboot[master]: mb/google/volteer/variant/lindar: Correct IOM port configuration

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47785 )

Change subject: mb/google/volteer/variant/lindar: Correct IOM port configuration ......................................................................

mb/google/volteer/variant/lindar: Correct IOM port configuration

Correct IOM setting and TCSS AUX setting to fix type C C0 port display can't output after flip.

BUG=b:173093980 BRANCH=firmware-volteer-13521.B TEST=Built and booted into OS, test USB function normally.

Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Signed-off-by: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47785 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/variants/lindar/overridetree.cb 1 file changed, 4 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb index 2e0c93b..70e432d 100644 --- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb +++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb @@ -1,6 +1,9 @@ chip soc/intel/tigerlake register "DdiPort1Hpd" = "0" register "DdiPort2Hpd" = "0" + register "TcssAuxOri" = "1" + register "IomTypeCPortPadCfg[0]" = "0x090E000A" + register "IomTypeCPortPadCfg[1]" = "0x090E000D" # USB Port Config register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0 register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # Type-A / Type-C C1 @@ -162,8 +165,7 @@ chip drivers/intel/pmc_mux/conn register "usb2_port_number" = "9" register "usb3_port_number" = "1" - # SBU is fixed, HSL follows CC - register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" + # SBU & HSL follows CC device generic 0 alias conn0 on end end chip drivers/intel/pmc_mux/conn

-- To view, visit https://review.coreboot.org/c/coreboot/+/47785 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf Gerrit-Change-Number: 47785 Gerrit-PatchSet: 12 Gerrit-Owner: Kevin Chang kevin.chang@lcfc.corp-partner.google.com Gerrit-Reviewer: Caveh Jalali caveh@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Alec Wang alec.wang@lcfc.corp-partner.google.com Gerrit-CC: Allen Cheng allen.cheng@lcfc.corp-partner.google.com Gerrit-CC: Jerry2 Huang jerry2.huang@lcfc.corp-partner.google.com Gerrit-CC: Lauren Ting lauren.ting@lcfc.corp-partner.google.com Gerrit-CC: Leo3 Chen leo3.chen@lcfc.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Rasheed Hsueh rasheed.hsueh@lcfc.corp-partner.google.com Gerrit-CC: Sunshine Chao sunshine.chao@lcfc.corp-partner.google.com Gerrit-MessageType: merged

1242

days inactive

1263

days old

coreboot-gerrit@coreboot.org

18 comments

4 participants

tags (0)

participants (4)

Caveh Jalali (Code Review)
Kevin Chang (Code Review)
Paul Menzel (Code Review)
Tim Wawrzynczak (Code Review)