Tim Wawrzynczak submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
mb/google/volteer/variant/lindar: Correct IOM port configuration

Correct IOM setting and TCSS AUX setting to fix type C C0 port display can't output after flip.

BUG=b:173093980
BRANCH=firmware-volteer-13521.B
TEST=Built and booted into OS, test USB function normally.

Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf
Signed-off-by: Kevin Chang <kevin.chang@lcfc.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47785
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
---
M src/mainboard/google/volteer/variants/lindar/overridetree.cb
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
index 2e0c93b..70e432d 100644
--- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb
@@ -1,6 +1,9 @@
chip soc/intel/tigerlake
register "DdiPort1Hpd" = "0"
register "DdiPort2Hpd" = "0"
+ register "TcssAuxOri" = "1"
+ register "IomTypeCPortPadCfg[0]" = "0x090E000A"
+ register "IomTypeCPortPadCfg[1]" = "0x090E000D"
# USB Port Config
register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A0
register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # Type-A / Type-C C1
@@ -162,8 +165,7 @@
chip drivers/intel/pmc_mux/conn
register "usb2_port_number" = "9"
register "usb3_port_number" = "1"
- # SBU is fixed, HSL follows CC
- register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL"
+ # SBU & HSL follows CC
device generic 0 alias conn0 on end
end
chip drivers/intel/pmc_mux/conn

To view, visit change 47785. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I827a2d8a5b01dce412b4170fde0f638670ab8baf
Gerrit-Change-Number: 47785
Gerrit-PatchSet: 12
Gerrit-Owner: Kevin Chang <kevin.chang@lcfc.corp-partner.google.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Alec Wang <alec.wang@lcfc.corp-partner.google.com>
Gerrit-CC: Allen Cheng <allen.cheng@lcfc.corp-partner.google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang@lcfc.corp-partner.google.com>
Gerrit-CC: Lauren Ting <lauren.ting@lcfc.corp-partner.google.com>
Gerrit-CC: Leo3 Chen <leo3.chen@lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh@lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao@lcfc.corp-partner.google.com>
Gerrit-MessageType: merged