Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47963 )
Change subject: Drop many cases of .previous directive use ......................................................................
Drop many cases of .previous directive use
Since most assembly files are no longer concatenated together but built separately, section changes with .previous at the end of the files have become spurious.
Change-Id: I2970eed2b114a53475ba385eec4e97bb7ae7095c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/arch/arm/id.S M src/arch/arm64/id.S M src/arch/ppc64/bootblock.S M src/arch/x86/c_start.S M src/arch/x86/id.S M src/cpu/intel/fit/fit.S 6 files changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47963/1
diff --git a/src/arch/arm/id.S b/src/arch/arm/id.S index 3d3df96..a8f7a79 100644 --- a/src/arch/arm/id.S +++ b/src/arch/arm/id.S @@ -19,4 +19,3 @@ .globl __id_end
__id_end: -.previous diff --git a/src/arch/arm64/id.S b/src/arch/arm64/id.S index 3d3df96..a8f7a79 100644 --- a/src/arch/arm64/id.S +++ b/src/arch/arm64/id.S @@ -19,4 +19,3 @@ .globl __id_end
__id_end: -.previous diff --git a/src/arch/ppc64/bootblock.S b/src/arch/ppc64/bootblock.S index 106c61a..8b66fcd 100644 --- a/src/arch/ppc64/bootblock.S +++ b/src/arch/ppc64/bootblock.S @@ -31,4 +31,3 @@ .globl __id_end
__id_end: -.previous diff --git a/src/arch/x86/c_start.S b/src/arch/x86/c_start.S index c46a45c..a7af64f 100644 --- a/src/arch/x86/c_start.S +++ b/src/arch/x86/c_start.S @@ -235,10 +235,4 @@ # restore rsp, it might not have been 16-byte aligned on entry mov %rdx, %rsp ret - - .previous -.code64 -#else - .previous -.code32 #endif diff --git a/src/arch/x86/id.S b/src/arch/x86/id.S index 798b25d..a7b4be7 100644 --- a/src/arch/x86/id.S +++ b/src/arch/x86/id.S @@ -25,4 +25,3 @@ .globl __id_end
__id_end: -.previous diff --git a/src/cpu/intel/fit/fit.S b/src/cpu/intel/fit/fit.S index 3b7396c..afecacd 100644 --- a/src/cpu/intel/fit/fit.S +++ b/src/cpu/intel/fit/fit.S @@ -6,7 +6,6 @@ fit_pointer: .long fit_table .long 0 -.previous
.section .text .align 16 @@ -29,4 +28,3 @@ .byte 0x7d .fill CONFIG_CPU_INTEL_NUM_FIT_ENTRIES*16 fit_table_end: -.previous
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47963 )
Change subject: Drop many cases of .previous directive use ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47963/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47963/1//COMMIT_MSG@10 PS1, Line 10: section changes with .previous at the : end of the files have become spurious. I guess it's obvious but BUILD_TIMELESS=1 does not change, which might be worth noting?
Hello build bot (Jenkins), Julius Werner, Arthur Heymans, Patrick Rudolph, ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47963
to look at the new patch set (#2).
Change subject: Drop many cases of .previous directive use ......................................................................
Drop many cases of .previous directive use
Since most assembly files are no longer concatenated together but built separately, section changes with .previous at the end of the files have become spurious.
TEST=BUILD_TIMELESS
Change-Id: I2970eed2b114a53475ba385eec4e97bb7ae7095c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/arch/arm/id.S M src/arch/arm64/id.S M src/arch/ppc64/bootblock.S M src/arch/x86/c_start.S M src/arch/x86/id.S M src/cpu/intel/fit/fit.S 6 files changed, 0 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47963/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47963 )
Change subject: Drop many cases of .previous directive use ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47963/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47963/1//COMMIT_MSG@10 PS1, Line 10: section changes with .previous at the : end of the files have become spurious.
I guess it's obvious but BUILD_TIMELESS=1 does not change, which might be worth noting?
I take your word you checked that, I did not.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47963 )
Change subject: Drop many cases of .previous directive use ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47963 )
Change subject: Drop many cases of .previous directive use ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47963/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47963/1//COMMIT_MSG@10 PS1, Line 10: section changes with .previous at the : end of the files have become spurious.
I take your word you checked that, I did not.
Done
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47963 )
Change subject: Drop many cases of .previous directive use ......................................................................
Drop many cases of .previous directive use
Since most assembly files are no longer concatenated together but built separately, section changes with .previous at the end of the files have become spurious.
TEST=BUILD_TIMELESS
Change-Id: I2970eed2b114a53475ba385eec4e97bb7ae7095c Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47963 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/arm/id.S M src/arch/arm64/id.S M src/arch/ppc64/bootblock.S M src/arch/x86/c_start.S M src/arch/x86/id.S M src/cpu/intel/fit/fit.S 6 files changed, 0 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/arch/arm/id.S b/src/arch/arm/id.S index 3d3df96..a8f7a79 100644 --- a/src/arch/arm/id.S +++ b/src/arch/arm/id.S @@ -19,4 +19,3 @@ .globl __id_end
__id_end: -.previous diff --git a/src/arch/arm64/id.S b/src/arch/arm64/id.S index 3d3df96..a8f7a79 100644 --- a/src/arch/arm64/id.S +++ b/src/arch/arm64/id.S @@ -19,4 +19,3 @@ .globl __id_end
__id_end: -.previous diff --git a/src/arch/ppc64/bootblock.S b/src/arch/ppc64/bootblock.S index 106c61a..8b66fcd 100644 --- a/src/arch/ppc64/bootblock.S +++ b/src/arch/ppc64/bootblock.S @@ -31,4 +31,3 @@ .globl __id_end
__id_end: -.previous diff --git a/src/arch/x86/c_start.S b/src/arch/x86/c_start.S index c46a45c..a7af64f 100644 --- a/src/arch/x86/c_start.S +++ b/src/arch/x86/c_start.S @@ -235,10 +235,4 @@ # restore rsp, it might not have been 16-byte aligned on entry mov %rdx, %rsp ret - - .previous -.code64 -#else - .previous -.code32 #endif diff --git a/src/arch/x86/id.S b/src/arch/x86/id.S index 798b25d..a7b4be7 100644 --- a/src/arch/x86/id.S +++ b/src/arch/x86/id.S @@ -25,4 +25,3 @@ .globl __id_end
__id_end: -.previous diff --git a/src/cpu/intel/fit/fit.S b/src/cpu/intel/fit/fit.S index 3b7396c..afecacd 100644 --- a/src/cpu/intel/fit/fit.S +++ b/src/cpu/intel/fit/fit.S @@ -6,7 +6,6 @@ fit_pointer: .long fit_table .long 0 -.previous
.section .text .align 16 @@ -29,4 +28,3 @@ .byte 0x7d .fill CONFIG_CPU_INTEL_NUM_FIT_ENTRIES*16 fit_table_end: -.previous
-
Arthur Heymans (Code Review) -
Hung-Te Lin (Code Review)
-
Kyösti Mälkki (Code Review)