Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47314 )
Change subject: util/intelp2m: Cleanup SCI and SMI macro generation and update comments
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/47314
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie49874d4abbdc7d1a18d63a62ccbce970ce78233
Gerrit-Change-Number: 47314
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 06 Nov 2020 17:55:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46880 )
Change subject: soc/intel/common/block/cse: Add MCHI MCA group functions to cse lib
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46880/1/src/soc/intel/common/block…
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/46880/1/src/soc/intel/common/block…
PS1, Line 53: MCA_COMMIT_FILES 0x04
> I prefer to do it along with CSE FW Sync and avoid resetting multiple times in boot flow.
This operation can only be done when CSE is booting from RW
1. The Set File and Commit file commands are not supported in RO because the MCHI client is only part of CE-RW
2. The Data files created in this operation are part of the RW data region which is deployed only when CSE boots from RW
In order to avoid an extra reset we can make the DAM disabling as part of cse_fw_sync, like below
1. In cse_fw_sync
2. Check if CSE is booted from RO
2.1 if CSE not in RO set next BP to RW
2.2 Check if DAM disable is required by checking board SKU
2.3 if DAM change required then trigger a CSE only reset
2.4 Wait for CSE to boot into RW
2.5 Run Set file and commit file
3. Do global reset
This flow needs to be confirmed, will update if this works
--
To view, visit https://review.coreboot.org/c/coreboot/+/46880
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bdb83daffc291c618f3193b5b4e159c3eff188e
Gerrit-Change-Number: 46880
Gerrit-PatchSet: 2
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Comment-Date: Fri, 06 Nov 2020 17:51:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46901 )
Change subject: security/vboot: Add Kconfig symbol to set hashing block size
......................................................................
security/vboot: Add Kconfig symbol to set hashing block size
Generally, this size probably doesn't matter very much, but in the
case of picasso's psp_verstage, the hash is being calculated by
hardware using relatively expensive system calls. By increasing the
block size, we can save roughly 140ms of boot and resume time.
TEST=Build & boot see that boot time has decreased.
BRANCH=Zork
BUG=b:169217270 - Zork: SHA calculation in vboot takes too long
Signed-off-by: Martin Roth <martinroth(a)chromium.org>
Change-Id: I68eecbbdfadcbf14288dc6e849397724fb66e0b2
---
M src/security/vboot/Kconfig
M src/security/vboot/vboot_logic.c
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/46901/1
diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig
index 094cbb9..024a746 100644
--- a/src/security/vboot/Kconfig
+++ b/src/security/vboot/Kconfig
@@ -369,6 +369,13 @@
hex "Keyblock preamble flags"
default 0x0
+config VBOOT_HASH_BLOCK_SIZE
+ hex
+ default 0x400
+ help
+ Set the default hash size. Generally 1k is reasonable, but in some
+ cases it may improve hashing speed to increase the size.
+
endmenu # Keys
endif # VBOOT
endmenu # Verified Boot (vboot)
diff --git a/src/security/vboot/vboot_logic.c b/src/security/vboot/vboot_logic.c
index dbaa883..54c8224 100644
--- a/src/security/vboot/vboot_logic.c
+++ b/src/security/vboot/vboot_logic.c
@@ -19,8 +19,6 @@
/* The max hash size to expect is for SHA512. */
#define VBOOT_MAX_HASH_SIZE VB2_SHA512_DIGEST_SIZE
-#define TODO_BLOCK_SIZE 1024
-
/* exports */
vb2_error_t vb2ex_read_resource(struct vb2_context *ctx,
@@ -144,7 +142,7 @@
{
uint64_t load_ts;
uint32_t remaining;
- uint8_t block[TODO_BLOCK_SIZE];
+ uint8_t block[CONFIG_VBOOT_HASH_BLOCK_SIZE];
uint8_t hash_digest[VBOOT_MAX_HASH_SIZE];
const size_t hash_digest_sz = sizeof(hash_digest);
size_t block_size = sizeof(block);
--
To view, visit https://review.coreboot.org/c/coreboot/+/46901
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68eecbbdfadcbf14288dc6e849397724fb66e0b2
Gerrit-Change-Number: 46901
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-MessageType: newchange
Ricardo Ribalda has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47303 )
Change subject: eldrid
......................................................................
eldrid
Change-Id: I9b6d12ffd29247e795e1bbf1935b3d49c6cf5c6c
Signed-off-by: Ricardo Ribalda <ribalda(a)chromium.org>
---
M src/mainboard/google/volteer/variants/eldrid/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/47303/1
diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
index a926956..91fbbea 100644
--- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
@@ -227,7 +227,7 @@
chip drivers/usb/acpi
register "desc" = ""USB2 Camera""
register "type" = "UPC_TYPE_INTERNAL"
- # The Linux Kernel does not allow an inverted BOTH_LEVEL irq
+ # The Linux Kernel does not allow an inverted BOTH_EDGE irq
# So we need to use GpioIO() instead of GpioInt()
# https://www.kernel.org/doc/Documentation/acpi/gpio-properties.txt
register "privacy_gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_D4)"
--
To view, visit https://review.coreboot.org/c/coreboot/+/47303
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9b6d12ffd29247e795e1bbf1935b3d49c6cf5c6c
Gerrit-Change-Number: 47303
Gerrit-PatchSet: 1
Gerrit-Owner: Ricardo Ribalda <ribalda(a)chromium.org>
Gerrit-MessageType: newchange
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46842 )
Change subject: soc/intel/jasperlake: Correct GPIO pad sequence for community pad group
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/46842
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6013914c88c50f4b8c60ca9a9285a8e1b214d11
Gerrit-Change-Number: 46842
Gerrit-PatchSet: 11
Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Aamir Bohra <aamir.bohra(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Fri, 06 Nov 2020 17:39:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment