Change in coreboot[master]: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Chen Wisley (Code Review)

30 Oct 2020 30 Oct '20

1:05 p.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47018 )

Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................

mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi

BUG=b:170604353 TEST=emerge-volteer coreboot

Signed-off-by: Wisley Chen wisley.chen@quantatw.com Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/47018/1

diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index f59d82b..23e27ca 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -71,3 +71,4 @@ config BOARD_GOOGLE_ELEMI bool "-> Elemi" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select USE_CAR_NEM_ENHANCED_V2

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Tim Wawrzynczak (Code Review)

30 Oct 30 Oct

10:37 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )

Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f Gerrit-Change-Number: 47018 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 30 Oct 2020 22:37:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

2 Nov 2 Nov

6:10 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )

Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................

Patch Set 1:

needs a rebase

-- To view, visit https://review.coreboot.org/c/coreboot/+/47018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f Gerrit-Change-Number: 47018 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 02 Nov 2020 18:10:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Arthur Heymans (Code Review)

7:30 p.m.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )

Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................

Patch Set 1:

Why is CAR code board variant specific?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f Gerrit-Change-Number: 47018 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-Comment-Date: Mon, 02 Nov 2020 19:30:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

7:56 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )

Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................

Patch Set 1:

...

Patch Set 1:

Why is CAR code board variant specific?

Si revision + its associated ucode

-- To view, visit https://review.coreboot.org/c/coreboot/+/47018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f Gerrit-Change-Number: 47018 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-Comment-Date: Mon, 02 Nov 2020 19:56:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Chen Wisley (Code Review)

3 Nov 3 Nov

10:09 a.m.

Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47018

to look at the new patch set (#2).

Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................

mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi

BUG=b:170604353 TEST=emerge-volteer coreboot

Signed-off-by: Wisley Chen wisley.chen@quantatw.com Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/47018/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f Gerrit-Change-Number: 47018 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: newpatchset

Chen Wisley (Code Review)

12:05 p.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )

Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................

Patch Set 2:

...

Patch Set 1:

needs a rebase

done

-- To view, visit https://review.coreboot.org/c/coreboot/+/47018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f Gerrit-Change-Number: 47018 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-Comment-Date: Tue, 03 Nov 2020 12:05:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:53 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )

Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f Gerrit-Change-Number: 47018 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-Comment-Date: Tue, 03 Nov 2020 17:53:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Chen Wisley (Code Review)

6 Nov 6 Nov

4:15 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47018 )

Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................

Patch Set 2:

Hi Tim,

Could you help to merge and cherry-pick to chromeos-2016.05?

Thanks

-- To view, visit https://review.coreboot.org/c/coreboot/+/47018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f Gerrit-Change-Number: 47018 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-Comment-Date: Fri, 06 Nov 2020 04:15:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

6:35 p.m.

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47018 )

Change subject: mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi ......................................................................

mb/google/variant/elemi: Select USE_CAR_NEM_ENHANCED_V2 for elemi

BUG=b:170604353 TEST=emerge-volteer coreboot

Signed-off-by: Wisley Chen wisley.chen@quantatw.com Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f Reviewed-on: https://review.coreboot.org/c/coreboot/+/47018 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index d8f1b44..8f966ee 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -80,6 +80,7 @@ config BOARD_GOOGLE_ELEMI bool "-> Elemi" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select USE_CAR_NEM_ENHANCED_V2

config BOARD_GOOGLE_VOEMA bool "-> Voema"

-- To view, visit https://review.coreboot.org/c/coreboot/+/47018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1a1ab6f3d57d5023523b85bfb00d48d8b70a6c1f Gerrit-Change-Number: 47018 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Arthur Heymans arthur@aheymans.xyz Gerrit-MessageType: merged

1290

days inactive

1297

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

Arthur Heymans (Code Review)
Chen Wisley (Code Review)
Tim Wawrzynczak (Code Review)