Change in coreboot[master]: mb/google/variant/elemi: config CSE LITE

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Chen Wisley (Code Review)

30 Oct 2020 30 Oct '20

10:14 a.m.

Chen Wisley has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47019 )

Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................

mb/google/variant/elemi: config CSE LITE

Config elemi to use CSE LITE

BUG=b:170604353 TEST=emerge-volteer coreboot

Change-Id: I31c7a743645d6a34ee34e750ba92c108b306ee09 Signed-off-by: Wisley Chen wisley.chen@quantatw.com --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/47019/1

diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 23e27ca..908c55b 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -71,4 +71,5 @@ config BOARD_GOOGLE_ELEMI bool "-> Elemi" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU select USE_CAR_NEM_ENHANCED_V2

Attachments:

attachment.htm (text/html — 2.3 KB)

Show replies by date

Furquan Shaikh (Code Review)

30 Oct 30 Oct

12:56 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47019 )

Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... PS1, Line 74: SOC_INTEL_CSE_LITE_SKU Looking at the list of boards here, I think SOC_INTEL_CSE_LITE_SKU is now being selected for all boards except boldar (which I think should also be using Lite SKU).

Tim/Nick - any reason not to move this selection under BOARD_GOOGLE_BASEBOARD_VOLTEER in Kconfig instead of having each board select it?

-- To view, visit https://review.coreboot.org/c/coreboot/+/47019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31c7a743645d6a34ee34e750ba92c108b306ee09 Gerrit-Change-Number: 47019 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Fri, 30 Oct 2020 15:56:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

2 Nov 2 Nov

3:11 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47019 )

Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... PS1, Line 74: SOC_INTEL_CSE_LITE_SKU

...

Looking at the list of boards here, I think SOC_INTEL_CSE_LITE_SKU is now being selected for all boa […]

At this point, that probably makes sense.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31c7a743645d6a34ee34e750ba92c108b306ee09 Gerrit-Change-Number: 47019 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Mon, 02 Nov 2020 18:11:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

3 Nov 3 Nov

2:54 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47019 )

Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................

Patch Set 2: Code-Review+2

Let's just keep this one in Wisley's stack, and I'll come back and do the Kconfig refactor in another patch.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31c7a743645d6a34ee34e750ba92c108b306ee09 Gerrit-Change-Number: 47019 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Tue, 03 Nov 2020 17:54:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Chen Wisley (Code Review)

4 Nov 4 Nov

8:39 a.m.

Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47019 )

Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/47019/1/src/mainboard/google/voltee... PS1, Line 74: SOC_INTEL_CSE_LITE_SKU

...

At this point, that probably makes sense.

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/47019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31c7a743645d6a34ee34e750ba92c108b306ee09 Gerrit-Change-Number: 47019 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-Comment-Date: Wed, 04 Nov 2020 11:39:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

6 Nov 6 Nov

3:35 p.m.

Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47019 )

Change subject: mb/google/variant/elemi: config CSE LITE ......................................................................

mb/google/variant/elemi: config CSE LITE

Config elemi to use CSE LITE

BUG=b:170604353 TEST=emerge-volteer coreboot

Change-Id: I31c7a743645d6a34ee34e750ba92c108b306ee09 Signed-off-by: Wisley Chen wisley.chen@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47019 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/Kconfig.name 1 file changed, 1 insertion(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved

diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index 8f966ee..6c9248e 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -80,6 +80,7 @@ config BOARD_GOOGLE_ELEMI bool "-> Elemi" select BOARD_GOOGLE_BASEBOARD_VOLTEER + select SOC_INTEL_CSE_LITE_SKU select USE_CAR_NEM_ENHANCED_V2

config BOARD_GOOGLE_VOEMA

-- To view, visit https://review.coreboot.org/c/coreboot/+/47019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I31c7a743645d6a34ee34e750ba92c108b306ee09 Gerrit-Change-Number: 47019 Gerrit-PatchSet: 3 Gerrit-Owner: Chen Wisley wisley.chen@quantatw.com Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Furquan Shaikh furquan@google.com Gerrit-MessageType: merged

1298

days inactive

1305

days old

coreboot-gerrit@coreboot.org

5 comments

3 participants

tags (0)

participants (3)

Chen Wisley (Code Review)
Furquan Shaikh (Code Review)
Tim Wawrzynczak (Code Review)