Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31934 )
Change subject: util/sconfig: Emit array of PNP UART devices
......................................................................
Patch Set 5:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31934
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9330bcd5545ec3f94c1c14ed4a639f1ef0548e43
Gerrit-Change-Number: 31934
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 01 Jul 2019 03:34:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31933 )
Change subject: util/sconfig: Expose usable PCI and PNP device names
......................................................................
Patch Set 5:
To make use of this. extern declarations in .h file will be needed. Should I continue with this idea?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31933
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I711058f5c809fa9bc7ea4333aaebad6847ebdfd4
Gerrit-Change-Number: 31933
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 01 Jul 2019 03:33:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31932 )
Change subject: util/sconfig: Add commonlib/helpers.h
......................................................................
Patch Set 5:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31932
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbcaa1b613aef312d3876e8b536499a9f01a8d19
Gerrit-Change-Number: 31932
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 01 Jul 2019 03:32:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31931 )
Change subject: util/sconfig: Declare the repeated devicetree storage
......................................................................
Patch Set 5:
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/31931/4/util/sconfig/main.c
File util/sconfig/main.c:
https://review.coreboot.org/#/c/31931/4/util/sconfig/main.c@932
PS4, Line 932: static
> so everything is now static all the time?
The names are nonsense and not referenced outside the generated static.c, so 'static' currently makes sense?
My longterm plan would be to encode PCI BDF in the names such that early stages resolve node addresses at build-time. This allows dropping the topology links and lets garbage collection to optimise the size for stages other than ramstage.
Experiments show that passing struct *device is as efficient, and sometimes better, than pci_devfn_t in romstage. I'd like to deprecate __SIMPLE_DEVICE__.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31931
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4cb9e75f179f44edf4f8256ad8320bc2d4ae71a
Gerrit-Change-Number: 31931
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Comment-Date: Mon, 01 Jul 2019 03:31:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-MessageType: comment