Change in ...coreboot[master]: intel/basecode/fw_update: Add ELOG events to ucode update
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29357 )
Change subject: intel/basecode/fw_update: Add ELOG events to ucode update ......................................................................
Patch Set 17:
(4 comments)
https://review.coreboot.org/#/c/29357/17/src/soc/intel/common/basecode/fw_up... File src/soc/intel/common/basecode/fw_update/elog.h:
https://review.coreboot.org/#/c/29357/17/src/soc/intel/common/basecode/fw_up... PS17, Line 21: * @current : Current microcode revision. Please remove the dot/period at the end.
https://review.coreboot.org/#/c/29357/17/src/soc/intel/common/basecode/fw_up... PS17, Line 24: Update update
https://review.coreboot.org/#/c/29357/17/src/soc/intel/common/basecode/fw_up... PS17, Line 26: * return 0 on success, -1 on failure. Please use CB_SUCCESS and friends.
https://review.coreboot.org/#/c/29357/17/src/soc/intel/common/basecode/fw_up... File src/soc/intel/common/basecode/fw_update/elog.c:
https://review.coreboot.org/#/c/29357/17/src/soc/intel/common/basecode/fw_up... PS17, Line 18: #include "elog.h" Both are needed?
-
Paul Menzel (Code Review)