View Change

4 comments:

• File src/soc/intel/common/basecode/fw_update/elog.h:

  • Patch Set #17, Line 21: * @current : Current microcode revision.

    Please remove the dot/period at the end.

  • Patch Set #17, Line 24: Update

    update

  • Patch Set #17, Line 26: * return 0 on success, -1 on failure.

    Please use CB_SUCCESS and friends.

• File src/soc/intel/common/basecode/fw_update/elog.c:

  • Patch Set #17, Line 18: #include "elog.h"

    Both are needed?

To view, visit change 29357. To unsubscribe, or for help writing mail filters, visit settings.