coreboot-gerrit October 2019

coreboot-gerrit@coreboot.org

1 participants
1921 discussions

Change in coreboot[master]: acpi_table_header: Replace hard-code length via sizeof(acpi_fadt_t)
by Name of user not set (Code Review) 09 Oct '19

09 Oct '19

Name of user not set #1002476 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35540 ) Change subject: acpi_table_header: Replace hard-code length via sizeof(acpi_fadt_t) ...................................................................... acpi_table_header: Replace hard-code length via sizeof(acpi_fadt_t) Minimize use of hard code value for acpi_table_header->length to soft code. Replace length of acpi_header_t with sizeof(acpi_fadt_t). Change-Id: Ibcae72e8f02497719fcd3f180838557e8e9abd38 Signed-off-by: Himanshu Sahdev <himanshusah(a)hcl.com> --- M src/mainboard/amd/serengeti_cheetah_fam10/fadt.c M src/southbridge/amd/sb700/fadt.c M src/southbridge/amd/sb800/fadt.c M src/southbridge/intel/i82371eb/fadt.c 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/35540/1 diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c b/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c index 845af71..9f6d48c 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c +++ b/src/mainboard/amd/serengeti_cheetah_fam10/fadt.c @@ -35,7 +35,7 @@ /* Prepare the header */ memset((void *)fadt,0,sizeof(acpi_fadt_t)); memcpy(header->signature,"FACP",4); - header->length = 244; + header->length = sizeof(acpi_fadt_t); header->revision = get_acpi_table_revision(FADT); memcpy(header->oem_id,OEM_ID,6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); diff --git a/src/southbridge/amd/sb700/fadt.c b/src/southbridge/amd/sb700/fadt.c index 4a5746c..c81e644 100644 --- a/src/southbridge/amd/sb700/fadt.c +++ b/src/southbridge/amd/sb700/fadt.c @@ -36,7 +36,7 @@ /* Prepare the header */ memset((void *)fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); - header->length = 244; + header->length = sizeof(acpi_fadt_t); header->revision = get_acpi_table_revision(FADT); memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); diff --git a/src/southbridge/amd/sb800/fadt.c b/src/southbridge/amd/sb800/fadt.c index 71bdf23..acda6db 100644 --- a/src/southbridge/amd/sb800/fadt.c +++ b/src/southbridge/amd/sb800/fadt.c @@ -36,7 +36,7 @@ /* Prepare the header */ memset((void *)fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); - header->length = 244; + header->length = sizeof(acpi_fadt_t); header->revision = get_acpi_table_revision(FADT); memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c index 26a1570..9e43e62 100644 --- a/src/southbridge/intel/i82371eb/fadt.c +++ b/src/southbridge/intel/i82371eb/fadt.c @@ -38,7 +38,7 @@ memset((void *) fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); - header->length = 244; + header->length = sizeof(acpi_fadt_t); header->revision = ACPI_FADT_REV_ACPI_1_0; memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); -- To view, visit https://review.coreboot.org/c/coreboot/+/35540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibcae72e8f02497719fcd3f180838557e8e9abd38 Gerrit-Change-Number: 35540 Gerrit-PatchSet: 1 Gerrit-Owner: Name of user not set #1002476 Gerrit-MessageType: newchange

5 11

Change in coreboot[master]: mb/google/hatch: Set FPS as wake source
by Shelley Chen (Code Review) 09 Oct '19

09 Oct '19

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35903 ) Change subject: mb/google/hatch: Set FPS as wake source ...................................................................... mb/google/hatch: Set FPS as wake source BUG=b:142131099 BRANCH=None TEST=powerd_dbus_suspend, ensure DUT in S0ix touch fp sensor and ensure DUT wakes up in S0 Change-Id: If57094aa1076d79ac0886b71fa5532411bfeb45f Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/mainboard/google/hatch/variants/baseboard/gpio.c M src/mainboard/google/hatch/variants/dratini/overridetree.cb M src/mainboard/google/hatch/variants/hatch/overridetree.cb M src/mainboard/google/hatch/variants/helios/overridetree.cb M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 5 files changed, 9 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/35903/1 diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 240bb5d..f8df447 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -59,7 +59,7 @@ /* A22 : FPMCU_PCH_BOOT0 */ PAD_CFG_GPO(GPP_A22, 0, DEEP), /* A23 : FPMCU_PCH_INT_ODL */ - PAD_CFG_GPI_APIC(GPP_A23, NONE, PLTRST, LEVEL, INVERT), + PAD_CFG_GPI_IRQ_WAKE(GPP_A23, NONE, PLTRST, LEVEL, INVERT), /* B0 : CORE_VID0 */ PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 65649d1..1af822d4 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -140,7 +140,8 @@ register "hid" = "ACPI_DT_NAMESPACE_HID" register "uid" = "1" register "compat_string" = ""google,cros-ec-spi"" - register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A23_IRQ)" + register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_A23_IRQ)" + register "wake" = "GPE0_DW0_23" device spi 1 on end end # FPMCU end # GSPI #1 diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb index df2cc38..bc6aa11 100644 --- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb +++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb @@ -171,7 +171,8 @@ register "hid" = "ACPI_DT_NAMESPACE_HID" register "uid" = "1" register "compat_string" = ""google,cros-ec-spi"" - register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A23_IRQ)" + register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_A23_IRQ)" + register "wake" = "GPE0_DW0_23" device spi 1 on end end # FPMCU end # GSPI #1 diff --git a/src/mainboard/google/hatch/variants/helios/overridetree.cb b/src/mainboard/google/hatch/variants/helios/overridetree.cb index 8ca878d..0902340 100644 --- a/src/mainboard/google/hatch/variants/helios/overridetree.cb +++ b/src/mainboard/google/hatch/variants/helios/overridetree.cb @@ -180,7 +180,8 @@ register "hid" = "ACPI_DT_NAMESPACE_HID" register "uid" = "1" register "compat_string" = ""google,cros-ec-spi"" - register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A23_IRQ)" + register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_A23_IRQ)" + register "wake" = "GPE0_DW0_23" device spi 1 on end end # FPMCU end # GSPI #1 diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 37914fa..bd60973 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -238,7 +238,8 @@ register "hid" = "ACPI_DT_NAMESPACE_HID" register "uid" = "1" register "compat_string" = ""google,cros-ec-spi"" - register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A23_IRQ)" + register "irq" = "ACPI_IRQ_WAKE_LEVEL_LOW(GPP_A23_IRQ)" + register "wake" = "GPE0_DW0_23" device spi 1 on end end # FPMCU end # GSPI #1 -- To view, visit https://review.coreboot.org/c/coreboot/+/35903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If57094aa1076d79ac0886b71fa5532411bfeb45f Gerrit-Change-Number: 35903 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: newchange

3 5

Change in coreboot[master]: mb/google/glados: port to FSP 2.0
by Matt DeVillier (Code Review) 09 Oct '19

09 Oct '19

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35921 ) Change subject: mb/google/glados: port to FSP 2.0 ...................................................................... Patch Set 3: (3 comments) tested functional on google/chell with default FSP/GOP display init and Tianocore payload https://review.coreboot.org/c/coreboot/+/35921/3//COMMIT_MSG Commit Message: https://review.coreboot.org/c/coreboot/+/35921/3//COMMIT_MSG@18 PS3, Line 18: - set FSP board type to "mobile" this is being set to BOARD_TYPE_ULT_ULX at SoC level, why do we want to override? what are consequences to FSP? https://review.coreboot.org/c/coreboot/+/35921/3//COMMIT_MSG@19 PS3, Line 19: - add FSP parameter DmiVc1 (see TODO) this doesn't seem necessary (at least on chell), so def need better understanding on its addition given so few other boards use it https://review.coreboot.org/c/coreboot/+/35921/3//COMMIT_MSG@23 PS3, Line 23: - loadline values in devicetree maybe can dropped again, as Maxim is : working on adding missing loadline values in CB:35167 I would recommend dropping them and simply rebasing your patchset on top of that change, no reason to duplicate work just to drop later -- To view, visit https://review.coreboot.org/c/coreboot/+/35921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0 Gerrit-Change-Number: 35921 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Oct 2019 21:48:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/glados: port to FSP 2.0
by Michael Niewöhner (Code Review) 09 Oct '19

09 Oct '19

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35921 ) Change subject: mb/google/glados: port to FSP 2.0 ...................................................................... Uploaded patch set 3: Commit message was updated. -- To view, visit https://review.coreboot.org/c/coreboot/+/35921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0 Gerrit-Change-Number: 35921 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Oct 2019 21:13:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/glados: port to FSP 2.0
by Michael Niewöhner (Code Review) 09 Oct '19

09 Oct '19

Hello Patrick Rudolph, Matt DeVillier, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/35921 to look at the new patch set (#3). Change subject: mb/google/glados: port to FSP 2.0 ...................................................................... mb/google/glados: port to FSP 2.0 This patch is part of the patch series to drop support for FSP 1.1 in soc/intel/skylake. The following modifications have been done to migrate the board(s) from FSP 1.1 to FSP 2.0: - remove deprecated devicetree VR_RING domain (only 4 domains in FSP 2.0) - add AC/DC loadline values to devicetree (see TODO) - switch to using the FSP default VBT - set FSP board type to "mobile" - add FSP parameter DmiVc1 (see TODO) TODO: - check loadline values again - loadline values in devicetree maybe can dropped again, as Maxim is working on adding missing loadline values in CB:35167 - find out why some boards set DmiVc1 - testing Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/glados/Kconfig M src/mainboard/google/glados/ramstage.c M src/mainboard/google/glados/romstage.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/glados/spd/spd_util.h D src/mainboard/google/glados/variants/asuka/data.vbt M src/mainboard/google/glados/variants/asuka/devicetree.cb M src/mainboard/google/glados/variants/asuka/variant.c M src/mainboard/google/glados/variants/baseboard/include/baseboard/variant.h D src/mainboard/google/glados/variants/caroline/data.vbt M src/mainboard/google/glados/variants/caroline/devicetree.cb M src/mainboard/google/glados/variants/caroline/variant.c D src/mainboard/google/glados/variants/cave/data.vbt M src/mainboard/google/glados/variants/cave/devicetree.cb M src/mainboard/google/glados/variants/cave/variant.c D src/mainboard/google/glados/variants/chell/data.vbt M src/mainboard/google/glados/variants/chell/devicetree.cb M src/mainboard/google/glados/variants/chell/variant.c M src/mainboard/google/glados/variants/glados/devicetree.cb M src/mainboard/google/glados/variants/glados/variant.c D src/mainboard/google/glados/variants/lars/data.vbt M src/mainboard/google/glados/variants/lars/devicetree.cb M src/mainboard/google/glados/variants/lars/variant.c D src/mainboard/google/glados/variants/sentry/data.vbt M src/mainboard/google/glados/variants/sentry/devicetree.cb M src/mainboard/google/glados/variants/sentry/variant.c 26 files changed, 269 insertions(+), 308 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/35921/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/35921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0 Gerrit-Change-Number: 35921 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/glados: port to FSP 2.0
by build bot (Jenkins) (Code Review) 09 Oct '19

09 Oct '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35921 ) Change subject: mb/google/glados: port to FSP 2.0 ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/35921/2/src/mainboard/google/glado… File src/mainboard/google/glados/romstage.c: https://review.coreboot.org/c/coreboot/+/35921/2/src/mainboard/google/glado… PS2, Line 35: const FSPM_ARCH_UPD *arch_upd = &mupd->FspmArchUpd; need consistent spacing around '*' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/35921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0 Gerrit-Change-Number: 35921 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Oct 2019 21:12:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/glados: port to FSP 2.0
by Michael Niewöhner (Code Review) 09 Oct '19

09 Oct '19

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35921 ) Change subject: mb/google/glados: port to FSP 2.0 ...................................................................... Uploaded patch set 2. (1 comment) https://review.coreboot.org/c/coreboot/+/35921/1/src/mainboard/google/glado… File src/mainboard/google/glados/Kconfig: https://review.coreboot.org/c/coreboot/+/35921/1/src/mainboard/google/glado… PS1, Line 23: select MAINBOARD_HAS_LIBGFXINIT > we don't want to add this without the required libgfxinit file and makefile change, or before the cu […] removed, as discussed on IRC; will be added in a later libgfxinit commit -- To view, visit https://review.coreboot.org/c/coreboot/+/35921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0 Gerrit-Change-Number: 35921 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Oct 2019 21:11:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/glados: port to FSP 2.0
by Michael Niewöhner (Code Review) 09 Oct '19

09 Oct '19

Hello Patrick Rudolph, Matt DeVillier, Paul Menzel, build bot (Jenkins), Nico Huber, Patrick Georgi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/35921 to look at the new patch set (#2). Change subject: mb/google/glados: port to FSP 2.0 ...................................................................... mb/google/glados: port to FSP 2.0 This patch is part of the patch series to drop support for FSP 1.1 in soc/intel/skylake. The following modifications have been done to migrate the board(s) from FSP 1.1 to FSP 2.0: - remove deprecated devicetree VR_RING domain (only 4 domains in FSP 2.0) - add AC/DC loadline values to devicetree (see TODO) - switch to using the FSP default VBT - enable libgfxinit support - set FSP board type to "mobile" - add FSP parameter DmiVc1 (see TODO) TODO: - check loadline values again - loadline values in devicetree maybe can dropped again, as Maxim is working on adding missing loadline values in CB:35167 - find out why some boards set DmiVc1 - testing Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0 Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/google/glados/Kconfig M src/mainboard/google/glados/ramstage.c M src/mainboard/google/glados/romstage.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/glados/spd/spd_util.h D src/mainboard/google/glados/variants/asuka/data.vbt M src/mainboard/google/glados/variants/asuka/devicetree.cb M src/mainboard/google/glados/variants/asuka/variant.c M src/mainboard/google/glados/variants/baseboard/include/baseboard/variant.h D src/mainboard/google/glados/variants/caroline/data.vbt M src/mainboard/google/glados/variants/caroline/devicetree.cb M src/mainboard/google/glados/variants/caroline/variant.c D src/mainboard/google/glados/variants/cave/data.vbt M src/mainboard/google/glados/variants/cave/devicetree.cb M src/mainboard/google/glados/variants/cave/variant.c D src/mainboard/google/glados/variants/chell/data.vbt M src/mainboard/google/glados/variants/chell/devicetree.cb M src/mainboard/google/glados/variants/chell/variant.c M src/mainboard/google/glados/variants/glados/devicetree.cb M src/mainboard/google/glados/variants/glados/variant.c D src/mainboard/google/glados/variants/lars/data.vbt M src/mainboard/google/glados/variants/lars/devicetree.cb M src/mainboard/google/glados/variants/lars/variant.c D src/mainboard/google/glados/variants/sentry/data.vbt M src/mainboard/google/glados/variants/sentry/devicetree.cb M src/mainboard/google/glados/variants/sentry/variant.c 26 files changed, 269 insertions(+), 308 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/35921/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/35921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0 Gerrit-Change-Number: 35921 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/glados: port to FSP 2.0
by Matt DeVillier (Code Review) 09 Oct '19

09 Oct '19

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35921 ) Change subject: mb/google/glados: port to FSP 2.0 ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/35921/1/src/mainboard/google/glado… File src/mainboard/google/glados/Kconfig: https://review.coreboot.org/c/coreboot/+/35921/1/src/mainboard/google/glado… PS1, Line 23: select MAINBOARD_HAS_LIBGFXINIT we don't want to add this without the required libgfxinit file and makefile change, or before the current CDCLK changes are merged in -- To view, visit https://review.coreboot.org/c/coreboot/+/35921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0 Gerrit-Change-Number: 35921 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Oct 2019 21:03:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/glados: port to FSP 2.0
by build bot (Jenkins) (Code Review) 09 Oct '19

09 Oct '19

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35921 ) Change subject: mb/google/glados: port to FSP 2.0 ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/c/coreboot/+/35921/1/src/mainboard/google/glado… File src/mainboard/google/glados/romstage.c: https://review.coreboot.org/c/coreboot/+/35921/1/src/mainboard/google/glado… PS1, Line 35: const FSPM_ARCH_UPD *arch_upd = &mupd->FspmArchUpd; need consistent spacing around '*' (ctx:WxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/35921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id747ef484dfdcb2d346f817976f52073912468d0 Gerrit-Change-Number: 35921 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Niewöhner Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 09 Oct 2019 20:47:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2019