Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35921 )
Change subject: mb/google/glados: port to FSP 2.0 ......................................................................
Patch Set 3:
(3 comments)
tested functional on google/chell with default FSP/GOP display init and Tianocore payload
https://review.coreboot.org/c/coreboot/+/35921/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35921/3//COMMIT_MSG@18 PS3, Line 18: - set FSP board type to "mobile" this is being set to BOARD_TYPE_ULT_ULX at SoC level, why do we want to override? what are consequences to FSP?
https://review.coreboot.org/c/coreboot/+/35921/3//COMMIT_MSG@19 PS3, Line 19: - add FSP parameter DmiVc1 (see TODO) this doesn't seem necessary (at least on chell), so def need better understanding on its addition given so few other boards use it
https://review.coreboot.org/c/coreboot/+/35921/3//COMMIT_MSG@23 PS3, Line 23: - loadline values in devicetree maybe can dropped again, as Maxim is : working on adding missing loadline values in CB:35167 I would recommend dropping them and simply rebasing your patchset on top of that change, no reason to duplicate work just to drop later
-
Matt DeVillier (Code Review)