tested functional on google/chell with default FSP/GOP display init and Tianocore payload
3 comments:
Patch Set #3, Line 18: - set FSP board type to "mobile"
this is being set to BOARD_TYPE_ULT_ULX at SoC level, why do we want to override? what are consequences to FSP?
Patch Set #3, Line 19: - add FSP parameter DmiVc1 (see TODO)
this doesn't seem necessary (at least on chell), so def need better understanding on its addition given so few other boards use it
- loadline values in devicetree maybe can dropped again, as Maxim is
working on adding missing loadline values in CB:35167
I would recommend dropping them and simply rebasing your patchset on top of that change, no reason to duplicate work just to drop later
To view, visit change 35921. To unsubscribe, or for help writing mail filters, visit settings.