Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29361 )
Change subject: mb/google/poppy/variant/nocturne: adjust RcompTarget to fix DRAM corruption
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29361/1/src/mainboard/google/poppy/variants…
File src/mainboard/google/poppy/variants/nocturne/memory.c:
https://review.coreboot.org/#/c/29361/1/src/mainboard/google/poppy/variants…
PS1, Line 36: 30
Does this value work for both KBL and AML? Was this change validated on all the different Nocturne SKUs?
--
To view, visit https://review.coreboot.org/29361
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefc3957f915a39a47ad6018459e65b70d1b34091
Gerrit-Change-Number: 29361
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 19:09:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Nick Vaccaro has abandoned this change. ( https://review.coreboot.org/29360 )
Change subject: mb/google/poppy: adjust RcompTarget to fix DRAM corruption
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/29360
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I7404b1fba3cd859b714e772287ee74be6d53dd30
Gerrit-Change-Number: 29360
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/29343 )
Change subject: soc/amd/stoneyridge: Set IOMMU support to follow device setting
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/29343
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cfd6c81f47de23c54a49ec7cf87b219215ced5e
Gerrit-Change-Number: 29343
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 18:51:11 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29343 )
Change subject: soc/amd/stoneyridge: Set IOMMU support to follow device setting
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29343/2/src/soc/amd/common/block/pi/agesawr…
File src/soc/amd/common/block/pi/agesawrapper.c:
https://review.coreboot.org/#/c/29343/2/src/soc/amd/common/block/pi/agesawr…
PS2, Line 329: LateParams->GnbLateConfiguration.GnbIoapicId = CONFIG_MAX_CPUS + 1;
line over 80 characters
--
To view, visit https://review.coreboot.org/29343
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cfd6c81f47de23c54a49ec7cf87b219215ced5e
Gerrit-Change-Number: 29343
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 18:39:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello Marshall Dawson, build bot (Jenkins), Marc Jones, Daniel Kurtz, Raul Rangel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29343
to look at the new patch set (#2).
Change subject: soc/amd/stoneyridge: Set IOMMU support to follow device setting
......................................................................
soc/amd/stoneyridge: Set IOMMU support to follow device setting
Instead of forcing the IOMMU to be enabled, change it to only be enabled
if the device is enabled in devicetree.
BUG=b:118612241
TEST=Verify that IOMMU is disabled.
Change-Id: I6cfd6c81f47de23c54a49ec7cf87b219215ced5e
Signed-off-by: Martin Roth <martinroth(a)google.com>
---
M src/soc/amd/common/block/pi/agesawrapper.c
M src/soc/amd/stoneyridge/northbridge.c
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/29343/2
--
To view, visit https://review.coreboot.org/29343
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6cfd6c81f47de23c54a49ec7cf87b219215ced5e
Gerrit-Change-Number: 29343
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29345 )
Change subject: soc/amd/stoneyridge: Get rid of domain_read_resources
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/29345/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29345/1//COMMIT_MSG@24
PS1, Line 24: the empty resource
> > The particular empty resource was filled later: […]
It was not being filled at the point of creation, but later (southbridge_final(), it was filled (see the 2 domains I placed in my initial comment). That said, if it's not causing any problem when you remove it, it probably means it was not being used.
--
To view, visit https://review.coreboot.org/29345
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83bd3ea8db141416632c12fc883386070363f2f1
Gerrit-Change-Number: 29345
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz(a)google.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel(a)silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 30 Oct 2018 16:16:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
Hello Karthikeyan Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/29358
to look at the new patch set (#2).
Change subject: drivers/elog: Add support for early elog
......................................................................
drivers/elog: Add support for early elog
Add support to log events during the romstage.
BUG=b:117884485
Change-Id: Ia69515961da3bc72740f9b048a53d91af79c5b0d
Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com>
---
M src/drivers/elog/Makefile.inc
M src/drivers/elog/elog.c
2 files changed, 39 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/29358/2
--
To view, visit https://review.coreboot.org/29358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia69515961da3bc72740f9b048a53d91af79c5b0d
Gerrit-Change-Number: 29358
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Karthikeyan Ramasubramanian <kramasub(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>