Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/29345 )
Change subject: soc/amd/stoneyridge: Get rid of domain_read_resources
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/29345/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/29345/1//COMMIT_MSG@24
PS1, Line 24: the empty resource
The particular empty resource was filled later: […]
It was not being filled at the point of creation, but later (southbridge_final(), it was filled (see the 2 domains I placed in my initial comment). That said, if it's not causing any problem when you remove it, it probably means it was not being used.
--
To view, visit
https://review.coreboot.org/29345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83bd3ea8db141416632c12fc883386070363f2f1
Gerrit-Change-Number: 29345
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 30 Oct 2018 16:16:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes