Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29361 )
Change subject: mb/google/poppy/variant/nocturne: adjust RcompTarget to fix DRAM corruption
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29361/1/src/mainboard/google/poppy/variants/...
File src/mainboard/google/poppy/variants/nocturne/memory.c:
https://review.coreboot.org/#/c/29361/1/src/mainboard/google/poppy/variants/...
PS1, Line 36: 30
Does this value work for both KBL and AML? Was this change validated on all the different Nocturne SKUs?
--
To view, visit
https://review.coreboot.org/29361
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefc3957f915a39a47ad6018459e65b70d1b34091
Gerrit-Change-Number: 29361
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 30 Oct 2018 19:09:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No