July 2014 - coreboot-gerrit - mail.coreboot.org

Patch merged into coreboot/master: 0967026 cpu/intel: Add fsp version of model 406dx (Rangeley / Atom C2000)
by gerrit＠coreboot.org July 30, 2014

July 30, 2014

the following patch was just integrated into master: commit 09670265b63184f92d78fc8fe5311f3662cc528a Author: Martin Roth <gaumless(a)gmail.com> Date: Wed May 21 13:40:21 2014 -0600 cpu/intel: Add fsp version of model 406dx (Rangeley / Atom C2000) This adds the CPU initialization pieces for Intel's Atom C2000 processor (Formerly Rangeley). Change-Id: I77d69f42c959bbc294784f044b7b0dcc2e30f30c Signed-off-by: Martin Roth <gaumless(a)gmail.com> Reviewed-on: http://review.coreboot.org/6368 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6368 for details. -gerrit

1 0

Patch set updated for coreboot: f113d88 intel/eagleheights/Kconfig: Do not set twice MMCONF_BASE_ADDRESS
by Daniele Forsi July 30, 2014

July 30, 2014

Daniele Forsi (dforsi(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6417 -gerrit commit f113d88a04dba32150c51ff38e898ce70af2af4b Author: Daniele Forsi <dforsi(a)gmail.com> Date: Wed Jul 30 14:16:07 2014 +0200 intel/eagleheights/Kconfig: Do not set twice MMCONF_BASE_ADDRESS Remove the lines added in an apparently unrelated commit 53ad9f58 (Make CONFIG_HAVE_HIGH_TABLES consistent in where and how it is set.) which touched the symbol HAVE_HIGH_TABLES in all files except this one and keep those added the same day in commit 6842c029 (Remove MAINBOARD_OPTIONS, which is a relic from early kconfig development.) Change-Id: Ib055c25a0a0795a50a36e65218c8f31e921f1502 Signed-off-by: Daniele Forsi <dforsi(a)gmail.com> --- src/mainboard/intel/eagleheights/Kconfig | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/mainboard/intel/eagleheights/Kconfig b/src/mainboard/intel/eagleheights/Kconfig index bc0799c..702e2af 100644 --- a/src/mainboard/intel/eagleheights/Kconfig +++ b/src/mainboard/intel/eagleheights/Kconfig @@ -19,10 +19,6 @@ config MAINBOARD_DIR string default intel/eagleheights -config MMCONF_BASE_ADDRESS - hex - default 0xe0000000 - config MAINBOARD_PART_NUMBER string default "EagleHeights"

1 0

New patch to review for coreboot: 139ae03 intel/eagleheights/Kconfig: Do not set twice MMCONF_BASE_ADDRESS
by Daniele Forsi July 30, 2014

July 30, 2014

Daniele Forsi (dforsi(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6417 -gerrit commit 139ae03efa604753aae1cbcc3a9e0aa96278ead2 Author: Daniele Forsi <dforsi(a)gmail.com> Date: Wed Jul 30 14:16:07 2014 +0200 intel/eagleheights/Kconfig: Do not set twice MMCONF_BASE_ADDRESS Remove the lines added in a later commit 53ad9f58 (Myles Watson 2009-09-29 21:35:48 +0000 and keep those added in commit 6842c029 (Patrick Georgi 2009-09-29 17:28:13 +0000 Change-Id: Ib055c25a0a0795a50a36e65218c8f31e921f1502 Signed-off-by: Daniele Forsi <dforsi(a)gmail.com> --- src/mainboard/intel/eagleheights/Kconfig | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/mainboard/intel/eagleheights/Kconfig b/src/mainboard/intel/eagleheights/Kconfig index bc0799c..702e2af 100644 --- a/src/mainboard/intel/eagleheights/Kconfig +++ b/src/mainboard/intel/eagleheights/Kconfig @@ -19,10 +19,6 @@ config MAINBOARD_DIR string default intel/eagleheights -config MMCONF_BASE_ADDRESS - hex - default 0xe0000000 - config MAINBOARD_PART_NUMBER string default "EagleHeights"

1 0

New patch to review for coreboot: 2c6cde5 src/console/Kconfig: Fix choice for showing POST codes on console
by Daniele Forsi July 30, 2014

July 30, 2014

Daniele Forsi (dforsi(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6416 -gerrit commit 2c6cde5de5664cc6e27549dfa1dbcbfd6b8a4521 Author: Daniele Forsi <dforsi(a)gmail.com> Date: Wed Jul 30 12:23:35 2014 +0200 src/console/Kconfig: Fix choice for showing POST codes on console Use CONSOLE_POST because the preprocessor conditional in post_code() in src/console/post.c depends on it, while POST_IO is used in another conditional for sending the codes to an I/O port. Change-Id: Ia044cffb5f0aad0f8b2bb04faa12df11a705757a Signed-off-by: Daniele Forsi <dforsi(a)gmail.com> --- src/console/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/console/Kconfig b/src/console/Kconfig index 710cc6e..8a2da1c 100644 --- a/src/console/Kconfig +++ b/src/console/Kconfig @@ -296,7 +296,7 @@ config CMOS_POST_EXTRA This will enable extra logging of work that happens between post codes into CMOS for debug. This uses an additional 8 bytes of CMOS. -config POST_IO +config CONSOLE_POST bool "Show POST codes on the debug console" depends on !NO_POST default n

1 0

Patch merged into coreboot/master: ddf54b1 util/sconfig: fix check for count of command line arguments
by gerrit＠coreboot.org July 30, 2014

July 30, 2014

the following patch was just integrated into master: commit ddf54b1c8b2ef6e8e3d2a673e0dd1ab43c7edc2c Author: Daniele Forsi <dforsi(a)gmail.com> Date: Sun Jul 27 11:02:15 2014 +0200 util/sconfig: fix check for count of command line arguments Valid invocations are when -s|b|k outputfile is missing (argc == 3) and when it is followed by the file name (argc == 5); it's an error when "outputfile" is missing (argc == 4) or when there are more arguments than expected (argc > 5). Fixes "Uninitialized argument value" error found by scan-build from clang version 3.2-11. Change-Id: I8c489863323eb60cbaa5e82a80f5d78a6ca893c2 Signed-off-by: Daniele Forsi <dforsi(a)gmail.com> Reviewed-on: http://review.coreboot.org/6378 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6378 for details. -gerrit

1 0

Patch merged into coreboot/master: 201093e util/i915tool: close the file also when fread() returned an error
by gerrit＠coreboot.org July 30, 2014

July 30, 2014

the following patch was just integrated into master: commit 201093ef6d24de27bc491947b9ab31d22f0aca8f Author: Daniele Forsi <dforsi(a)gmail.com> Date: Sun Jul 27 18:45:30 2014 +0200 util/i915tool: close the file also when fread() returned an error Change-Id: I92f816aa1351a295287ebbcc78665ac87c318c23 Signed-off-by: Daniele Forsi <dforsi(a)gmail.com> Reviewed-on: http://review.coreboot.org/6386 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6386 for details. -gerrit

1 0

Patch merged into coreboot/master: 06b13a3 cbmem: Terminate the cbmem console at the cursor position.
by gerrit＠coreboot.org July 30, 2014

July 30, 2014

the following patch was just integrated into master: commit 06b13a37f0f4b3545b899e3488762b3ed9c20812 Author: Gabe Black <gabeblack(a)google.com> Date: Fri Aug 9 00:40:06 2013 -0700 cbmem: Terminate the cbmem console at the cursor position. If the cbmem console buffer isn't zero filled before it's used, there won't be a terminator at the end. We need to put one at the cursor position manually. Change-Id: I69870c2b24b67ce3cbcd402b62f3574acb4c2a8f Signed-off-by: Gabe Black <gabeblack(a)google.com> Reviewed-on: https://gerrit.chromium.org/gerrit/65300 Reviewed-by: Hung-Te Lin <hungte(a)chromium.org> Commit-Queue: Gabe Black <gabeblack(a)chromium.org> Tested-by: Gabe Black <gabeblack(a)chromium.org> (cherry picked from commit 8ec61e52a6a27ed518d0abb5a19d6261edf9dab1) Signed-off-by: Isaac Christensen <isaac.christensen(a)se-eng.com> Reviewed-on: http://review.coreboot.org/6404 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6404 for details. -gerrit

1 0

Patch merged into coreboot/master: 0dd5e43 i82801ix: Allow configuration of SATA mode in CMOS.
by gerrit＠coreboot.org July 30, 2014

July 30, 2014

the following patch was just integrated into master: commit 0dd5e4395e805e3d54b31f3eaf8b432af5bad5e2 Author: Vladimir Serbinenko <phcoder(a)gmail.com> Date: Tue Jul 29 22:35:45 2014 +0200 i82801ix: Allow configuration of SATA mode in CMOS. Change-Id: Ice0f0273b16a946143c038a90b61978269c1c56e Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> Reviewed-on: http://review.coreboot.org/6409 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/6409 for details. -gerrit

1 0

Patch merged into coreboot/master: 8e89847 util/cbfstool: free buffer on error path
by gerrit＠coreboot.org July 30, 2014

July 30, 2014

the following patch was just integrated into master: commit 8e89847af41656f82226e755f03fdcc178d3ef78 Author: Daniele Forsi <dforsi(a)gmail.com> Date: Sun Jul 27 12:01:40 2014 +0200 util/cbfstool: free buffer on error path Fix memory leak found by scan-build from clang version 3.2-11. Change-Id: Id8f9db46cf42012a0eb0a632c9d83a4eec1989a2 Signed-off-by: Daniele Forsi <dforsi(a)gmail.com> Reviewed-on: http://review.coreboot.org/6379 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6379 for details. -gerrit

1 0

Patch merged into coreboot/master: b532b12 model_fxx/processor_name.c, hudson/lpc.c: add missing break statements
by gerrit＠coreboot.org July 30, 2014

July 30, 2014

the following patch was just integrated into master: commit b532b12b411d315b7799fc00a987bf21deb7e8a3 Author: Daniele Forsi <dforsi(a)gmail.com> Date: Sat Jul 26 10:32:34 2014 +0200 model_fxx/processor_name.c, hudson/lpc.c: add missing break statements Found by Cppcheck 1.65. Fixes: (warning) Variable 'processor_name_string' is reassigned a value before the old one has been used. 'break;' missing? (warning) Variable 'rsize' is reassigned a value before the old one has been used. 'break;' missing? Change-Id: I4a5c947fd5cc5797eb026475ec7036bc5eaf58db Signed-off-by: Daniele Forsi <dforsi(a)gmail.com> Reviewed-on: http://review.coreboot.org/6372 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> Reviewed-by: Edward O'Callaghan <eocallaghan(a)alterapraxis.com> See http://review.coreboot.org/6372 for details. -gerrit

1 0