coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[M] Change in coreboot[main]: soc/intel: Adapt crashlog IP to also support 64-bit
by Pratikkumar V Prajapati (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Angel Pons, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Nick Vaccaro, Paul Menzel, Sowmya Aralguppe, Subrata Banik, Tarun. Pratikkumar V Prajapati has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83106?usp=email ) Change subject: soc/intel: Adapt crashlog IP to also support 64-bit ...................................................................... Patch Set 22: Code-Review+1 (1 comment) File src/soc/intel/meteorlake/crashlog.c: https://review.coreboot.org/c/coreboot/+/83106/comment/65d58229_ddc58c94?us… : PS22, Line 352: + 4 > Dont we need to check for 0xdeadbeef […] line 354 is already checking for 0 size. I think we should also check for deadbeef, its pretty easy check. I assume you triggered a fake crashlog and was able to parse/decode the crashlog data. -- To view, visit https://review.coreboot.org/c/coreboot/+/83106?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I552257d3770abb409e2dcd8a13392506b5e7feb7 Gerrit-Change-Number: 83106 Gerrit-PatchSet: 22 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Fri, 28 Jun 2024 18:37:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Comment-In-Reply-To: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Stop checking CBI for UCSI
by Caveh Jalali (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Abhishek Pandit-Subedi, Paul Menzel, Shelley Chen. Caveh Jalali has posted comments on this change by Abhishek Pandit-Subedi. ( https://review.coreboot.org/c/coreboot/+/83252?usp=email ) Change subject: ec/google/chromeec: Stop checking CBI for UCSI ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9d820c637e56a527fd90f45b1848158a960dee7 Gerrit-Change-Number: 83252 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 28 Jun 2024 18:15:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Stop checking CBI for UCSI
by Abhishek Pandit-Subedi (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Caveh Jalali, Paul Menzel, Shelley Chen. Abhishek Pandit-Subedi has posted comments on this change by Abhishek Pandit-Subedi. ( https://review.coreboot.org/c/coreboot/+/83252?usp=email ) Change subject: ec/google/chromeec: Stop checking CBI for UCSI ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: +Shelley for eventual submit -- To view, visit https://review.coreboot.org/c/coreboot/+/83252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9d820c637e56a527fd90f45b1848158a960dee7 Gerrit-Change-Number: 83252 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 28 Jun 2024 18:01:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Stop checking CBI for UCSI
by Abhishek Pandit-Subedi (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Caveh Jalali, Paul Menzel. Abhishek Pandit-Subedi has posted comments on this change by Abhishek Pandit-Subedi. ( https://review.coreboot.org/c/coreboot/+/83252?usp=email ) Change subject: ec/google/chromeec: Stop checking CBI for UCSI ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83252/comment/a9258f82_593f6eae?us… : PS1, Line 9: Use only EC_FEATURE_UCSI_PPM to determine whether UCSI is enabled. > Please starte by describing the problem. See https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/5664227 -- To view, visit https://review.coreboot.org/c/coreboot/+/83252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9d820c637e56a527fd90f45b1848158a960dee7 Gerrit-Change-Number: 83252 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 28 Jun 2024 17:57:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Stop checking CBI for UCSI
by Forest Mittelberg (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Abhishek Pandit-Subedi, Caveh Jalali. Forest Mittelberg has posted comments on this change by Abhishek Pandit-Subedi. ( https://review.coreboot.org/c/coreboot/+/83252?usp=email ) Change subject: ec/google/chromeec: Stop checking CBI for UCSI ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9d820c637e56a527fd90f45b1848158a960dee7 Gerrit-Change-Number: 83252 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> Gerrit-Comment-Date: Fri, 28 Jun 2024 17:55:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: src/lib: Add Kconfig variable for fw_config default value
by Cliff Huang (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Bora Guvendik, Julius Werner, Subrata Banik, Wonkyu Kim. Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83153?usp=email ) Change subject: src/lib: Add Kconfig variable for fw_config default value ...................................................................... Patch Set 3: (1 comment) File src/Kconfig: https://review.coreboot.org/c/coreboot/+/83153/comment/62de21f4_07823207?us… : PS2, Line 548: 0x00000 > > I change default value to UNDEFINED_FW_CONFIG and this won't be used unless config. […] Subrata, I assume you mean FW_CONFIG_SOURCE_CHROMEEC_CBI. Yes. we set this flag off in our build for Windows EC and also for simulation environment and intend not to use Chrome EC. In fw_config.h, it has this define: #define UNDEFINED_FW_CONFIG ~((uint64_t)0) -> 0xffffffffffffffff The same value is used for CONFIG_FW_CONFIG_DEFAULT_VALUE as default in Kconfig so that even all bits are '1', but then this flag is not provisioned. If not overridden in config.<board>, no code flow is changed. In addition, in our standalone make build, we don't have project config.star like the one in cros environment. Also, during PO, we used Windows EC and also we had issue with Chrome EC and not able to get CBI command back then. This flag is used so that we can have at least fw_config value other than UNDEFINED_FW_CONFIG to move forward. -- To view, visit https://review.coreboot.org/c/coreboot/+/83153?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3 Gerrit-Change-Number: 83153 Gerrit-PatchSet: 3 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 28 Jun 2024 17:50:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: util/superiotool/fintek: Add f81866 register table
by Martin Roth (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Felix Held, Felix Singer, Maxim, Michał Żygowski, Paul Menzel. Martin Roth has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83004?usp=email ) Change subject: util/superiotool/fintek: Add f81866 register table ...................................................................... Patch Set 11: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83004/comment/5e187d5f_b2ac2cef?us… : PS9, Line 12: 1 Putting URLs in the commit message is discouraged as they frequently become stale as the website changes. If you do want to add the URL here, please use an archive.org link. -- To view, visit https://review.coreboot.org/c/coreboot/+/83004?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4367a1129fe628e7bf05d49678ea1c3718da710b Gerrit-Change-Number: 83004 Gerrit-PatchSet: 11 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 28 Jun 2024 15:39:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: util/superiotool/fintek: Add missing F81804 name for 0x0215 id
by Martin Roth (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Felix Singer, Maxim. Martin Roth has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83018?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: util/superiotool/fintek: Add missing F81804 name for 0x0215 id ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83018/comment/d701de94_9bba645b?us… : PS7, Line 10: https Putting URLs in the commit message is discouraged as they frequently become stale. If you do want to put the URL here, please link to archive.org: https://web.archive.org/web/20240628153609/https://github.com/torvalds/linu… -- To view, visit https://review.coreboot.org/c/coreboot/+/83018?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6889ad8ad861465316333ff997956a05b74c5855 Gerrit-Change-Number: 83018 Gerrit-PatchSet: 7 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Comment-Date: Fri, 28 Jun 2024 15:38:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: util/superiotool/fintek: Add missing F81804 name for 0x0215 id
by Maxim (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Felix Singer. Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83018?usp=email ) Change subject: util/superiotool/fintek: Add missing F81804 name for 0x0215 id ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83018/comment/1e9591d6_b7a876cd?us… : PS6, Line 7: utils > nit: util Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/83018?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6889ad8ad861465316333ff997956a05b74c5855 Gerrit-Change-Number: 83018 Gerrit-PatchSet: 7 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Fri, 28 Jun 2024 14:53:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: util/superiotool/fintek: Add missing F81804 name for 0x0215 id
by Maxim (Code Review) 28 Jun '24

28 Jun '24

Attention is currently required from: Felix Singer, Maxim. Hello Angel Pons, Felix Singer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83018?usp=email to look at the new patch set (#7). Change subject: util/superiotool/fintek: Add missing F81804 name for 0x0215 id ...................................................................... util/superiotool/fintek: Add missing F81804 name for 0x0215 id "0x1502 F81804 chipset ID, same for F81966" in https://github.com/torvalds/linux/blob/master/drivers/gpio/gpio-f7188x.c Change-Id: I6889ad8ad861465316333ff997956a05b74c5855 Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M util/superiotool/fintek.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/83018/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/83018?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6889ad8ad861465316333ff997956a05b74c5855 Gerrit-Change-Number: 83018 Gerrit-PatchSet: 7 Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024