Attention is currently required from: Angel Pons, Nicholas Sudsgaard.
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80411?usp=email
to look at the new patch set (#21).
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons, Verified-1 by build bot (Jenkins)
Change subject: Documentation/mainboard/lenovo: Add ThinkCentre M710s
......................................................................
Documentation/mainboard/lenovo: Add ThinkCentre M710s
Change-Id: I90311257a28bd463712c4d43f8b83baa745509cc
Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/lenovo/thinkcentre_m710s.md
A Documentation/mainboard/lenovo/thinkcentre_m710s_spi_location.jpg
3 files changed, 82 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/80411/21
--
To view, visit https://review.coreboot.org/c/coreboot/+/80411?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I90311257a28bd463712c4d43f8b83baa745509cc
Gerrit-Change-Number: 80411
Gerrit-PatchSet: 21
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Attention is currently required from: Anil Kumar K, Bora Guvendik, Julius Werner, Paul Menzel, Subrata Banik, Wonkyu Kim.
Hello Anil Kumar K, Bora Guvendik, Jérémy Compostella, Subrata Banik, Wonkyu Kim, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83153?usp=email
to look at the new patch set (#6).
Change subject: lib: Add Kconfig variable for fw_config default value
......................................................................
lib: Add Kconfig variable for fw_config default value
This CONFIG_FW_CONFIG_DEFAULT_VALUE is used only when CBI fw_config
value cannot be read from all sources such as Chrome EC and VPD. It
defaults to the same value as UNDEFINED_FW_CONFIG defined in
fw_config.h; and it won't be used unless it is set to different value in
config.<board> file. If a valid value is read from the Chrome EC or VPD,
the fw_config value will not be overridden by this flag.
TEST=boot and check fw_config value from coreboot log
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3
---
M src/Kconfig
M src/lib/fw_config.c
2 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/83153/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/83153?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3
Gerrit-Change-Number: 83153
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Attention is currently required from: Nicholas Sudsgaard.
Nicholas Chin has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80411?usp=email )
Change subject: Documentation/mainboard/lenovo: Add ThinkCentre M710s
......................................................................
Patch Set 20:
(1 comment)
File Documentation/mainboard/index.md:
https://review.coreboot.org/c/coreboot/+/80411/comment/26f79c61_6e98dd44?us… :
PS17, Line 106: - [ThinkCentre M710s](lenovo/thinkcentre_m710s)
This needs to be updated for the new toctree format as of commit 35599f9a6671 (Docs: Replace Recommonmark with MyST Parser). Should just be a matter of rebasing onto main and resolving any conflicts
--
To view, visit https://review.coreboot.org/c/coreboot/+/80411?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I90311257a28bd463712c4d43f8b83baa745509cc
Gerrit-Change-Number: 80411
Gerrit-PatchSet: 20
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Comment-Date: Sat, 29 Jun 2024 00:42:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Eric Lai, YH Lin, dinesh.sharma(a)intel.com.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83200?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: drivers/wifi: Support Bluetooth Regulator Domain Settings
......................................................................
Patch Set 6: Code-Review-2
(1 comment)
Patchset:
PS6:
The BRDS ACPI method scope should not be under the Wi-Fi device. According to the specification, it should located at the "Bluetooth® device under USB Hub scope Or PCIe* root port".
--
To view, visit https://review.coreboot.org/c/coreboot/+/83200?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iebe95815c944d045f4cf686abcd1874a8a45e209
Gerrit-Change-Number: 83200
Gerrit-PatchSet: 6
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: dinesh.sharma(a)intel.com
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: dinesh.sharma(a)intel.com
Gerrit-Comment-Date: Fri, 28 Jun 2024 23:00:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Anil Kumar K, Bora Guvendik, Julius Werner, Paul Menzel, Subrata Banik, Wonkyu Kim.
Hello Anil Kumar K, Bora Guvendik, Jérémy Compostella, Subrata Banik, Wonkyu Kim, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83153?usp=email
to look at the new patch set (#5).
Change subject: lib: Add Kconfig variable for fw_config default value
......................................................................
lib: Add Kconfig variable for fw_config default value
This CONFIG_FW_CONFIG_DEFAULT_VALUE is used only when CBI fw_config
value cannot be read from all sources such as Chrome EC and VPD. It
defaults to the same value as UNDEFINED_FW_CONFIG defined in
fw_config.h; and it won't be used unless it is set to different value in
config.<board> file. If a valid value is read from the Chrome EC or VPD,
the fw_config value will not be overriden by this flag.
TEST=boot and check fw_config value from coreboot log
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3
---
M src/Kconfig
M src/lib/fw_config.c
2 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/83153/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83153?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3
Gerrit-Change-Number: 83153
Gerrit-PatchSet: 5
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83249?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: tgl mainboards: Move SATA related settings into SATA device scope
......................................................................
tgl mainboards: Move SATA related settings into SATA device scope
Change-Id: I03508c50fe56fd85f8bf89f724863e546d4140e9
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83249
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/volteer/variants/baseboard/devicetree.cb
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
2 files changed, 11 insertions(+), 12 deletions(-)
Approvals:
Matt DeVillier: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
index 5df3947..4fdc7b4 100644
--- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
@@ -141,12 +141,6 @@
register "PcieClkSrcUsage[5]" = "PCIE_CLK_NOTUSED"
register "PcieClkSrcUsage[6]" = "PCIE_CLK_NOTUSED"
- # Enable SATA
- register "SataSalpSupport" = "1"
- register "SataPortsEnable[1]" = "1"
- register "SataPortsDevSlp[1]" = "1"
- register "SataPortsEnableDitoConfig[1]" = "1"
-
register "SerialIoI2cMode" = "{
[PchSerialIoIndexI2C0] = PchSerialIoPci,
[PchSerialIoIndexI2C1] = PchSerialIoPci,
@@ -462,7 +456,12 @@
device ref i2c2 on end
device ref i2c3 on end
device ref heci1 on end
- device ref sata on end
+ device ref sata on
+ register "SataSalpSupport" = "1"
+ register "SataPortsEnable[1]" = "1"
+ register "SataPortsDevSlp[1]" = "1"
+ register "SataPortsEnableDitoConfig[1]" = "1"
+ end
device ref pcie_rp7 on end
device ref pcie_rp8 on
probe DB_SD SD_GL9755S
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
index f03f677..7c60f0c 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
@@ -59,10 +59,6 @@
register "PcieClkSrcUsage[2]" = "0x3"
register "PcieClkSrcUsage[3]" = "0x8"
- register "SataSalpSupport" = "1"
- register "SataPortsEnable[0]" = "1"
- register "SataPortsEnable[1]" = "1"
-
# enabling EDP in PortA
register "DdiPortAConfig" = "DDI_PORT_CFG_EDP"
@@ -267,7 +263,11 @@
device ref csme2 off end
device ref heci3 off end
device ref heci4 off end
- device ref sata on end
+ device ref sata on
+ register "SataSalpSupport" = "1"
+ register "SataPortsEnable[0]" = "1"
+ register "SataPortsEnable[1]" = "1"
+ end
device ref i2c4 off end
device ref i2c5 on end
device ref uart2 on end
--
To view, visit https://review.coreboot.org/c/coreboot/+/83249?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I03508c50fe56fd85f8bf89f724863e546d4140e9
Gerrit-Change-Number: 83249
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83248?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: mb/google/volteer/baseboard: Drop disabled SATA settings from dt
......................................................................
mb/google/volteer/baseboard: Drop disabled SATA settings from dt
Configuring them to 0 is equal to not configuring them at all. So remove
them to clean up a bit.
Change-Id: I18134ac784fffb703e1fe513e5914f05faa749c9
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83248
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/google/volteer/variants/baseboard/devicetree.cb
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Matt DeVillier: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
index fe13b77..5df3947 100644
--- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb
@@ -143,9 +143,7 @@
# Enable SATA
register "SataSalpSupport" = "1"
- register "SataPortsEnable[0]" = "0"
register "SataPortsEnable[1]" = "1"
- register "SataPortsDevSlp[0]" = "0"
register "SataPortsDevSlp[1]" = "1"
register "SataPortsEnableDitoConfig[1]" = "1"
--
To view, visit https://review.coreboot.org/c/coreboot/+/83248?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I18134ac784fffb703e1fe513e5914f05faa749c9
Gerrit-Change-Number: 83248
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Bob Moragues, Bora Guvendik, Cliff Huang, Eric Lai, Hannah Williams, Poornima Tom, Ravishankar Sarawadi, Subrata Banik, YH Lin, dinesh.sharma(a)intel.com.
Jérémy Compostella has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/81790?usp=email )
Change subject: drivers/wifi: Support 320Mhz Bandwidth Enablement per MCC
......................................................................
Patch Set 7: Code-Review-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/81790?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie76794825f1a0104d199c078aa4ffc714aa95b17
Gerrit-Change-Number: 81790
Gerrit-PatchSet: 7
Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: dinesh.sharma(a)intel.com
Gerrit-CC: Bob Moragues <moragues(a)google.com>
Gerrit-CC: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com>
Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: dinesh.sharma(a)intel.com
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-Comment-Date: Fri, 28 Jun 2024 21:25:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Eric Lai, YH Lin, dinesh.sharma(a)intel.com.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83200?usp=email )
Change subject: drivers/wifi: Support Bluetooth Regulator Domain Settings
......................................................................
Patch Set 6: Code-Review-1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83200?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iebe95815c944d045f4cf686abcd1874a8a45e209
Gerrit-Change-Number: 83200
Gerrit-PatchSet: 6
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: dinesh.sharma(a)intel.com
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: dinesh.sharma(a)intel.com
Gerrit-Comment-Date: Fri, 28 Jun 2024 21:24:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes