coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3527 discussions

[M] Change in coreboot[main]: mb: source site-local mainboard Kconfig.name and Kconfig files
by Angel Pons (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Alexander Couzens, David Hendricks, Evgeny Zinoviev, Felix Held, Felix Singer, Jeremy Soller, Martin L Roth, Matt DeVillier, Michael Niewöhner, Michał Żygowski, Philipp Hug, Piotr Król, Ron Minnich, Sean Rhodes, Tim Crawford. Angel Pons has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83119?usp=email ) Change subject: mb: source site-local mainboard Kconfig.name and Kconfig files ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > i'd say that the advantage to have that source statement everywhere is both uniformity and that it d […] Is there a way to achieve equivalent functionality without having to modify all `src/mainboard/*/Kconfig` files? -- To view, visit https://review.coreboot.org/c/coreboot/+/83119?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4106fea7197c979e6648ebbbbaa107070c916727 Gerrit-Change-Number: 83119 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 30 Jun 2024 08:09:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[L] Change in coreboot[main]: mb/aoostar: Add Alder Lake based AOOSTAR R1 (WTR_R1)
by Angel Pons (Code Review) 30 Jun '24

30 Jun '24

Angel Pons has posted comments on this change by Federico Amedeo Izzo. ( https://review.coreboot.org/c/coreboot/+/82010?usp=email ) Change subject: mb/aoostar: Add Alder Lake based AOOSTAR R1 (WTR_R1) ...................................................................... Patch Set 17: (1 comment) Patchset: PS17: > Thank you very much. […] coreboot logs the time spent printing, it doesn't seem to be that high. That being said, I know ADL FSP is atrociously slow (IIRC, so much that Google has struggled to achieve sub-second firmware boot times for Chromebooks). -- To view, visit https://review.coreboot.org/c/coreboot/+/82010?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9414eb742b6b90459e010b038c1994537e9801a5 Gerrit-Change-Number: 82010 Gerrit-PatchSet: 17 Gerrit-Owner: Federico Amedeo Izzo <federico(a)izzo.pro> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Brandon Weeks <bweeks(a)google.com> Gerrit-Comment-Date: Sun, 30 Jun 2024 08:03:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Federico Amedeo Izzo <federico(a)izzo.pro>

1 0

[S] Change in coreboot[main]: lib: Add Kconfig variable for fw_config default value
by Paul Menzel (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Julius Werner, Subrata Banik, Wonkyu Kim. Paul Menzel has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83153?usp=email ) Change subject: lib: Add Kconfig variable for fw_config default value ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83153/comment/b21e37a7_fa33e454?us… : PS3, Line 9: This CONFIG_FW_CONFIG_DEFAULT_VALUE flag is default to Thank you. > … when CBI fw_config value cannot be read from all sources such as Chrome EC and VPD What is the effect of this situation? System does not boot? Some component does not work? -- To view, visit https://review.coreboot.org/c/coreboot/+/83153?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3 Gerrit-Change-Number: 83153 Gerrit-PatchSet: 6 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sun, 30 Jun 2024 07:44:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: soc/intel/common: Add fpt_support to override CSME and HECI disables
by Paul Menzel (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Matt DeVillier, Sean Rhodes. Paul Menzel has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83265?usp=email ) Change subject: soc/intel/common: Add fpt_support to override CSME and HECI disables ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83265/comment/9c9a5c3c_4d530e1f?us… : PS1, Line 9: Intels FPT (Flash Programming Tool) can be used to flash coreboot via the EFI > `Possible unwrapped commit description (prefer a maximum 72 chars per line)` Please fix. https://review.coreboot.org/c/coreboot/+/83265/comment/9a36aba9_b0cfd67a?us… : PS1, Line 15: Please add TEST=. -- To view, visit https://review.coreboot.org/c/coreboot/+/83265?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I695fa96c5057303730492139904dfcc1d989880b Gerrit-Change-Number: 83265 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Sun, 30 Jun 2024 07:42:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Stop checking CBI for UCSI
by Paul Menzel (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Abhishek Pandit-Subedi, Shelley Chen. Paul Menzel has posted comments on this change by Abhishek Pandit-Subedi. ( https://review.coreboot.org/c/coreboot/+/83252?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: ec/google/chromeec: Stop checking CBI for UCSI ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83252/comment/2e70073e_a5c94b50?us… : PS1, Line 9: Use only EC_FEATURE_UCSI_PPM to determine whether UCSI is enabled. > See https://chromium-review.googlesource. […] Thank you. Please update the commit message, as they have to be self-contained. -- To view, visit https://review.coreboot.org/c/coreboot/+/83252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia9d820c637e56a527fd90f45b1848158a960dee7 Gerrit-Change-Number: 83252 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Daisuke Nojiri <dnojiri(a)chromium.org> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> Gerrit-Comment-Date: Sun, 30 Jun 2024 07:40:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[L] Change in coreboot[main]: mb/aoostar: Add Alder Lake based AOOSTAR R1 (WTR_R1)
by Paul Menzel (Code Review) 30 Jun '24

30 Jun '24

Paul Menzel has posted comments on this change by Federico Amedeo Izzo. ( https://review.coreboot.org/c/coreboot/+/82010?usp=email ) Change subject: mb/aoostar: Add Alder Lake based AOOSTAR R1 (WTR_R1) ...................................................................... Patch Set 17: (1 comment) Patchset: PS17: > I uploaded the two logs for two different commits. […] Thank you very much. 1. https://review.coreboot.org/plugins/gitiles/board-status/+/d2df631729544b9a… 2. https://review.coreboot.org/plugins/gitiles/board-status/+/73bab87c09851459… $ git grep "Total Time" aoostar/wtr_r1/ aoostar/wtr_r1/24.05-171-gc9302d5d39/2024-06-07T06_16_27Z/coreboot_timestamps.txt:Total Time: 2,292,748 aoostar/wtr_r1/24.05-384-g0486f2b3bb/2024-06-28T22_11_31Z/coreboot_timestamps.txt:Total Time: 2,070,133 ``` $ git grep CONFIG_CONSOLE_SERIAL= aoostar/wtr_r1/ aoostar/wtr_r1/24.05-171-gc9302d5d39/2024-06-07T06_16_27Z/config.short.txt:CONFIG_CONSOLE_SERIAL=y aoostar/wtr_r1/24.05-171-gc9302d5d39/2024-06-07T06_16_27Z/config.txt:CONFIG_CONSOLE_SERIAL=y aoostar/wtr_r1/24.05-384-g0486f2b3bb/2024-06-28T22_11_31Z/config.short.txt:CONFIG_CONSOLE_SERIAL=y aoostar/wtr_r1/24.05-384-g0486f2b3bb/2024-06-28T22_11_31Z/config.txt:CONFIG_CONSOLE_SERIAL=y ``` Two seconds is quite long and probably caused by the serial console. Sorry for not writing it earlier. If you find time, it’d be great if you did both things with serial console disable so the lowest boot time is documented. I am marking this comment as resolved nevertheless. Big thanks again for the port and the uploads. -- To view, visit https://review.coreboot.org/c/coreboot/+/82010?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9414eb742b6b90459e010b038c1994537e9801a5 Gerrit-Change-Number: 82010 Gerrit-PatchSet: 17 Gerrit-Owner: Federico Amedeo Izzo <federico(a)izzo.pro> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Brandon Weeks <bweeks(a)google.com> Gerrit-Comment-Date: Sun, 30 Jun 2024 07:37:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Federico Amedeo Izzo <federico(a)izzo.pro>

1 0

[XS] Change in coreboot[main]: Makefile.mk: Use Wcast-function-type command option
by Felix Singer (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Elyes Haouas. Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82736?usp=email ) Change subject: Makefile.mk: Use Wcast-function-type command option ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82736/comment/53a3e998_61ed8519?us… : PS2, Line 7: command Maybe say GCC? -- To view, visit https://review.coreboot.org/c/coreboot/+/82736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I25415d7fd82879889ffaa1bb534ad5d0b174854e Gerrit-Change-Number: 82736 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 30 Jun 2024 01:18:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: Makefile.mk: Use Walloc-size command option
by Felix Singer (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Elyes Haouas. Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82734?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: Makefile.mk: Use Walloc-size command option ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82734/comment/4db36bca_ace0778d?us… : PS2, Line 7: command Maybe say GCC? -- To view, visit https://review.coreboot.org/c/coreboot/+/82734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia26dcf097db125a5a734660d08d875459179241b Gerrit-Change-Number: 82734 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 30 Jun 2024 01:17:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Makefile.mk: Use Walloc-size command option
by Felix Singer (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Elyes Haouas. Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82734?usp=email ) Change subject: Makefile.mk: Use Walloc-size command option ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia26dcf097db125a5a734660d08d875459179241b Gerrit-Change-Number: 82734 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 30 Jun 2024 01:16:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: tgl mainboards: Move audio related settings into hda device scope
by Felix Singer (Code Review) 30 Jun '24

30 Jun '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83251?usp=email ) Change subject: tgl mainboards: Move audio related settings into hda device scope ...................................................................... tgl mainboards: Move audio related settings into hda device scope Change-Id: I1992c20dcdc5e974143690d44ee199d7c3394cfd Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/83251 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb 3 files changed, 26 insertions(+), 21 deletions(-) Approvals: Elyes Haouas: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index df13fef..4775b0f 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -192,9 +192,6 @@ # - PM_CFG.SLP_LAN_MIN_ASST_WDTH register "PchPmPwrCycDur" = "1" # 1s - # HD Audio - register "PchHdaDspEnable" = "1" - # TCSS USB3 register "UsbTcPortEn" = "0x3" register "TcssXhciEn" = "1" @@ -513,6 +510,8 @@ end end device ref hda on + register "PchHdaDspEnable" = "1" + chip drivers/sof register "spkr_tplg" = "max98373" register "jack_tplg" = "rt5682" diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb index af16f75..fede521 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb @@ -104,14 +104,6 @@ .tdp_pl4 = 105, }" - #HD Audio - register "PchHdaDspEnable" = "1" - register "PchHdaAudioLinkDmicEnable[0]" = "1" - register "PchHdaAudioLinkDmicEnable[1]" = "1" - register "PchHdaAudioLinkSspEnable[0]" = "1" - register "PchHdaAudioLinkSspEnable[2]" = "1" - register "PchHdaAudioLinkSndwEnable[0]" = "1" - # Intel Common SoC Config register "common_soc_config" = "{ .gspi[1] = { @@ -332,7 +324,18 @@ end end end - device ref hda on end + device ref hda on + register "PchHdaDspEnable" = "1" + register "PchHdaAudioLinkDmicEnable" = "{ + [0] = 1, + [1] = 1, + }" + register "PchHdaAudioLinkSspEnable" = "{ + [0] = 1, + [2] = 1, + }" + register "PchHdaAudioLinkSndwEnable[0]" = "1" + end device ref smbus on end device ref fast_spi on end device ref gbe off end diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb index 3a80c51..23ccfb9 100644 --- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb +++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb @@ -111,14 +111,6 @@ .tdp_pl4 = 83, }" - #HD Audio - register "PchHdaDspEnable" = "1" - register "PchHdaAudioLinkDmicEnable[0]" = "1" - register "PchHdaAudioLinkDmicEnable[1]" = "1" - register "PchHdaAudioLinkSspEnable[0]" = "1" - register "PchHdaAudioLinkSspEnable[2]" = "1" - register "PchHdaAudioLinkSndwEnable[0]" = "1" - # Intel Common SoC Config register "common_soc_config" = "{ .gspi[1] = { @@ -337,7 +329,18 @@ end end end - device ref hda on end + device ref hda on + register "PchHdaDspEnable" = "1" + register "PchHdaAudioLinkDmicEnable" = "{ + [0] = 1, + [1] = 1, + }" + register "PchHdaAudioLinkSspEnable" = "{ + [0] = 1, + [2] = 1, + }" + register "PchHdaAudioLinkSndwEnable[0]" = "1" + end device ref smbus on end device ref fast_spi on end device ref gbe off end -- To view, visit https://review.coreboot.org/c/coreboot/+/83251?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1992c20dcdc5e974143690d44ee199d7c3394cfd Gerrit-Change-Number: 83251 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
353
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024