Attention is currently required from: Stefan Reinauer, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80235?usp=email )
Change subject: util/ifdtool: Add a new switch -E to protect GPR0
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Patchset:
PS6:
Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80235?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I27c533ae4109c79299f4e7ff75e750d7cc64280f
Gerrit-Change-Number: 80235
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Thu, 01 Feb 2024 10:22:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Stefan Reinauer.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80235?usp=email )
Change subject: util/ifdtool: Add a new switch -E to protect GPR0
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80235/comment/2bae1a07_d40819e0 :
PS5, Line 7: Add new cmdline to enable GPR0 protection
> Maybe: […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/80235/comment/bb865e4e_31aafaa7 :
PS5, Line 9: IFD Tool
> I have not seen that spelling – only ifdtool.
Acknowledged
https://review.coreboot.org/c/coreboot/+/80235/comment/79269e9c_7cf74c0a :
PS5, Line 11: Additionally, perform some code refactoring while adding support
> It’d be great, if you added a blank line between paragraphs.
Acknowledged
https://review.coreboot.org/c/coreboot/+/80235/comment/2cd2bbb8_58165990 :
PS5, Line 13:
> Can you point to a document, where more information about GPR0 protection can be found?
Acknowledged
--
To view, visit https://review.coreboot.org/c/coreboot/+/80235?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I27c533ae4109c79299f4e7ff75e750d7cc64280f
Gerrit-Change-Number: 80235
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Thu, 01 Feb 2024 09:11:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80278?usp=email )
Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80278/comment/7a246cba_3382e253 :
PS8, Line 10: ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly.
Please wrap the line at 72 characters.
https://review.coreboot.org/c/coreboot/+/80278/comment/7382a8a8_063dd3e1 :
PS8, Line 11:
Commit messages need to be self-sufficient. Please state the problem and the solution.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69
Gerrit-Change-Number: 80278
Gerrit-PatchSet: 8
Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Feb 2024 08:45:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Stefan Reinauer, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80235?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: util/ifdtool: Add new cmdline to enable GPR0 protection
......................................................................
Patch Set 5: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80235/comment/a76ef596_4fe370bf :
PS5, Line 7: Add new cmdline to enable GPR0 protection
Maybe:
> Add new switch -E to protect GPR0
https://review.coreboot.org/c/coreboot/+/80235/comment/6cdce12c_c803d389 :
PS5, Line 9: IFD Tool
I have not seen that spelling – only ifdtool.
https://review.coreboot.org/c/coreboot/+/80235/comment/2dd6bc72_7a0ae47e :
PS5, Line 11: Additionally, perform some code refactoring while adding support
It’d be great, if you added a blank line between paragraphs.
https://review.coreboot.org/c/coreboot/+/80235/comment/acbdf667_49bf2100 :
PS5, Line 13:
Can you point to a document, where more information about GPR0 protection can be found?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80235?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I27c533ae4109c79299f4e7ff75e750d7cc64280f
Gerrit-Change-Number: 80235
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Comment-Date: Thu, 01 Feb 2024 07:38:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Garen Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80282?usp=email )
Change subject: mb/google/nissa: Create yavista variant
......................................................................
mb/google/nissa: Create yavista variant
Create the yavista variant of the nissa reference board by copying
the template files to a new directory named for the variant.
BUG=b:321583226
BRANCH=None
TEST=util/abuild/abuild -p none -t google/brya -x -a
make sure the build includes GOOGLE_YAVISTA
Change-Id: I09f733188f8c8de9d60ac83f0a55ea78fb07b187
Signed-off-by: wu.garen <wu.garen(a)inventec.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/Kconfig.name
A src/mainboard/google/brya/variants/yavista/include/variant/ec.h
A src/mainboard/google/brya/variants/yavista/include/variant/gpio.h
A src/mainboard/google/brya/variants/yavista/memory/Makefile.mk
A src/mainboard/google/brya/variants/yavista/memory/dram_id.generated.txt
A src/mainboard/google/brya/variants/yavista/memory/mem_parts_used.txt
A src/mainboard/google/brya/variants/yavista/overridetree.cb
8 files changed, 53 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/80282/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig
index dae3f16..4cad7c0 100644
--- a/src/mainboard/google/brya/Kconfig
+++ b/src/mainboard/google/brya/Kconfig
@@ -583,6 +583,7 @@
default 0x1 if BOARD_GOOGLE_DOCHI
default 0x0 if BOARD_GOOGLE_QUANDISO
default 0x0 if BOARD_GOOGLE_ANRAGGAR
+ default 0x0 if BOARD_GOOGLE_YAVISTA
config DRIVER_TPM_I2C_ADDR
hex
@@ -666,6 +667,7 @@
default "Dochi" if BOARD_GOOGLE_DOCHI
default "Anraggar" if BOARD_GOOGLE_ANRAGGAR
default "Xol" if BOARD_GOOGLE_XOL
+ default "Yavista" if BOARD_GOOGLE_YAVISTA
config VARIANT_DIR
default "brya0" if BOARD_GOOGLE_BRYA0
@@ -720,6 +722,7 @@
default "dochi" if BOARD_GOOGLE_DOCHI
default "anraggar" if BOARD_GOOGLE_ANRAGGAR
default "xol" if BOARD_GOOGLE_XOL
+ default "yavista" if BOARD_GOOGLE_YAVISTA
config VBOOT
select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_BASEBOARD_NISSA
diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name
index dcdf3c7..7e923be 100644
--- a/src/mainboard/google/brya/Kconfig.name
+++ b/src/mainboard/google/brya/Kconfig.name
@@ -155,3 +155,6 @@
config BOARD_GOOGLE_XOL
bool "-> Xol"
+
+config BOARD_GOOGLE_YAVISTA
+ bool "-> Yavista"
diff --git a/src/mainboard/google/brya/variants/yavista/include/variant/ec.h b/src/mainboard/google/brya/variants/yavista/include/variant/ec.h
new file mode 100644
index 0000000..7a2a6ff
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/include/variant/ec.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __VARIANT_EC_H__
+#define __VARIANT_EC_H__
+
+#include <baseboard/ec.h>
+
+#endif
diff --git a/src/mainboard/google/brya/variants/yavista/include/variant/gpio.h b/src/mainboard/google/brya/variants/yavista/include/variant/gpio.h
new file mode 100644
index 0000000..c4fe342
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/include/variant/gpio.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef VARIANT_GPIO_H
+#define VARIANT_GPIO_H
+
+#include <baseboard/gpio.h>
+
+#endif
diff --git a/src/mainboard/google/brya/variants/yavista/memory/Makefile.mk b/src/mainboard/google/brya/variants/yavista/memory/Makefile.mk
new file mode 100644
index 0000000..a9f9ab7
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/memory/Makefile.mk
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Generated by:
+# ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/yaviks/memory/ src/mainboard/google/brya/variants/yaviks/memory/mem_parts_used.txt
+
+SPD_SOURCES = placeholder
diff --git a/src/mainboard/google/brya/variants/yavista/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/yavista/memory/dram_id.generated.txt
new file mode 100644
index 0000000..1be3fe0
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/memory/dram_id.generated.txt
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Generated by:
+# ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/yaviks/memory/ src/mainboard/google/brya/variants/yaviks/memory/mem_parts_used.txt
+
+DRAM Part Name ID to assign
+
diff --git a/src/mainboard/google/brya/variants/yavista/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/yavista/memory/mem_parts_used.txt
new file mode 100644
index 0000000..73c95bf
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/memory/mem_parts_used.txt
@@ -0,0 +1,12 @@
+# This is a CSV file containing a list of memory parts used by this variant.
+# One part per line with an optional fixed ID in column 2.
+# Only include a fixed ID if it is required for legacy reasons!
+# Generated IDs are dependent on the order of parts in this file,
+# so new parts must always be added at the end of the file!
+#
+# Generate an updated Makefile.mk and dram_id.generated.txt by running the
+# part_id_gen tool from util/spd_tools.
+# See util/spd_tools/README.md for more details and instructions.
+
+# Part Name
+
diff --git a/src/mainboard/google/brya/variants/yavista/overridetree.cb b/src/mainboard/google/brya/variants/yavista/overridetree.cb
new file mode 100644
index 0000000..4f2c04a
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/overridetree.cb
@@ -0,0 +1,6 @@
+chip soc/intel/alderlake
+
+ device domain 0 on
+ end
+
+end
--
To view, visit https://review.coreboot.org/c/coreboot/+/80282?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I09f733188f8c8de9d60ac83f0a55ea78fb07b187
Gerrit-Change-Number: 80282
Gerrit-PatchSet: 1
Gerrit-Owner: Garen Wu <wu.garen(a)inventec.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Julius Werner.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80253?usp=email )
Change subject: libpayload: Switch to commonlib ipchksum() algorithm
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80253?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie8d323ce9f8d946758619761b4b22d54bce222b6
Gerrit-Change-Number: 80253
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Feb 2024 06:50:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80252?usp=email )
Change subject: tests: Add some more ipchksum() test cases
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I39b4d3f1bb833894985649872329eec88a02a22c
Gerrit-Change-Number: 80252
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Feb 2024 06:49:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Garen Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80281?usp=email )
Change subject: mb/google/nissa: Create yavista variant
......................................................................
mb/google/nissa: Create yavista variant
Create the yavista variant of the nissa reference board by copying
the template files to a new directory named for the variant.
BUG=b:321583226
BRANCH=None
TEST=util/abuild/abuild -p none -t google/brya -x -a
make sure the build includes GOOGLE_YAVISTA
Change-Id: I276a2b2f5a6d8e613992defb791e872902d91fec
Signed-off-by: wu.garen <wu.garen(a)inventec.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/Kconfig.name
A src/mainboard/google/brya/variants/yavista/include/variant/ec.h
A src/mainboard/google/brya/variants/yavista/include/variant/gpio.h
A src/mainboard/google/brya/variants/yavista/memory/Makefile.mk
A src/mainboard/google/brya/variants/yavista/memory/dram_id.generated.txt
A src/mainboard/google/brya/variants/yavista/memory/mem_parts_used.txt
A src/mainboard/google/brya/variants/yavista/overridetree.cb
8 files changed, 53 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/80281/1
diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig
index dae3f16..91bc0b8 100644
--- a/src/mainboard/google/brya/Kconfig
+++ b/src/mainboard/google/brya/Kconfig
@@ -583,6 +583,7 @@
default 0x1 if BOARD_GOOGLE_DOCHI
default 0x0 if BOARD_GOOGLE_QUANDISO
default 0x0 if BOARD_GOOGLE_ANRAGGAR
+ default 0x0 if BOARD_GOOGLE_YAVISTA
config DRIVER_TPM_I2C_ADDR
hex
@@ -666,6 +667,7 @@
default "Dochi" if BOARD_GOOGLE_DOCHI
default "Anraggar" if BOARD_GOOGLE_ANRAGGAR
default "Xol" if BOARD_GOOGLE_XOL
+ default "Yavista" if BOARD_GOOGLE_YAVISTA
config VARIANT_DIR
default "brya0" if BOARD_GOOGLE_BRYA0
@@ -720,6 +722,7 @@
default "dochi" if BOARD_GOOGLE_DOCHI
default "anraggar" if BOARD_GOOGLE_ANRAGGAR
default "xol" if BOARD_GOOGLE_XOL
+ default "yaviks" if BOARD_GOOGLE_YAVISTA
config VBOOT
select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_BASEBOARD_NISSA
diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name
index dcdf3c7..7e923be 100644
--- a/src/mainboard/google/brya/Kconfig.name
+++ b/src/mainboard/google/brya/Kconfig.name
@@ -155,3 +155,6 @@
config BOARD_GOOGLE_XOL
bool "-> Xol"
+
+config BOARD_GOOGLE_YAVISTA
+ bool "-> Yavista"
diff --git a/src/mainboard/google/brya/variants/yavista/include/variant/ec.h b/src/mainboard/google/brya/variants/yavista/include/variant/ec.h
new file mode 100644
index 0000000..7a2a6ff
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/include/variant/ec.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef __VARIANT_EC_H__
+#define __VARIANT_EC_H__
+
+#include <baseboard/ec.h>
+
+#endif
diff --git a/src/mainboard/google/brya/variants/yavista/include/variant/gpio.h b/src/mainboard/google/brya/variants/yavista/include/variant/gpio.h
new file mode 100644
index 0000000..c4fe342
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/include/variant/gpio.h
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef VARIANT_GPIO_H
+#define VARIANT_GPIO_H
+
+#include <baseboard/gpio.h>
+
+#endif
diff --git a/src/mainboard/google/brya/variants/yavista/memory/Makefile.mk b/src/mainboard/google/brya/variants/yavista/memory/Makefile.mk
new file mode 100644
index 0000000..a9f9ab7
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/memory/Makefile.mk
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Generated by:
+# ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/yaviks/memory/ src/mainboard/google/brya/variants/yaviks/memory/mem_parts_used.txt
+
+SPD_SOURCES = placeholder
diff --git a/src/mainboard/google/brya/variants/yavista/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/yavista/memory/dram_id.generated.txt
new file mode 100644
index 0000000..1be3fe0
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/memory/dram_id.generated.txt
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+# This is an auto-generated file. Do not edit!!
+# Generated by:
+# ./util/spd_tools/bin/part_id_gen ADL lp5 src/mainboard/google/brya/variants/yaviks/memory/ src/mainboard/google/brya/variants/yaviks/memory/mem_parts_used.txt
+
+DRAM Part Name ID to assign
+
diff --git a/src/mainboard/google/brya/variants/yavista/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/yavista/memory/mem_parts_used.txt
new file mode 100644
index 0000000..73c95bf
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/memory/mem_parts_used.txt
@@ -0,0 +1,12 @@
+# This is a CSV file containing a list of memory parts used by this variant.
+# One part per line with an optional fixed ID in column 2.
+# Only include a fixed ID if it is required for legacy reasons!
+# Generated IDs are dependent on the order of parts in this file,
+# so new parts must always be added at the end of the file!
+#
+# Generate an updated Makefile.mk and dram_id.generated.txt by running the
+# part_id_gen tool from util/spd_tools.
+# See util/spd_tools/README.md for more details and instructions.
+
+# Part Name
+
diff --git a/src/mainboard/google/brya/variants/yavista/overridetree.cb b/src/mainboard/google/brya/variants/yavista/overridetree.cb
new file mode 100644
index 0000000..4f2c04a
--- /dev/null
+++ b/src/mainboard/google/brya/variants/yavista/overridetree.cb
@@ -0,0 +1,6 @@
+chip soc/intel/alderlake
+
+ device domain 0 on
+ end
+
+end
--
To view, visit https://review.coreboot.org/c/coreboot/+/80281?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I276a2b2f5a6d8e613992defb791e872902d91fec
Gerrit-Change-Number: 80281
Gerrit-PatchSet: 1
Gerrit-Owner: Garen Wu <wu.garen(a)inventec.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newchange