Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80278?usp=email
to look at the new patch set (#5).
Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci
......................................................................
mb/google/byra/var/anraggar: Set WLAN device type back to pci
This part refers to https://review.coreboot.org/q/commit:4b957b9665
("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly.
BUG=NA
TEST= Can be compiled normally, the verification function is normal, and it can pass the FAFT test.
Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69
Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69
Gerrit-Change-Number: 80278
Gerrit-PatchSet: 5
Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80278?usp=email
to look at the new patch set (#4).
Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci
......................................................................
mb/google/byra/var/anraggar: Set WLAN device type back to pci
This part refers to commit:4b957b9665
("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly.
BUG=NA
TEST= Can be compiled normally, the verification function is normal, and it can pass the FAFT test.
Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69
Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69
Gerrit-Change-Number: 80278
Gerrit-PatchSet: 4
Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80278?usp=email
to look at the new patch set (#3).
Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci
......................................................................
mb/google/byra/var/anraggar: Set WLAN device type back to pci
This part refers to 4b957b9
("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly.
BUG=NA
TEST= Can be compiled normally, the verification function is normal, and it can pass the FAFT test.
Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69
Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69
Gerrit-Change-Number: 80278
Gerrit-PatchSet: 3
Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80278?usp=email
to look at the new patch set (#2).
Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci
......................................................................
mb/google/byra/var/anraggar: Set WLAN device type back to pci
This part refers to 4b957b966543168d70fc3c07511595d33af76059 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly.
BUG=NA
TEST= Can be compiled normally, the verification function is normal, and it can pass the FAFT test.
Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69
Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69
Gerrit-Change-Number: 80278
Gerrit-PatchSet: 2
Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Qinghong Zeng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80278?usp=email )
Change subject: This part refers to 4b957b966543168d70fc3c07511595d33af76059 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly.
......................................................................
This part refers to 4b957b966543168d70fc3c07511595d33af76059 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly.
BUG=NA
TEST= Can be compiled normally, the verification function is normal, and it can pass the FAFT test.
Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69
Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/1
diff --git a/src/mainboard/google/brya/variants/anraggar/overridetree.cb b/src/mainboard/google/brya/variants/anraggar/overridetree.cb
index 9646f29..f619228 100644
--- a/src/mainboard/google/brya/variants/anraggar/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anraggar/overridetree.cb
@@ -380,7 +380,7 @@
register "wake" = "GPE0_PME_B0"
register "enable_cnvi_ddr_rfim" = "true"
register "add_acpi_dma_property" = "true"
- device generic 0 on end
+ device pci 00.0 on end
end
end
device ref pcie_rp4 on
--
To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69
Gerrit-Change-Number: 80278
Gerrit-PatchSet: 1
Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Julius Werner.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80256?usp=email )
Change subject: util/cbmem: Use commonlib ipchksum() algorithm
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80256?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0bef2c85c37ddd3438b7ac6389e9daa3e4955b31
Gerrit-Change-Number: 80256
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Feb 2024 02:26:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80253?usp=email )
Change subject: libpayload: Switch to commonlib ipchksum() algorithm
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80253?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie8d323ce9f8d946758619761b4b22d54bce222b6
Gerrit-Change-Number: 80253
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Feb 2024 02:26:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80254?usp=email )
Change subject: commonlib: Add assembly optimization for ipchksum() on arm64
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80254?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9c7bbc9d7a1cd083ced62fe9222592243a796077
Gerrit-Change-Number: 80254
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 01 Feb 2024 02:25:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Jakub Czapiga, Julius Werner, Jérémy Compostella, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80251?usp=email )
Change subject: lib: Move IP checksum to commonlib
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80251?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic04c714c00439a17fc04a8a6e730cc2aa19b8e68
Gerrit-Change-Number: 80251
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 01 Feb 2024 02:13:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Johnny Lin, Lance Zhao, Lean Sheng Tan, Patrick Rudolph, Tim Chu, Tim Wawrzynczak.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80258?usp=email )
Change subject: acpi/acpi: Pass struct device to acpi_create_srat_gia_pci
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80258?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iafe32e98f0c85f14347695ccaa0225e43fad99e7
Gerrit-Change-Number: 80258
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 01 Feb 2024 01:53:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment