coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3066 discussions

[XS] Change in coreboot[main]: mb/google/byra/var/anraggar: Set WLAN device type back to pci
by Weimin Wu (Code Review) 01 Feb '24

01 Feb '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng, Subrata Banik. Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80278?usp=email ) Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Gerrit-Change-Number: 80278 Gerrit-PatchSet: 8 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 01 Feb 2024 03:36:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/byra/var/anraggar: Set WLAN device type back to pci
by Qinghong Zeng (Code Review) 01 Feb '24

01 Feb '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80278?usp=email to look at the new patch set (#8). Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci ...................................................................... mb/google/byra/var/anraggar: Set WLAN device type back to pci Refers to commit 4b957b9665 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly. BUG=none TEST=The verification function is normal, and it can pass the FAFT test. Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anraggar/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Gerrit-Change-Number: 80278 Gerrit-PatchSet: 8 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/byra/var/anraggar: Set WLAN device type back to pci
by Qinghong Zeng (Code Review) 01 Feb '24

01 Feb '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80278?usp=email to look at the new patch set (#7). Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci ...................................................................... mb/google/byra/var/anraggar: Set WLAN device type back to pci This part refers to commit 4b957b9665 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly. BUG=null TEST= The verification function is normal, and it can pass the FAFT test. Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anraggar/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Gerrit-Change-Number: 80278 Gerrit-PatchSet: 7 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: drivers/intel/fsp2_0: Add limited to 32-bits FSP 2.4 support
by Subrata Banik (Code Review) 01 Feb '24

01 Feb '24

Attention is currently required from: Andrey Petrov, Bora Guvendik, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Ronak Kanabar, Tarun, Wonkyu Kim. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80275?usp=email ) Change subject: drivers/intel/fsp2_0: Add limited to 32-bits FSP 2.4 support ...................................................................... Patch Set 6: (5 comments) Patchset: PS3: > > quick feedback > > 1. This CL doesn't mentioned the test vehicle used to verify > Test vehicle is not public. Considering the 2.4 specification is public, we can provide the implementation. it doesn't matter but a TEST statement is basic req for any CL to land. Like I'm able to test this CL on some XYZ platform. > > > 2. specify the FSP 2.4 spec link > > I gave the document number but I did not add the link as links can change. There are two doc numbers in the commit msg hence, I'm unable to understand which one is the spec. File src/drivers/intel/fsp2_0/Kconfig: https://review.coreboot.org/c/coreboot/+/80275/comment/76a035f2_9bc0a445 : PS3, Line 58: default n if PLATFORM_USES_FSP2_4 > 2.4 also supports 32-bits. if FSP 2.4 supports both 32/64bit execution hence, I'm unable to follow how one can still select `PLATFORM_USES_FSP2_X86_32` when PLATFORM_USES_FSP2_4 is enabled ? I had an impression that FSP2.4 enforces only 64-bit execution I can see patchset 6 fixes this problem. File src/drivers/intel/fsp2_0/memory_init.c: https://review.coreboot.org/c/coreboot/+/80275/comment/c7bbd33e_3bfe2a68 : PS3, Line 282: error_handler > Considering we are in memory_init.c and this is static function I don't see the benefit of surcharging the function name with unnecessary prefix. the `error_hanlder` function name is very ambiguous as it doesn't clarify the intention of calling this function. adding `fsp_` prefix at minimum is req to make this complete https://review.coreboot.org/c/coreboot/+/80275/comment/8809c7c1_a73eac5d : PS3, Line 297: multi_phase_init > Considering we are in memory_init.c and this is static function I don't see the benefit of surcharging the function name with unnecessary prefix. this to improve the code readability also, https://review.coreboot.org/c/coreboot/+/80275/comment/01d3d332_2dba7f2e/ https://review.coreboot.org/c/coreboot/+/80275/comment/608cd31b_70929ec3 : PS3, Line 437: if (hdr->fsp_multi_phase_mem_init_entry_offset) > Wouldn't it be dangerous to look outside after the limit of the data structure ? These fields are added with 2.4. in that case, check the FSP version index and call into the `fsp_multi_phase_init`. preprocessor macro is not required here IMO and we don't use such unless absolute necessary. -- To view, visit https://review.coreboot.org/c/coreboot/+/80275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1c24d26e105c3dcbd9cca0e7197ab1362344aa97 Gerrit-Change-Number: 80275 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 01 Feb 2024 03:31:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/byra/var/anraggar: Set WLAN device type back to pci
by Qinghong Zeng (Code Review) 01 Feb '24

01 Feb '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80278?usp=email to look at the new patch set (#6). Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci ...................................................................... mb/google/byra/var/anraggar: Set WLAN device type back to pci This part refers to commit 4b957b9665 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly. BUG=NA TEST= Can be compiled normally, the verification function is normal, and it can pass the FAFT test. Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anraggar/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Gerrit-Change-Number: 80278 Gerrit-PatchSet: 6 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/byra/var/anraggar: Set WLAN device type back to pci
by Qinghong Zeng (Code Review) 01 Feb '24

01 Feb '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80278?usp=email to look at the new patch set (#5). Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci ...................................................................... mb/google/byra/var/anraggar: Set WLAN device type back to pci This part refers to https://review.coreboot.org/q/commit:4b957b9665 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly. BUG=NA TEST= Can be compiled normally, the verification function is normal, and it can pass the FAFT test. Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anraggar/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Gerrit-Change-Number: 80278 Gerrit-PatchSet: 5 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/byra/var/anraggar: Set WLAN device type back to pci
by Qinghong Zeng (Code Review) 01 Feb '24

01 Feb '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80278?usp=email to look at the new patch set (#4). Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci ...................................................................... mb/google/byra/var/anraggar: Set WLAN device type back to pci This part refers to commit:4b957b9665 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly. BUG=NA TEST= Can be compiled normally, the verification function is normal, and it can pass the FAFT test. Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anraggar/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Gerrit-Change-Number: 80278 Gerrit-PatchSet: 4 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/byra/var/anraggar: Set WLAN device type back to pci
by Qinghong Zeng (Code Review) 01 Feb '24

01 Feb '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80278?usp=email to look at the new patch set (#3). Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci ...................................................................... mb/google/byra/var/anraggar: Set WLAN device type back to pci This part refers to 4b957b9 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly. BUG=NA TEST= Can be compiled normally, the verification function is normal, and it can pass the FAFT test. Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anraggar/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Gerrit-Change-Number: 80278 Gerrit-PatchSet: 3 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/byra/var/anraggar: Set WLAN device type back to pci
by Qinghong Zeng (Code Review) 01 Feb '24

01 Feb '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80278?usp=email to look at the new patch set (#2). Change subject: mb/google/byra/var/anraggar: Set WLAN device type back to pci ...................................................................... mb/google/byra/var/anraggar: Set WLAN device type back to pci This part refers to 4b957b966543168d70fc3c07511595d33af76059 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly. BUG=NA TEST= Can be compiled normally, the verification function is normal, and it can pass the FAFT test. Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anraggar/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Gerrit-Change-Number: 80278 Gerrit-PatchSet: 2 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: This part refers to 4b957b966543168d70fc3c07511595d33af76059 ("mb/goo...
by Qinghong Zeng (Code Review) 01 Feb '24

01 Feb '24

Qinghong Zeng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80278?usp=email ) Change subject: This part refers to 4b957b966543168d70fc3c07511595d33af76059 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly. ...................................................................... This part refers to 4b957b966543168d70fc3c07511595d33af76059 ("mb/google/byra/var/*: Set WLAN device type back to pci"). Set the WLAN device type to pci uniformly. BUG=NA TEST= Can be compiled normally, the verification function is normal, and it can pass the FAFT test. Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Signed-off-by: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anraggar/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80278/1 diff --git a/src/mainboard/google/brya/variants/anraggar/overridetree.cb b/src/mainboard/google/brya/variants/anraggar/overridetree.cb index 9646f29..f619228 100644 --- a/src/mainboard/google/brya/variants/anraggar/overridetree.cb +++ b/src/mainboard/google/brya/variants/anraggar/overridetree.cb @@ -380,7 +380,7 @@ register "wake" = "GPE0_PME_B0" register "enable_cnvi_ddr_rfim" = "true" register "add_acpi_dma_property" = "true" - device generic 0 on end + device pci 00.0 on end end end device ref pcie_rp4 on -- To view, visit https://review.coreboot.org/c/coreboot/+/80278?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a33362e28c3b9027e9cc5a2e11dc0c316acbd69 Gerrit-Change-Number: 80278 Gerrit-PatchSet: 1 Gerrit-Owner: Qinghong Zeng <zengqinghong(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024