Attention is currently required from: Angel Pons, Elyes Haouas, Felix Singer, Frans Hendriks, Jérémy Compostella, Paul Menzel, Vasiliy Khoruzhick, yuchi.chen(a)intel.com.
Shuo Liu has posted comments on this change by yuchi.chen(a)intel.com. ( https://review.coreboot.org/c/coreboot/+/83321?usp=email )
Change subject: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC
......................................................................
Patch Set 50:
(2 comments)
File src/soc/intel/snowridge/systemagent.c:
https://review.coreboot.org/c/coreboot/+/83321/comment/e01d8097_0b0baed9?us… :
PS15, Line 12: static void get_pcie_bar(struct device *dev, uint16_t index, uint64_t *base, uint64_t *size)
Maybe to rename as get_pcie_config_bar to be more clear?
https://review.coreboot.org/c/coreboot/+/83321/comment/186d4f90_d5936523?us… :
PS15, Line 17: *size = CONFIG_ECAM_MMCONF_LENGTH;
> The PCIe MMCFG limit register holds a wrong value, so using the Kconfig value as a workaround.
Maybe to add a comment here as a note?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83321?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32ad836dfaaff0d1816eac41e5a7d19ece11080f
Gerrit-Change-Number: 83321
Gerrit-PatchSet: 50
Gerrit-Owner: yuchi.chen(a)intel.com
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Vasiliy Khoruzhick <vasilykh(a)arista.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: yuchi.chen(a)intel.com
Gerrit-Attention: Vasiliy Khoruzhick <vasilykh(a)arista.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 08 Nov 2024 08:57:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: yuchi.chen(a)intel.com
Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com>
Attention is currently required from: Angel Pons, Elyes Haouas, Felix Singer, Frans Hendriks, Jérémy Compostella, Paul Menzel, Vasiliy Khoruzhick, yuchi.chen(a)intel.com.
Shuo Liu has posted comments on this change by yuchi.chen(a)intel.com. ( https://review.coreboot.org/c/coreboot/+/83321?usp=email )
Change subject: soc/intel/snowridge: Add support for Intel Atom Snow Ridge SoC
......................................................................
Patch Set 50:
(3 comments)
File src/soc/intel/snowridge/chip.c:
https://review.coreboot.org/c/coreboot/+/83321/comment/83b1eda8_dc7580cd?us… :
PS15, Line 418: }
> Seems there is no `enable` method in the default PCI or PCIe device operations, and the `PCI_COMMAND […]
Acknowledged
File src/soc/intel/snowridge/chip.c:
https://review.coreboot.org/c/coreboot/+/83321/comment/b964d70b_fc48d0fc?us… :
PS50, Line 417: if (is_dev_on_domain0(dev) && is_pch_slot(PCI_DEV2DEVFN(PCI_BDF(dev))) &&
Seems that these static PCH devices will be assigned with an ops later by the PCI probing process, right?
https://review.coreboot.org/c/coreboot/+/83321/comment/3906fa82_3d120241?us… :
PS50, Line 418: (dev->ops == NULL || dev->ops->enable == NULL)) {
What is the benefit of (dev->ops == NULL || dev->ops->enable == NULL)?, just to double confirm it is not enabled by PCI probing yet?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83321?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32ad836dfaaff0d1816eac41e5a7d19ece11080f
Gerrit-Change-Number: 83321
Gerrit-PatchSet: 50
Gerrit-Owner: yuchi.chen(a)intel.com
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Vasiliy Khoruzhick <vasilykh(a)arista.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: yuchi.chen(a)intel.com
Gerrit-Attention: Vasiliy Khoruzhick <vasilykh(a)arista.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 08 Nov 2024 08:53:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: yuchi.chen(a)intel.com
Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com>
Attention is currently required from: Angel Pons, yuchi.chen(a)intel.com.
Shuo Liu has posted comments on this change by yuchi.chen(a)intel.com. ( https://review.coreboot.org/c/coreboot/+/85041?usp=email )
Change subject: soc/intel/common/block/gpmr: Add Kconfig item HAVE_GPMR_REGISTERS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Raise the open
--
To view, visit https://review.coreboot.org/c/coreboot/+/85041?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I975840684b3dd9e9e76ec6a08de12d8dd3c8f08a
Gerrit-Change-Number: 85041
Gerrit-PatchSet: 1
Gerrit-Owner: yuchi.chen(a)intel.com
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: yuchi.chen(a)intel.com
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 08 Nov 2024 08:37:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Angel Pons, yuchi.chen(a)intel.com.
Shuo Liu has posted comments on this change by yuchi.chen(a)intel.com. ( https://review.coreboot.org/c/coreboot/+/85041?usp=email )
Change subject: soc/intel/common/block/gpmr: Add Kconfig item HAVE_GPMR_REGISTERS
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Not quite follow up. If the gpmr.h is referred to, should we always assume GPMR is used?
--
To view, visit https://review.coreboot.org/c/coreboot/+/85041?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I975840684b3dd9e9e76ec6a08de12d8dd3c8f08a
Gerrit-Change-Number: 85041
Gerrit-PatchSet: 1
Gerrit-Owner: yuchi.chen(a)intel.com
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: yuchi.chen(a)intel.com
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 08 Nov 2024 08:37:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84932?usp=email )
Change subject: mb/google/rauru: Configure TPM
......................................................................
Patch Set 11:
(1 comment)
Patchset:
PS11:
`aarch64-elf-ld.bfd: Bootblock exceeded its allotted size! (70K)`
--
To view, visit https://review.coreboot.org/c/coreboot/+/84932?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I582f010a9033ccb1771dbb3ccab9f16314628796
Gerrit-Change-Number: 84932
Gerrit-PatchSet: 11
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Fri, 08 Nov 2024 07:39:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Kyösti Mälkki.
Yu-Ping Wu has posted comments on this change by Kyösti Mälkki. ( https://review.coreboot.org/c/coreboot/+/64972?usp=email )
Change subject: [RFC] device/resource: IOINDEX_SUBTRACTIVE oddities
......................................................................
Patch Set 6:
(1 comment)
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/64972/comment/272cedd1_ac7e94c0?us… :
PS6, Line 179: res->size = conf->mmio_res_io.size;
Despite of many unrelated changes, this patch mainly does two things:
1. Replace `res->limit` assignment with `res->size`
2. Add `IORESOURCE_FIXED` to `res->flags`
Could you please explain the reason in the commit message?
--
To view, visit https://review.coreboot.org/c/coreboot/+/64972?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieff703ed39d69c8ef9edb2e8292ce82eb4e41351
Gerrit-Change-Number: 64972
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-CC: Yidi Lin <yidilin(a)google.com>
Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Fri, 08 Nov 2024 07:35:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No