coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[S] Change in coreboot[main]: [DNM] treewide: Prepare mode switch code for dynamically generated pa...
by Benjamin Doron (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Benjamin Doron, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier. Hello Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79226?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: [DNM] treewide: Prepare mode switch code for dynamically generated paging ...................................................................... [DNM] treewide: Prepare mode switch code for dynamically generated paging Make the long mode entry code generic to prepare for dynamically generated page tables. entry64.inc now expects the caller to load the page tables' address into the EAX register. The mode switch assembly now stashes the previous page table address to restore after the protected mode call is incomplete. Follow-up changes will program/use dynamically generated tables for long mode calls, the SIPI vector and SMM stub. While we're here, fix qemu-x86 code to only get page table address and include entry64.inc for 64-bit environments. This is not a functional change. Untested. Change-Id: I1ef7c8bee0c38395d5436f6479f11b3a4208f53e Signed-off-by: Benjamin Doron <benjamin.doron(a)9elements.com> --- M src/cpu/intel/car/core2/cache_as_ram.S M src/cpu/intel/car/non-evict/cache_as_ram.S M src/cpu/intel/car/p4-netburst/cache_as_ram.S M src/cpu/qemu-x86/cache_as_ram_bootblock.S M src/cpu/x86/64bit/entry64.inc M src/cpu/x86/64bit/mode_switch.S M src/cpu/x86/64bit/mode_switch2.S M src/cpu/x86/64bit/pt.S M src/cpu/x86/sipi_vector.S M src/cpu/x86/smm/smm_stub.S M src/soc/amd/common/block/cpu/noncar/pre_c.S M src/soc/intel/common/block/cpu/car/cache_as_ram.S 12 files changed, 39 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/79226/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79226?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1ef7c8bee0c38395d5436f6479f11b3a4208f53e Gerrit-Change-Number: 79226 Gerrit-PatchSet: 2 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: arch/x86/c_start.S: Add proper x86_64 code
by Benjamin Doron (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Angel Pons, Felix Singer, Jérémy Compostella, Martin L Roth, Patrick Rudolph, Paul Menzel, Tim Wawrzynczak. Benjamin Doron has uploaded a new patch set (#6) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/59874?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by Martin L Roth, Verified+1 by build bot (Jenkins) Change subject: arch/x86/c_start.S: Add proper x86_64 code ...................................................................... arch/x86/c_start.S: Add proper x86_64 code Don't truncate upper bits in assembly code and thus allow loading of ramstage above 4GiB. Tested on qemu with cbmem_top set to TOUUD. Change-Id: Ifc9b45f69d0b7534b2faacaad0d099cef2667478 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Co-authored-by: Benjamin Doron <benjamin.doron(a)9elements.com> --- M src/arch/x86/c_start.S 1 file changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/59874/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/59874?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc9b45f69d0b7534b2faacaad0d099cef2667478 Gerrit-Change-Number: 59874 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: mb/google/poppy: Use chipset dt reference names
by Marvin Evers (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Felix Singer, Martin L Roth, Marvin Evers. Hello Felix Singer, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79439?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by Felix Singer, Code-Review+2 by Martin L Roth, Verified+1 by build bot (Jenkins) Change subject: mb/google/poppy: Use chipset dt reference names ...................................................................... mb/google/poppy: Use chipset dt reference names Use the references from the chipset devicetree as this makes the comments superfluous. Built all variants with BUILD_TIMELESS=1 and the resulting binaries remain the same. Change-Id: I22bcde2dea726f47f8d64a762ca147efde0b610d Signed-off-by: Marvin Evers <marvin.evers(a)stud.hs-bochum.de> --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/baseboard/devicetree.cb M src/mainboard/google/poppy/variants/nami/devicetree.cb M src/mainboard/google/poppy/variants/nautilus/devicetree.cb M src/mainboard/google/poppy/variants/nocturne/devicetree.cb M src/mainboard/google/poppy/variants/rammus/devicetree.cb M src/mainboard/google/poppy/variants/soraka/devicetree.cb 7 files changed, 380 insertions(+), 380 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/79439/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/79439?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I22bcde2dea726f47f8d64a762ca147efde0b610d Gerrit-Change-Number: 79439 Gerrit-PatchSet: 5 Gerrit-Owner: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Marvin Evers <marvin.n.evers(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: stoneyridge: Set the SPI read speed as 66MHz
by Martin Roth (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Bao Zheng, Jason Nien, Zheng Bao. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68884?usp=email ) Change subject: stoneyridge: Set the SPI read speed as 66MHz ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Is this still needed, or can it be abandoned? -- To view, visit https://review.coreboot.org/c/coreboot/+/68884?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia6083cfa515abeb2e981ff0ef825970c9311466b Gerrit-Change-Number: 68884 Gerrit-PatchSet: 4 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Tue, 09 Jan 2024 20:34:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: soc/amd/common/psp: Support PSP SMI handler
by Martin Roth (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Marshall Dawson, Martin L Roth, Matt DeVillier, Paul Menzel, Raul Rangel, ritul guru. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/65523?usp=email ) Change subject: soc/amd/common/psp: Support PSP SMI handler ...................................................................... Patch Set 31: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/65523/comment/1b38cd4c_f044a9d4 : PS31, Line 16: See AMD document 55570 revision 3.16 for additional details. Is this public or NDA? Please mention this both here and below. File src/soc/amd/common/block/psp/Kconfig: https://review.coreboot.org/c/coreboot/+/65523/comment/e5442879_baf0fa17 : PS31, Line 23: default n This can probably be left out. By adding it, the default gets set, and nothing loaded after this can change it. If this line is not included, other Kconfig files loaded afterwards have the opportunity to set the default. If nothing sets it, the default value is 'n'. Typically, if you want a default of 'n' it's best just to leave out the default line. File src/soc/amd/common/block/psp/psp_def.h: https://review.coreboot.org/c/coreboot/+/65523/comment/1ce20564_ca8ff616 : PS31, Line 32: Nit: Add a couple more tabs? File src/soc/amd/common/block/psp/psp_gen2.c: https://review.coreboot.org/c/coreboot/+/65523/comment/495fcd38_104025a7 : PS31, Line 119: static bool is_valid_psp_spi_id(u64 id) Put these in a separate file that's only pulled in when we're using PSP SPI code? File src/soc/amd/common/block/psp/psp_p2c.c: https://review.coreboot.org/c/coreboot/+/65523/comment/f29d84b0_9d3b4b3d : PS31, Line 2: #include <device/mmio.h> Nit: add an additional line under the SPDX header? File src/soc/amd/common/block/spi/Kconfig: https://review.coreboot.org/c/coreboot/+/65523/comment/d9309e5e_b0430e22 : PS23, Line 104: SOC_AMD_COMMON_BLOCK_SPI_ALT > This is when there is alternative SPIROM (dual SPIROM), which contains a backup of original SPI or a […] So this isn't SMM specific? Can it go into a separate commit? File src/soc/amd/stoneyridge/include/soc/smi.h: https://review.coreboot.org/c/coreboot/+/65523/comment/fb44a4b9_4d6bc038 : PS31, Line 74: Align -- To view, visit https://review.coreboot.org/c/coreboot/+/65523?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie1f4646101b90bc52c492f35fd26e6ca1e496142 Gerrit-Change-Number: 65523 Gerrit-PatchSet: 31 Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 09 Jan 2024 20:33:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ritul guru <ritul.bits(a)gmail.com> Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: commonlib/fsp_relocate: Fix Coverity Issues
by Martin Roth (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Ed Sharma, Johnny Lin, Jonathan Zhang, Paul Menzel. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68637?usp=email ) Change subject: commonlib/fsp_relocate: Fix Coverity Issues ...................................................................... Patch Set 4: (2 comments) File src/commonlib/fsp_relocate.c: https://review.coreboot.org/c/coreboot/+/68637/comment/026df7c5_cc166dee : PS4, Line 230: offset_limit = roffset + rsize; > Fixes issue reported as below: […] As with below, this doesn't fix the problem that the roffset and rsize are not sanity checked before using them. https://review.coreboot.org/c/coreboot/+/68637/comment/ff102579_ef2a815f : PS4, Line 258: ptr = &pe_base[aoff]; > Fixes the below reported Coverity issue. […] This doesn't verify the value though, so while it may get around the coverity warning, it doesn't "fix" it. To fix the problem, you need to make sure that aoff is a reasonable value before using it as the offset. -- To view, visit https://review.coreboot.org/c/coreboot/+/68637?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I635c62929e8be9a474a91a62c29c3b5ee9b0ee64 Gerrit-Change-Number: 68637 Gerrit-PatchSet: 4 Gerrit-Owner: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 09 Jan 2024 20:17:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ed Sharma <aeddiesharma(a)fb.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Makefile.inc: Enable Wold-style-declaration command option
by Felix Singer (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Arthur Heymans, Elyes Haouas. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71892?usp=email ) Change subject: Makefile.inc: Enable Wold-style-declaration command option ...................................................................... Patch Set 13: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71892/comment/2c5b5d88_d01937d1 : PS12, Line 8: > Add: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71892?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida3fa59edb07e4105ef3cfb6a20cb29680699586 Gerrit-Change-Number: 71892 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 09 Jan 2024 20:03:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Makefile.inc: Enable Wold-style-declaration command option
by Felix Singer (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Arthur Heymans, Elyes Haouas, Felix Singer. Felix Singer has uploaded a new patch set (#13) to the change originally created by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/71892?usp=email ) Change subject: Makefile.inc: Enable Wold-style-declaration command option ...................................................................... Makefile.inc: Enable Wold-style-declaration command option Warn for obsolescent usages, according to the C Standard, in a declaration. For example, warn if storage-class specifiers like static are not the first things in a declaration. Change-Id: Ida3fa59edb07e4105ef3cfb6a20cb29680699586 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M Makefile.inc 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/71892/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/71892?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida3fa59edb07e4105ef3cfb6a20cb29680699586 Gerrit-Change-Number: 71892 Gerrit-PatchSet: 13 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: Makefile.inc: Enable Wold-style-declaration command option
by Martin L Roth (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Arthur Heymans, Elyes Haouas, Felix Singer. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71892?usp=email ) Change subject: Makefile.inc: Enable Wold-style-declaration command option ...................................................................... Patch Set 12: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/71892/comment/97af7c00_550639f6 : PS12, Line 8: Add: Warn for obsolescent usages, according to the C Standard, in a declaration. For example, warn if storage-class specifiers like static are not the first things in a declaration. -- To view, visit https://review.coreboot.org/c/coreboot/+/71892?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida3fa59edb07e4105ef3cfb6a20cb29680699586 Gerrit-Change-Number: 71892 Gerrit-PatchSet: 12 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 09 Jan 2024 19:59:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Disable package c state demotion
by Nick Vaccaro (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Shelley Chen. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79855?usp=email ) Change subject: mb/google/brox: Disable package c state demotion ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79855?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib7b2484de2d84c980550fd951f1e30efab0ee197 Gerrit-Change-Number: 79855 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 19:54:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024