coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[S] Change in coreboot[main]: mb/google/brox: Configure vGPIOs for NVMe
by Nick Vaccaro (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Shelley Chen. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79857?usp=email ) Change subject: mb/google/brox: Configure vGPIOs for NVMe ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79857?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic8a1fdcedf2ec6c7bf1dd00e02ef7c13e9338aac Gerrit-Change-Number: 79857 Gerrit-PatchSet: 3 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 19:53:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: vboot: Add firmware PCR support
by Julius Werner (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Yi Chou. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79437?usp=email ) Change subject: vboot: Add firmware PCR support ...................................................................... Patch Set 8: (1 comment) File src/security/vboot/vboot_logic.c: https://review.coreboot.org/c/coreboot/+/79437/comment/38b3dc8f_dee374a2 : PS8, Line 196: return vboot_extend_pcr(ctx, CONFIG_PCR_FW_VER, FIRMWARE_VERSION_PCR); I just realized, we should probably skip this in recovery mode? In recovery mode we don't have a valid firmware version. -- To view, visit https://review.coreboot.org/c/coreboot/+/79437?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I601ad31e8c893a8e9ae1a9cdd27193edce10ec61 Gerrit-Change-Number: 79437 Gerrit-PatchSet: 8 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Andrey Pronin <apronin(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Andrey Pronin <apronin(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 18:43:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: libpayload: Move back the ttb_buffer section
by Julius Werner (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Paul Menzel, Yi Chou. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79800?usp=email ) Change subject: libpayload: Move back the ttb_buffer section ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79800?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb08878dd4be01d9ed3f96933f774dd6296f76e Gerrit-Change-Number: 79800 Gerrit-PatchSet: 5 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 17:53:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vc/google: Show different logos for different ChromeOS devices
by Julius Werner (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Andrey Petrov, Ronak Kanabar, Shelley Chen, Subrata Banik. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email ) Change subject: vc/google: Show different logos for different ChromeOS devices ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56613d1e7e81e25b31ad034edae0f716c94c4960 Gerrit-Change-Number: 79775 Gerrit-PatchSet: 10 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 17:51:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: 3rdparty/vboot: Update submodule to upstream main
by Julius Werner (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Felix Singer. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79853?usp=email ) Change subject: 3rdparty/vboot: Update submodule to upstream main ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I667376dfc3021fa6d213e3d89917ee228fd14a28 Gerrit-Change-Number: 79853 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Tue, 09 Jan 2024 17:48:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: [DNM] cpu/x86: Unconditionally compile 64-bit entry code
by Benjamin Doron (Code Review) 09 Jan '24

09 Jan '24

Benjamin Doron has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/79227?usp=email ) Change subject: [DNM] cpu/x86: Unconditionally compile 64-bit entry code ...................................................................... Abandoned mode switching is provided for blob compatibility. In our case, the consumer will perform its own mode switch. qemu-x86 fix being merged into previous -- To view, visit https://review.coreboot.org/c/coreboot/+/79227?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idde8609239426de664907df24a016cc35d320553 Gerrit-Change-Number: 79227 Gerrit-PatchSet: 3 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[main]: src/arch/x86/c_start.S: Add proper x86_64 code
by Benjamin Doron (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Angel Pons, Felix Singer, Jérémy Compostella, Martin L Roth, Patrick Rudolph, Paul Menzel, Tim Wawrzynczak. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59874?usp=email ) Change subject: src/arch/x86/c_start.S: Add proper x86_64 code ...................................................................... Patch Set 5: (1 comment) File src/arch/x86/c_start.S: https://review.coreboot.org/c/coreboot/+/59874/comment/0b8427da_07312871 : PS2, Line 99: push_cpu_info : : #if CONFIG(CPU_INFO_V2) : /* Allocate the per_cpu_segment_data on the stack */ : push_per_cpu_segment_data : : #if ENV_X86_64 : /* : * Update the BSP's per_cpu_segment_descriptor to point to the : * per_cpu_segment_data that was allocated on the stack. : */ : set_segment_descriptor_base $per_cpu_segment_descriptors, %esp : : movabs per_cpu_segment_selector, %rax : mov %eax, %gs : #else : /* : * Update the BSP's per_cpu_segment_descriptor to point to the : * per_cpu_segment_data that was allocated on the stack. : */ : set_segment_descriptor_base $per_cpu_segment_descriptors, %esp : : mov per_cpu_segment_selector, %eax : mov %eax, %gs : #endif > Add a comment about removing all of this in the commit message? It's only removed compared to a previous version of this patch? It was dropped in the rebase. -- To view, visit https://review.coreboot.org/c/coreboot/+/59874?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc9b45f69d0b7534b2faacaad0d099cef2667478 Gerrit-Change-Number: 59874 Gerrit-PatchSet: 5 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 09 Jan 2024 16:47:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/nvidia: Put static keyword at the beginning of declarations
by Paul Menzel (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: Felix Singer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79856?usp=email ) Change subject: soc/nvidia: Put static keyword at the beginning of declarations ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79856?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida683319f7a0c428a9e4808821075abdd9fcb504 Gerrit-Change-Number: 79856 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Tue, 09 Jan 2024 16:29:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/byra/var/*: Set WLAN device type back to pci
by Matt DeVillier (Code Review) 09 Jan '24

09 Jan '24

Attention is currently required from: David Ruth, Eric Lai, Nick Vaccaro, Paul Menzel, Subrata Banik. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79794?usp=email ) Change subject: mb/google/byra/var/*: Set WLAN device type back to pci ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79794?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If5dad9deb040c8cb0c507e11726f0ba44ccb2909 Gerrit-Change-Number: 79794 Gerrit-PatchSet: 1 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: David Ruth <druth(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 09 Jan 2024 15:57:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/puff/var/*: Set WLAN device type back to pci
by David Ruth (Code Review) 09 Jan '24

09 Jan '24

David Ruth has uploaded a new patch set (#4). ( https://review.coreboot.org/c/coreboot/+/79795?usp=email ) Change subject: mb/google/puff/var/*: Set WLAN device type back to pci ...................................................................... mb/google/puff/var/*: Set WLAN device type back to pci This mostly reverts commit 6c705e766f7f ("mb/google/puff/var/*: Set LAN/WLAN device type to generic"). Setting the WLAN device type to generic broke ACPI SSDT table definition, so set it back to pci. BUG=b:295544257 TEST=Untested. Change-Id: I574760f0f0a38eb74643382ecd162ca0a18fcc35 Signed-off-by: David Ruth <druth(a)chromium.org> --- M src/mainboard/google/puff/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/79795/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/79795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I574760f0f0a38eb74643382ecd162ca0a18fcc35 Gerrit-Change-Number: 79795 Gerrit-PatchSet: 4 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024